Tidy up tests (#48)

This commit is intended to mostly colocate references to the codeowners
file in one place within tests.

Author: Alex Evanczuk

spec/lib/code_ownership/private/extension_loader_spec.rb

@@ -66,7 +66,7 @@ def bust_caches!
         end
       RUBY
 
-      expect_any_instance_of(codeowners_validation).to receive(:`).with("git add #{Pathname.pwd.join('.github/CODEOWNERS')}") # rubocop:disable RSpec/AnyInstance
+      expect_any_instance_of(codeowners_validation).to receive(:`).with("git add #{codeowners_path}") # rubocop:disable RSpec/AnyInstance
     end
 
     after(:all) do
@@ -90,7 +90,7 @@ def bust_caches!
 
       it 'allows extensions to add to codeowners list' do
         expect { CodeOwnership.validate! }.to raise_error(CodeOwnership::InvalidCodeOwnershipConfigurationError)
-        expect(Pathname.new('.github/CODEOWNERS').read).to eq <<~EXPECTED
+        expect(codeowners_path.read).to eq <<~EXPECTED
           # STOP! - DO NOT EDIT THIS FILE MANUALLY
           # This file was automatically generated by "bin/codeownership validate".
           #

spec/lib/code_ownership/private/ownership_mappers/package_ownership_spec.rb

@@ -13,6 +13,8 @@ module CodeOwnership
           owner: Bar
       CONTENTS
 
+      write_file('packs/my_other_package/my_file.rb')
+
       write_file('package.yml', <<~CONTENTS)
         enforce_dependency: true
         enforce_privacy: true

spec/lib/code_ownership/private/validations/github_codeowners_up_to_date_spec.rb

@@ -10,10 +10,10 @@ module CodeOwnership
 
         context 'in an empty application' do
           it 'automatically regenerates the codeowners file' do
-            expect(Pathname.new('.github/CODEOWNERS')).to_not exist
-            expect_any_instance_of(codeowners_validation).to receive(:`).with("git add #{Pathname.pwd.join('.github/CODEOWNERS')}") # rubocop:disable RSpec/AnyInstance
+            expect(codeowners_path).to_not exist
+            expect_any_instance_of(codeowners_validation).to receive(:`).with("git add #{codeowners_path}") # rubocop:disable RSpec/AnyInstance
             expect { CodeOwnership.validate! }.to_not raise_error
-            expect(Pathname.new('.github/CODEOWNERS').read).to eq <<~EXPECTED
+            expect(codeowners_path.read).to eq <<~EXPECTED
               # STOP! - DO NOT EDIT THIS FILE MANUALLY
               # This file was automatically generated by "bin/codeownership validate".
               #
@@ -30,10 +30,10 @@ module CodeOwnership
           before { create_non_empty_application }
 
           it 'automatically regenerates the codeowners file' do
-            expect(Pathname.new('.github/CODEOWNERS')).to_not exist
-            expect_any_instance_of(codeowners_validation).to receive(:`).with("git add #{Pathname.pwd.join('.github/CODEOWNERS')}") # rubocop:disable RSpec/AnyInstance
+            expect(codeowners_path).to_not exist
+            expect_any_instance_of(codeowners_validation).to receive(:`).with("git add #{codeowners_path}") # rubocop:disable RSpec/AnyInstance
             expect { CodeOwnership.validate! }.to_not raise_error
-            expect(Pathname.new('.github/CODEOWNERS').read).to eq <<~EXPECTED
+            expect(codeowners_path.read).to eq <<~EXPECTED
               # STOP! - DO NOT EDIT THIS FILE MANUALLY
               # This file was automatically generated by "bin/codeownership validate".
               #
@@ -64,10 +64,10 @@ module CodeOwnership
 
           context 'the user has passed in specific input files into the validate method' do
             it 'still automatically regenerates the codeowners file, since we look at all files when regenerating CODEOWNERS' do
-              expect(Pathname.new('.github/CODEOWNERS')).to_not exist
-              expect_any_instance_of(codeowners_validation).to receive(:`).with("git add #{Pathname.pwd.join('.github/CODEOWNERS')}") # rubocop:disable RSpec/AnyInstance
+              expect(codeowners_path).to_not exist
+              expect_any_instance_of(codeowners_validation).to receive(:`).with("git add #{codeowners_path}") # rubocop:disable RSpec/AnyInstance
               expect { CodeOwnership.validate! }.to_not raise_error
-              expect(Pathname.new('.github/CODEOWNERS').read).to eq <<~EXPECTED
+              expect(codeowners_path.read).to eq <<~EXPECTED
                 # STOP! - DO NOT EDIT THIS FILE MANUALLY
                 # This file was automatically generated by "bin/codeownership validate".
                 #
@@ -108,10 +108,10 @@ module CodeOwnership
             end
 
             it 'does not include the team in the output' do
-              expect(Pathname.new('.github/CODEOWNERS')).to_not exist
+              expect(codeowners_path).to_not exist
               expect { CodeOwnership.validate! }.to_not raise_error
               expect_any_instance_of(codeowners_validation).to_not receive(:`) # rubocop:disable RSpec/AnyInstance
-              expect(Pathname.new('.github/CODEOWNERS').read).to eq <<~EXPECTED
+              expect(codeowners_path.read).to eq <<~EXPECTED
                 # STOP! - DO NOT EDIT THIS FILE MANUALLY
                 # This file was automatically generated by "bin/codeownership validate".
                 #
@@ -138,10 +138,10 @@ module CodeOwnership
             end
 
             it 'does not include the team in the output' do
-              expect(Pathname.new('.github/CODEOWNERS')).to_not exist
+              expect(codeowners_path).to_not exist
               expect { CodeOwnership.validate! }.to_not raise_error
               expect_any_instance_of(codeowners_validation).to_not receive(:`) # rubocop:disable RSpec/AnyInstance
-              expect(Pathname.new('.github/CODEOWNERS').read).to eq <<~EXPECTED
+              expect(codeowners_path.read).to eq <<~EXPECTED
                 # STOP! - DO NOT EDIT THIS FILE MANUALLY
                 # This file was automatically generated by "bin/codeownership validate".
                 #
@@ -161,10 +161,10 @@ module CodeOwnership
           end
 
           it 'does not stage the changes to the codeowners file' do
-            expect(Pathname.new('.github/CODEOWNERS')).to_not exist
+            expect(codeowners_path).to_not exist
             expect_any_instance_of(codeowners_validation).to_not receive(:`) # rubocop:disable RSpec/AnyInstance
             expect { CodeOwnership.validate!(stage_changes: false) }.to_not raise_error
-            expect(Pathname.new('.github/CODEOWNERS').read).to eq <<~EXPECTED
+            expect(codeowners_path.read).to eq <<~EXPECTED
               # STOP! - DO NOT EDIT THIS FILE MANUALLY
               # This file was automatically generated by "bin/codeownership validate".
               #
@@ -185,7 +185,7 @@ module CodeOwnership
 
         context 'in an empty application' do
           it 'automatically regenerates the codeowners file' do
-            expect(Pathname.new('.github/CODEOWNERS')).to_not exist
+            expect(codeowners_path).to_not exist
             expect_any_instance_of(codeowners_validation).to_not receive(:`) # rubocop:disable RSpec/AnyInstance
             expect { CodeOwnership.validate!(autocorrect: false) }.to raise_error do |e|
               expect(e).to be_a CodeOwnership::InvalidCodeOwnershipConfigurationError
@@ -196,15 +196,15 @@ module CodeOwnership
                 See https://github.com/rubyatscale/code_ownership#README.md for more details
               EXPECTED
             end
-            expect(Pathname.new('.github/CODEOWNERS')).to_not exist
+            expect(codeowners_path).to_not exist
           end
         end
 
         context 'in an non-empty application' do
           before { create_non_empty_application }
 
           it 'automatically regenerates the codeowners file' do
-            expect(Pathname.new('.github/CODEOWNERS')).to_not exist
+            expect(codeowners_path).to_not exist
             expect_any_instance_of(codeowners_validation).to_not receive(:`) # rubocop:disable RSpec/AnyInstance
             expect { CodeOwnership.validate!(autocorrect: false) }.to raise_error do |e|
               expect(e).to be_a CodeOwnership::InvalidCodeOwnershipConfigurationError
@@ -215,7 +215,7 @@ module CodeOwnership
                 See https://github.com/rubyatscale/code_ownership#README.md for more details
               EXPECTED
             end
-            expect(Pathname.new('.github/CODEOWNERS')).to_not exist
+            expect(codeowners_path).to_not exist
           end
 
           context 'team does not have a github team listed' do
@@ -229,7 +229,7 @@ module CodeOwnership
             end
 
             it 'does not include the team in the output' do
-              expect(Pathname.new('.github/CODEOWNERS')).to_not exist
+              expect(codeowners_path).to_not exist
               expect_any_instance_of(codeowners_validation).to_not receive(:`) # rubocop:disable RSpec/AnyInstance
               expect { CodeOwnership.validate!(autocorrect: false) }.to raise_error do |e|
                 expect(e).to be_a CodeOwnership::InvalidCodeOwnershipConfigurationError
@@ -240,7 +240,7 @@ module CodeOwnership
                   See https://github.com/rubyatscale/code_ownership#README.md for more details
                 EXPECTED
               end
-              expect(Pathname.new('.github/CODEOWNERS')).to_not exist
+              expect(codeowners_path).to_not exist
             end
           end
 
@@ -258,7 +258,7 @@ module CodeOwnership
             end
 
             it 'does not include the team in the output' do
-              expect(Pathname.new('.github/CODEOWNERS')).to_not exist
+              expect(codeowners_path).to_not exist
               expect_any_instance_of(codeowners_validation).to_not receive(:`) # rubocop:disable RSpec/AnyInstance
               expect { CodeOwnership.validate!(autocorrect: false) }.to raise_error do |e|
                 expect(e).to be_a CodeOwnership::InvalidCodeOwnershipConfigurationError
@@ -269,7 +269,7 @@ module CodeOwnership
                   See https://github.com/rubyatscale/code_ownership#README.md for more details
                 EXPECTED
               end
-              expect(Pathname.new('.github/CODEOWNERS')).to_not exist
+              expect(codeowners_path).to_not exist
             end
           end
         end
@@ -279,7 +279,7 @@ module CodeOwnership
 
           it 'prints out the diff' do
             FileUtils.mkdir('.github')
-            Pathname.new('.github/CODEOWNERS').write <<~CODEOWNERS
+            codeowners_path.write <<~CODEOWNERS
               # STOP! - DO NOT EDIT THIS FILE MANUALLY
               # This file was automatically generated by "bin/codeownership validate".
               #
@@ -335,7 +335,7 @@ module CodeOwnership
 
           it 'prints out the diff' do
             FileUtils.mkdir('.github')
-            Pathname.new('.github/CODEOWNERS').write <<~CODEOWNERS
+            codeowners_path.write <<~CODEOWNERS
               # STOP! - DO NOT EDIT THIS FILE MANUALLY
               # This file was automatically generated by "bin/codeownership validate".
               #
@@ -388,7 +388,7 @@ module CodeOwnership
 
           it 'prints out the diff' do
             FileUtils.mkdir('.github')
-            Pathname.new('.github/CODEOWNERS').write <<~CODEOWNERS
+            codeowners_path.write <<~CODEOWNERS
               # STOP! - DO NOT EDIT THIS FILE MANUALLY
               # This file was automatically generated by "bin/codeownership validate".
               #
@@ -443,10 +443,10 @@ module CodeOwnership
         end
 
         it 'skips validating the codeowners file' do
-          expect(Pathname.new('.github/CODEOWNERS')).to_not exist
+          expect(codeowners_path).to_not exist
           expect_any_instance_of(codeowners_validation).to_not receive(:`) # rubocop:disable RSpec/AnyInstance
           expect { CodeOwnership.validate!(autocorrect: false) }.to_not raise_error
-          expect(Pathname.new('.github/CODEOWNERS')).to_not exist
+          expect(codeowners_path).to_not exist
         end
       end
     end

spec/spec_helper.rb

@@ -19,6 +19,8 @@
   config.include_context 'application fixtures'
 
   config.before do |c|
+    codeowners_path.delete if codeowners_path.exist?
+
     unless c.metadata[:do_not_bust_cache]
       CodeOwnership.bust_caches!
       CodeTeams.bust_caches!

spec/support/application_fixtures.rb

@@ -1,4 +1,6 @@
 RSpec.shared_context 'application fixtures' do
+  let(:codeowners_path) { Pathname.pwd.join('.github/CODEOWNERS') }
+
   let(:create_configuration) do
     write_file('config/code_ownership.yml', <<~YML)
       owned_globs:
@@ -9,7 +11,7 @@
   let(:create_minimal_configuration) do
     write_file('config/code_ownership.yml', <<~YML)
       owned_globs:
-        - app/**/*.rb
+        - app/**/*.{rb,jsx}
     YML
   end