for_class accepts string, remove unnecessary conversions (#39)

* for_class accepts string, remove unnecessary conversions

* 1.32.1, bundle update

Author: nate-at-gusto

Gemfile.lock

@@ -13,17 +13,19 @@ GEM
     code_teams (1.0.1)
       sorbet-runtime
     coderay (1.1.3)
-    diff-lcs (1.4.4)
+    diff-lcs (1.5.0)
     method_source (1.0.0)
+    netrc (0.11.0)
     packs (0.0.6)
       sorbet-runtime
-    parser (3.1.2.0)
+    parallel (1.22.1)
+    parser (3.2.1.1)
       ast (~> 2.4.1)
-    pry (0.14.1)
+    pry (0.14.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
     rake (13.0.6)
-    rbi (0.0.14)
+    rbi (0.0.16)
       ast
       parser (>= 2.6.4.0)
       sorbet-runtime (>= 0.5.9204)
@@ -41,39 +43,43 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
     rspec-support (3.10.2)
-    sorbet (0.5.9889)
-      sorbet-static (= 0.5.9889)
-    sorbet-runtime (0.5.9889)
-    sorbet-static (0.5.9889-universal-darwin-14)
-    sorbet-static (0.5.9889-universal-darwin-15)
-    sorbet-static (0.5.9889-universal-darwin-16)
-    sorbet-static (0.5.9889-universal-darwin-17)
-    sorbet-static (0.5.9889-universal-darwin-18)
-    sorbet-static (0.5.9889-universal-darwin-19)
-    sorbet-static (0.5.9889-universal-darwin-20)
-    sorbet-static (0.5.9889-universal-darwin-21)
-    sorbet-static (0.5.9889-x86_64-linux)
-    spoom (1.1.11)
-      sorbet (>= 0.5.9204)
+    sorbet (0.5.10707)
+      sorbet-static (= 0.5.10707)
+    sorbet-runtime (0.5.10707)
+    sorbet-static (0.5.10707-universal-darwin-14)
+    sorbet-static (0.5.10707-universal-darwin-15)
+    sorbet-static (0.5.10707-universal-darwin-16)
+    sorbet-static (0.5.10707-universal-darwin-17)
+    sorbet-static (0.5.10707-universal-darwin-18)
+    sorbet-static (0.5.10707-universal-darwin-19)
+    sorbet-static (0.5.10707-universal-darwin-20)
+    sorbet-static (0.5.10707-universal-darwin-21)
+    sorbet-static (0.5.10707-universal-darwin-22)
+    sorbet-static (0.5.10707-x86_64-linux)
+    sorbet-static-and-runtime (0.5.10707)
+      sorbet (= 0.5.10707)
+      sorbet-runtime (= 0.5.10707)
+    spoom (1.1.16)
+      sorbet (>= 0.5.10187)
       sorbet-runtime (>= 0.5.9204)
       thor (>= 0.19.2)
-    tapioca (0.7.2)
+    tapioca (0.11.1)
       bundler (>= 1.17.3)
-      pry (>= 0.12.2)
-      rbi (~> 0.0.0, >= 0.0.14)
-      sorbet-runtime (>= 0.5.9204)
-      sorbet-static (>= 0.5.9204)
+      netrc (>= 0.11.0)
+      parallel (>= 1.21.0)
+      rbi (~> 0.0.0, >= 0.0.16)
+      sorbet-static-and-runtime (>= 0.5.10187)
       spoom (~> 1.1.0, >= 1.1.11)
       thor (>= 1.2.0)
       yard-sorbet
     thor (1.2.1)
-    unparser (0.6.4)
+    unparser (0.6.7)
       diff-lcs (~> 1.3)
-      parser (>= 3.1.0)
+      parser (>= 3.2.0)
     webrick (1.7.0)
-    yard (0.9.27)
+    yard (0.9.28)
       webrick (~> 1.7.0)
-    yard-sorbet (0.6.1)
+    yard-sorbet (0.8.0)
       sorbet-runtime (>= 0.5)
       yard (>= 0.9)
 

lib/code_ownership.rb

@@ -149,20 +149,23 @@ def backtrace_with_ownership(backtrace)
   end
   private_class_method(:backtrace_with_ownership)
 
-  sig { params(klass: T.nilable(T.any(Class, Module))).returns(T.nilable(::CodeTeams::Team)) }
+  sig { params(klass: T.nilable(T.any(Class, Module, String))).returns(T.nilable(::CodeTeams::Team)) }
   def for_class(klass)
     @memoized_values ||= T.let(@memoized_values, T.nilable(T::Hash[String, T.nilable(::CodeTeams::Team)]))
     @memoized_values ||= {}
+
+    klass_string = klass.to_s
+
     # We use key because the memoized value could be `nil`
-    if !@memoized_values.key?(klass.to_s)
-      path = Private.path_from_klass(klass)
+    if !@memoized_values.key?(klass_string)
+      path = Private.path_from_klass_string(klass_string)
       return nil if path.nil?
 
       value_to_memoize = for_file(path)
-      @memoized_values[klass.to_s] = value_to_memoize
+      @memoized_values[klass_string] = value_to_memoize
       value_to_memoize
     else
-      @memoized_values[klass.to_s]
+      @memoized_values[klass_string]
     end
   end
 

lib/code_ownership/private.rb

@@ -58,10 +58,10 @@ def self.validate!(files:, autocorrect: true, stage_changes: true)
 
     # Returns a string version of the relative path to a Rails constant,
     # or nil if it can't find something
-    sig { params(klass: T.nilable(T.any(Class, Module))).returns(T.nilable(String)) }
-    def self.path_from_klass(klass)
-      if klass
-        path = Object.const_source_location(klass.to_s)&.first
+    sig { params(klass_string: T.nilable(String)).returns(T.nilable(String)) }
+    def self.path_from_klass_string(klass_string)
+      if klass_string
+        path = Object.const_source_location(klass_string)&.first
         (path && Pathname.new(path).relative_path_from(Pathname.pwd).to_s) || nil
       else
         nil