Sorbet issues fixed

Author: joemsak

lib/code_teams.rb

@@ -15,7 +15,7 @@ module CodeTeams
   class IncorrectPublicApiUsageError < StandardError; end
 
   UNKNOWN_TEAM_STRING = 'Unknown Team'
-  @plugins_registered = false
+  @plugins_registered = T.let(false, T::Boolean)
 
   sig { returns(T::Array[Team]) }
   def self.all
@@ -99,7 +99,7 @@ def self.register_plugins
         # e.g., def github (on Team)
         define_method(plugin.data_accessor_name) do
           # e.g., MyGithubPlugin.for(team).github
-          plugin.for(self).public_send(plugin.data_accessor_name)
+          plugin.for(T.cast(self, Team)).public_send(plugin.data_accessor_name)
         end
       end
     end

lib/code_teams/plugin.rb

@@ -10,6 +10,8 @@ class Plugin
 
     abstract!
 
+    @data_accessor_name = T.let(nil, T.nilable(String))
+
     sig { params(team: Team).void }
     def initialize(team)
       @team = team

sorbet/rbi/todo.rbi

@@ -4,3 +4,4 @@
 # typed: strong
 module ::RSpec; end
 module ::TestPlugin; end
+module TestNamespace::TestPlugin; end

spec/lib/plugin_spec.rb

@@ -1,42 +1,41 @@
-RSpec.describe CodeTeams::Plugin do
-  before do
-    CodeTeams.bust_caches!
-
-    test_plugin_class = Class.new(described_class) do
-      def extra_data
-        @team.raw_hash['extra_data']
-      end
-    end
-    stub_const('TestPlugin', test_plugin_class)
-  end
+module TestNamespace; end
 
+RSpec.describe CodeTeams::Plugin do
   describe '.bust_caches!' do
     it 'clears all plugins team registries ensuring cached configs are purged' do
+      test_plugin_class = Class.new(described_class) do
+        def extra_data
+          @team.raw_hash['extra_data']
+        end
+      end
+      stub_const('TestNamespace::TestPlugin', test_plugin_class)
+
+      CodeTeams.bust_caches!
       write_team_yml(extra_data: true)
       team = CodeTeams.find('My Team')
-      expect(TestPlugin.for(team).extra_data).to be(true)
+      expect(TestNamespace::TestPlugin.for(team).extra_data).to be(true)
       write_team_yml(extra_data: false)
       CodeTeams.bust_caches!
       team = CodeTeams.find('My Team')
-      expect(TestPlugin.for(team).extra_data).to be(false)
+      expect(TestNamespace::TestPlugin.for(team).extra_data).to be(false)
     end
   end
 
   describe '.data_accessor_name' do
     it 'returns the underscore version of the plugin name' do
       test_plugin_class = Class.new(described_class)
-      stub_const('FooNamespace::TestPlugin', test_plugin_class)
+      stub_const('TestNamespace::TestPlugin', test_plugin_class)
 
-      expect(FooNamespace::TestPlugin.data_accessor_name).to eq('test_plugin')
+      expect(TestNamespace::TestPlugin.data_accessor_name).to eq('test_plugin')
     end
 
     it 'can be overridden by a subclass' do
       test_plugin_class = Class.new(described_class) do
         data_accessor_name 'foo'
       end
-      stub_const('TestPlugin', test_plugin_class)
+      stub_const('TestNamespace::TestPlugin', test_plugin_class)
 
-      expect(TestPlugin.data_accessor_name).to eq('foo')
+      expect(TestNamespace::TestPlugin.data_accessor_name).to eq('foo')
     end
   end
 end