Simplify executable_path handling by using String directly

Author: perryqh

src/runner.rs

@@ -47,7 +47,7 @@ where
 pub(crate) fn config_from_run_config(run_config: &RunConfig) -> Result<Config, Error> {
     match crate::config::Config::load_from_path(&run_config.config_path) {
         Ok(mut c) => {
-            if let Some(executable_name) = &run_config.executable_name() {
+            if let Some(executable_name) = &run_config.executable_path {
                 c.executable_name = executable_name.clone();
             }
             Ok(c)

src/runner/types.rs

@@ -4,8 +4,6 @@ use std::path::PathBuf;
 use error_stack::Context;
 use serde::{Deserialize, Serialize};
 
-use crate::path_utils::relative_to_buf;
-
 #[derive(Debug, Default, Serialize, Deserialize)]
 pub struct RunResult {
     pub validation_errors: Vec<String>,
@@ -19,15 +17,7 @@ pub struct RunConfig {
     pub codeowners_file_path: PathBuf,
     pub config_path: PathBuf,
     pub no_cache: bool,
-    pub executable_path: Option<PathBuf>,
-}
-
-impl RunConfig {
-    pub fn executable_name(&self) -> Option<String> {
-        self.executable_path
-            .as_ref()
-            .map(|path| relative_to_buf(&self.project_root, path).to_string_lossy().to_string())
-    }
+    pub executable_path: Option<String>,
 }
 
 #[derive(Debug, Serialize)]

tests/run_config_executable_override_test.rs

@@ -1,5 +1,5 @@
 use std::error::Error;
-use std::path::{Path, PathBuf};
+use std::path::Path;
 
 mod common;
 use common::{build_run_config, git_add_all_files, setup_fixture_repo};
@@ -18,7 +18,7 @@ fn test_run_config_executable_path_overrides_config_file() -> Result<(), Box<dyn
 
     let mut run_config = build_run_config(project_path, ".github/CODEOWNERS");
     // Use a relative path that gets displayed as-is in error messages
-    run_config.executable_path = Some(PathBuf::from("my-wrapper-tool"));
+    run_config.executable_path = Some("my-wrapper-tool".to_string());
 
     let result = validate(&run_config, vec![]);
 
@@ -78,7 +78,7 @@ fn test_run_config_executable_path_overrides_default() -> Result<(), Box<dyn Err
     // This fixture has NO executable_name in config (uses default "codeowners")
 
     let mut run_config = build_run_config(project_path, ".github/CODEOWNERS");
-    run_config.executable_path = Some(PathBuf::from("custom-command"));
+    run_config.executable_path = Some("custom-command".to_string());
 
     let result = validate(&run_config, vec![]);
 
@@ -97,31 +97,3 @@ fn test_run_config_executable_path_overrides_default() -> Result<(), Box<dyn Err
 
     Ok(())
 }
-
-#[test]
-fn test_executable_name_extraction_from_path() {
-    use codeowners::runner::RunConfig;
-
-    let mut run_config = RunConfig {
-        project_root: PathBuf::from("."),
-        codeowners_file_path: PathBuf::from(".github/CODEOWNERS"),
-        config_path: PathBuf::from("config/code_ownership.yml"),
-        no_cache: true,
-        executable_path: None,
-    };
-
-    // Test with None
-    assert_eq!(run_config.executable_name(), None);
-
-    // Test with simple path (no directory component)
-    run_config.executable_path = Some(PathBuf::from("codeowners"));
-    assert_eq!(run_config.executable_name(), Some("codeowners".to_string()));
-
-    // Test with relative path - returns full relative path string
-    run_config.executable_path = Some(PathBuf::from("bin/codeownership"));
-    assert_eq!(run_config.executable_name(), Some("bin/codeownership".to_string()));
-
-    // Test with another relative path
-    run_config.executable_path = Some(PathBuf::from("tools/my-tool"));
-    assert_eq!(run_config.executable_name(), Some("tools/my-tool".to_string()));
-}