Fix flaky tests and resolve cargo clippy warnings (#31)

* Fix sorting issue in flaky specs

* Resolve clippy warnings

* Update pre-commit clippy config

matches upcoming change to GH workflow

Author: jackboberg

.rusty-hook.toml

@@ -1,5 +1,5 @@
 [hooks]
-pre-commit = "cargo clippy -- -Dwarnings && cargo test && cargo fmt -- --check"
+pre-commit = "cargo clippy --all-targets --all-features -- -D warnings && cargo test && cargo fmt -- --check"
 
 [logging]
 verbose = true

src/common_test.rs

@@ -237,7 +237,7 @@ team_file_glob:
                     .to_owned(),
             }],
         );
-        Ok(build_ownership(test_config)?)
+        build_ownership(test_config)
     }
     pub fn build_ownership_with_team_gem_codeowners() -> Result<Ownership, Box<dyn Error>> {
         ownership!(
@@ -264,7 +264,7 @@ team_file_glob:
         let temp_dir = tempdir()?;
 
         let test_config = TestConfig::new(temp_dir.path().to_path_buf(), vec![]);
-        Ok(build_ownership(test_config)?)
+        build_ownership(test_config)
     }
     pub fn build_ownership_with_package_codeowners() -> Result<Ownership, Box<dyn Error>> {
         ownership!(

src/ownership/mapper.rs

@@ -62,7 +62,7 @@ mod tests {
             team_name: team_name.clone(),
             source: source.clone(),
         };
-        let response = owner_matcher.owner_for(&Path::new(relative_path));
+        let response = owner_matcher.owner_for(Path::new(relative_path));
         if expect_match {
             assert_eq!(response, (Some(&team_name), &source));
         } else {

src/ownership/mapper/team_file_mapper.rs

@@ -76,18 +76,19 @@ mod tests {
     fn test_entries() -> Result<(), Box<dyn Error>> {
         let ownership = build_ownership_with_all_mappers()?;
         let mapper = TeamFileMapper::build(ownership.project.clone());
-        let entries = mapper.entries();
+        let mut entries = mapper.entries();
+        entries.sort_by_key(|e| e.path.clone());
         assert_eq!(
             entries,
             vec![
                 Entry {
-                    path: "packs/zebra/app/services/team_file_owned.rb".to_owned(),
+                    path: "packs/jscomponents/comp.ts".to_owned(),
                     github_team: "@Foo".to_owned(),
                     team_name: "Foo".to_owned(),
                     disabled: false
                 },
                 Entry {
-                    path: "packs/jscomponents/comp.ts".to_owned(),
+                    path: "packs/zebra/app/services/team_file_owned.rb".to_owned(),
                     github_team: "@Foo".to_owned(),
                     team_name: "Foo".to_owned(),
                     disabled: false

src/ownership/mapper/team_yml_mapper.rs

@@ -58,14 +58,15 @@ mod tests {
     fn test_entries() -> Result<(), Box<dyn Error>> {
         let ownership = build_ownership_with_all_mappers()?;
         let mapper = TeamYmlMapper::build(ownership.project.clone());
-        let entries = mapper.entries();
+        let mut entries = mapper.entries();
+        entries.sort_by_key(|e| e.path.clone());
         assert_eq!(
             entries,
             vec![
                 Entry {
-                    path: "config/teams/foo.yml".to_owned(),
-                    github_team: "@Foo".to_owned(),
-                    team_name: "Foo".to_owned(),
+                    path: "config/teams/bam.yml".to_owned(),
+                    github_team: "@Bam".to_owned(),
+                    team_name: "Bam".to_owned(),
                     disabled: false
                 },
                 Entry {
@@ -74,17 +75,17 @@ mod tests {
                     team_name: "Bar".to_owned(),
                     disabled: false
                 },
-                Entry {
-                    path: "config/teams/bam.yml".to_owned(),
-                    github_team: "@Bam".to_owned(),
-                    team_name: "Bam".to_owned(),
-                    disabled: false
-                },
                 Entry {
                     path: "config/teams/baz.yml".to_owned(),
                     github_team: "@Baz".to_owned(),
                     team_name: "Baz".to_owned(),
                     disabled: false
+                },
+                Entry {
+                    path: "config/teams/foo.yml".to_owned(),
+                    github_team: "@Foo".to_owned(),
+                    team_name: "Foo".to_owned(),
+                    disabled: false
                 }
             ]
         );