presence of .codeowners-skip-untracked-files skips untracked files

Author: perryqh

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "codeowners"
-version = "0.2.11"
+version = "0.2.12"
 edition = "2024"
 
 [profile.release]

Cargo.toml

@@ -25,8 +25,8 @@ pub struct Config {
     #[serde(default = "default_ignore_dirs")]
     pub ignore_dirs: Vec<String>,
 
-    #[serde(default = "default_skip_untracked_files")]
-    pub skip_untracked_files: bool,
+    #[serde(default = "default_skip_untracked_files_config_path")]
+    pub skip_untracked_files_config_path: String,
 }
 
 #[allow(dead_code)]
@@ -63,8 +63,8 @@ fn vendored_gems_path() -> String {
     "vendored/".to_string()
 }
 
-fn default_skip_untracked_files() -> bool {
-    true
+fn default_skip_untracked_files_config_path() -> String {
+    ".codeowners-skip-untracked-files".to_string()
 }
 
 fn default_ignore_dirs() -> Vec<String> {

src/config.rs

@@ -303,7 +303,7 @@ mod tests {
             vendored_gems_path: vendored_path.to_string(),
             cache_directory: "tmp/cache/codeowners".to_string(),
             ignore_dirs: vec![],
-            skip_untracked_files: false,
+            skip_untracked_files_config_path: ".codeowners-skip-untracked-files".to_string(),
         }
     }
 

src/ownership/for_file_fast.rs

@@ -61,7 +61,7 @@ impl<'a> ProjectBuilder<'a> {
         // Prune traversal early: skip heavy and irrelevant directories
         let ignore_dirs = self.config.ignore_dirs.clone();
         let base_path = self.base_path.clone();
-        let untracked_files = if self.config.skip_untracked_files {
+        let untracked_files = if skip_untracked_files_config_path_exists(&self.base_path, &self.config.skip_untracked_files_config_path) {
             files::untracked_files(&base_path).unwrap_or_default()
         } else {
             vec![]
@@ -297,6 +297,12 @@ fn matches_globs(path: &Path, globs: &[String]) -> bool {
     }
 }
 
+// If skip_untracked_files_config_path exists, we skip untracked files. We don't do this be default because it's slow.
+fn skip_untracked_files_config_path_exists(base_path: &Path, skip_untracked_files_config_path: &str) -> bool {
+    let path = base_path.join(skip_untracked_files_config_path);
+    path.exists()
+}
+
 fn ruby_package_owner(path: &Path) -> Result<Option<String>, Error> {
     let file = File::open(path).change_context(Error::Io)?;
     let deserializer: deserializers::RubyPackage = serde_yaml::from_reader(file).change_context(Error::SerdeYaml)?;

src/project_builder.rs

@@ -8,4 +8,3 @@ team_file_glob:
   - config/teams/**/*.yml
 vendored_gems_path: gems
 unowned_globs:
-skip_untracked_files: false

tests/fixtures/invalid_project/config/code_ownership.yml

@@ -7,5 +7,4 @@ javascript_package_paths:
   - javascript/packages/**
 vendored_gems_path: gems
 team_file_glob:
-  - config/teams/**/*.yml
-skip_untracked_files: false
+  - config/teams/**/*.yml

tests/fixtures/multiple-directory-owners/config/code_ownership.yml

@@ -8,4 +8,3 @@ team_file_glob:
   - config/teams/**/*.yml
 unbuilt_gems_path: gems
 unowned_globs:
-skip_untracked_files: false

tests/fixtures/valid_project/config/code_ownership.yml

@@ -21,12 +21,8 @@ fn test_skip_untracked_files() -> Result<(), Box<dyn Error>> {
         .assert()
         .failure();
 
-    // Add skip_untracked_false: false to project_root/config/code_ownership.yml
-    let config_path = project_root.join("config/code_ownership.yml");
-    let original = fs::read_to_string(&config_path)?;
-    // Change payroll.rb ownership from @PayrollTeam to @PaymentsTeam to induce a mismatch
-    let modified = original.replace("skip_untracked_files: false", "skip_untracked_files: true");
-    fs::write(&config_path, modified)?;
+    let skip_untracked_files_config_path = project_root.join(".codeowners-skip-untracked-files");
+    fs::write(&skip_untracked_files_config_path, "true")?;
 
     // should succeed if skip_untracked_false is false
     Command::cargo_bin("codeowners")?