Use noop cache when disabled (#47)

* use noop cache when disabled

* updating run_benchmark.sh comment

Author: perryqh

dev/run_benchmarks.sh

@@ -5,7 +5,7 @@ if [ -f "tmp/codeowners_benchmarks.md" ]; then
   rm tmp/codeowners_benchmarks.md
 fi
 
-echo "To run these benchmarks on your application, you can place this repo next to your rails application and run bash ../rubyatscale/codeowners-rs/dev/run_benchmarks.sh from the root of your application" >> tmp/codeowners_benchmarks.md
+echo "To run these benchmarks on your application, you can place this repo next to your rails application and run /usr/bin/env bash ../rubyatscale/codeowners-rs/dev/run_benchmarks.sh from the root of your application" >> tmp/codeowners_benchmarks.md
 
 hyperfine --warmup=2 --runs=3 --export-markdown tmp/codeowners_benchmarks.md \
   '../rubyatscale/codeowners-rs/target/release/codeowners gv' \

src/cli.rs

@@ -109,7 +109,7 @@ pub fn cli() -> Result<(), Error> {
             .into()
     };
 
-    let mut project_builder = ProjectBuilder::new(&config, project_root.clone(), codeowners_file_path.clone(), !args.no_cache, &cache);
+    let mut project_builder = ProjectBuilder::new(&config, project_root.clone(), codeowners_file_path.clone(), &cache);
     let project = project_builder.build().change_context(Error::Io)?;
     let ownership = Ownership::build(project);
 

src/common_test.rs

@@ -116,26 +116,14 @@ pub mod tests {
 
         let codeowners_file_path = &test_config.temp_dir_path.join(".github/CODEOWNERS");
         let cache: Cache = NoopCache::default().into();
-        let mut builder = ProjectBuilder::new(
-            &config,
-            test_config.temp_dir_path.clone(),
-            codeowners_file_path.clone(),
-            false,
-            &cache,
-        );
+        let mut builder = ProjectBuilder::new(&config, test_config.temp_dir_path.clone(), codeowners_file_path.clone(), &cache);
         let project = builder.build()?;
         let ownership = Ownership::build(project);
         if test_config.generate_codeowners {
             std::fs::write(codeowners_file_path, ownership.generate_file())?;
         }
         // rebuild project to ensure new codeowners file is read
-        let mut builder = ProjectBuilder::new(
-            &config,
-            test_config.temp_dir_path.clone(),
-            codeowners_file_path.clone(),
-            false,
-            &cache,
-        );
+        let mut builder = ProjectBuilder::new(&config, test_config.temp_dir_path.clone(), codeowners_file_path.clone(), &cache);
         let project = builder.build()?;
         Ok(Ownership::build(project))
     }

src/project_builder.rs

@@ -38,8 +38,8 @@ pub struct ProjectBuilder<'a> {
 const INITIAL_VECTOR_CAPACITY: usize = 1000;
 
 impl<'a> ProjectBuilder<'a> {
-    pub fn new(config: &'a Config, base_path: PathBuf, codeowners_file_path: PathBuf, use_cache: bool, cache: &'a Cache) -> Self {
-        let project_file_builder = ProjectFileBuilder::new(use_cache, cache);
+    pub fn new(config: &'a Config, base_path: PathBuf, codeowners_file_path: PathBuf, cache: &'a Cache) -> Self {
+        let project_file_builder = ProjectFileBuilder::new(cache);
         Self {
             project_file_builder,
             config,

src/project_file_builder.rs

@@ -9,7 +9,6 @@ use crate::{
 };
 
 pub struct ProjectFileBuilder<'a> {
-    use_cache: bool,
     global_cache: &'a Cache,
 }
 
@@ -18,15 +17,11 @@ lazy_static! {
 }
 
 impl<'a> ProjectFileBuilder<'a> {
-    pub fn new(use_cache: bool, global_cache: &'a Cache) -> Self {
-        Self { use_cache, global_cache }
+    pub fn new(global_cache: &'a Cache) -> Self {
+        Self { global_cache }
     }
 
     pub(crate) fn build(&mut self, path: PathBuf) -> ProjectFile {
-        if !self.use_cache {
-            return build_project_file_without_cache(&path);
-        }
-
         if let Ok(Some(cached_project_file)) = self.get_project_file_from_cache(&path) {
             return cached_project_file;
         }