Update language update-deprecations => update-todo (#35)

Author: Alex Evanczuk

Gemfile.lock

@@ -17,7 +17,7 @@ GIT
 PATH
   remote: .
   specs:
-    danger-packwerk (0.11.2)
+    danger-packwerk (0.12.0)
       code_ownership
       danger-plugin-api (~> 1.0)
       packwerk

lib/danger-packwerk/check/default_formatter.rb

@@ -38,7 +38,7 @@ def format_offenses(offenses, repo_link, org_name)
         constant_source_package = T.must(ParsePackwerk.all.find { |p| p.name == constant_source_package_name })
         constant_source_package_ownership_info = Private::OwnershipInformation.for_package(constant_source_package, org_name)
 
-        disclaimer = 'Before you run `bin/packwerk update-deprecations`, check out these quick suggestions:'
+        disclaimer = 'Before you run `bin/packwerk update-todo`, check out these quick suggestions:'
         referencing_code_in_right_pack = "- Does the code you are writing live in the right pack?\n  - If not, try `bin/packs move packs/destination_pack #{referencing_file}`"
         referenced_code_in_right_pack = "- Does #{constant_name} live in the right pack?\n  - If not, try `bin/packs move packs/destination_pack #{constant_location}`"
         dependency_violation_message = "- Do we actually want to depend on #{constant_source_package_name}?\n  - If so, try `bin/packs add_dependency #{referencing_file_pack} #{constant_source_package_name}`\n  - If not, what can we change about the design so we do not have to depend on #{constant_source_package_name}?"

lib/danger-packwerk/update/default_formatter.rb

@@ -28,7 +28,7 @@ def format_offenses(offenses, repo_link, org_name)
 
         package_referring_to_constant_owner = Private::OwnershipInformation.for_package(referencing_file_pack, org_name)
 
-        disclaimer = 'We noticed you ran `bin/packwerk update-deprecations`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.'
+        disclaimer = 'We noticed you ran `bin/packwerk update-todo`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.'
         pluralized_violation = offenses.count > 1 ? 'these violations' : 'this violation'
         request_to_add_context = "- Could you add some context as a reply here about why we needed to add #{pluralized_violation}?\n"
 

lib/danger-packwerk/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module DangerPackwerk
-  VERSION = '0.11.2'
+  VERSION = '0.12.0'
 end

spec/danger_packwerk/danger_package_todo_yml_changes_spec.rb

@@ -127,7 +127,7 @@ module DangerPackwerk
                     - packs/some_pack/some_class.rb
                 ==================== DANGER_START
                 Hi again! It looks like `OtherPackClass` is private API of `packs/some_other_pack`, which is also not in `packs/some_pack`'s list of dependencies.
-                We noticed you ran `bin/packwerk update-deprecations`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
+                We noticed you ran `bin/packwerk update-todo`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
 
                 - Could you add some context as a reply here about why we needed to add these violations?
 
@@ -327,7 +327,7 @@ def format_offenses(added_violations, repo_link, org_name)
                   - packs/some_pack/some_class.rb
               ==================== DANGER_START
               Hi again! It looks like `OtherPackClass2` is private API of `packs/some_other_pack`, which is also not in `packs/some_pack`'s list of dependencies.
-              We noticed you ran `bin/packwerk update-deprecations`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
+              We noticed you ran `bin/packwerk update-todo`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
 
               - Could you add some context as a reply here about why we needed to add these violations?
 
@@ -389,7 +389,7 @@ def format_offenses(added_violations, repo_link, org_name)
                   - packs/some_pack/some_other_class.rb
               ==================== DANGER_START
               Hi again! It looks like `OtherPackClass` is private API of `packs/some_other_pack`.
-              We noticed you ran `bin/packwerk update-deprecations`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
+              We noticed you ran `bin/packwerk update-todo`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
 
               - Could you add some context as a reply here about why we needed to add this violation?
 
@@ -469,7 +469,7 @@ def format_offenses(added_violations, repo_link, org_name)
                   - packs/some_pack/some_other_class.rb
               ==================== DANGER_START
               Hi again! It looks like `XYZModule` is private API of `packs/some_other_pack`.
-              We noticed you ran `bin/packwerk update-deprecations`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
+              We noticed you ran `bin/packwerk update-todo`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
 
               - Could you add some context as a reply here about why we needed to add this violation?
 
@@ -549,7 +549,7 @@ def format_offenses(added_violations, repo_link, org_name)
                   - packs/some_pack/some_other_class.rb
               ==================== DANGER_START
               Hi again! It looks like `Helpers` is private API of `packs/some_other_pack`.
-              We noticed you ran `bin/packwerk update-deprecations`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
+              We noticed you ran `bin/packwerk update-todo`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
 
               - Could you add some context as a reply here about why we needed to add this violation?
 
@@ -629,7 +629,7 @@ def format_offenses(added_violations, repo_link, org_name)
                   - packs/some_pack/some_class.rb
               ==================== DANGER_START
               Hi again! It looks like `OtherPackClass` belongs to `packs/some_other_pack`, which is not in `packs/some_pack`'s list of dependencies.
-              We noticed you ran `bin/packwerk update-deprecations`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
+              We noticed you ran `bin/packwerk update-todo`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
 
               - Could you add some context as a reply here about why we needed to add this violation?
 
@@ -739,7 +739,7 @@ def format_offenses(added_violations, repo_link, org_name)
                   - packs/some_pack/some_class1.rb
               ==================== DANGER_START
               Hi again! It looks like `OtherPackClass` belongs to `packs/some_other_pack`, which is not in `packs/some_pack`'s list of dependencies.
-              We noticed you ran `bin/packwerk update-deprecations`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
+              We noticed you ran `bin/packwerk update-todo`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
 
               - Could you add some context as a reply here about why we needed to add these violations?
 
@@ -815,7 +815,7 @@ def format_offenses(added_violations, repo_link, org_name)
                   - packs/some_pack/some_class2.rb
               ==================== DANGER_START
               Hi again! It looks like `OtherPackClass` is private API of `packs/some_other_pack`.
-              We noticed you ran `bin/packwerk update-deprecations`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
+              We noticed you ran `bin/packwerk update-todo`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
 
               - Could you add some context as a reply here about why we needed to add this violation?
 
@@ -920,7 +920,7 @@ def format_offenses(added_violations, repo_link, org_name)
                   - packs/some_pack/some_entirely_new_class.rb
               ==================== DANGER_START
               Hi again! It looks like `OtherPackClass` is private API of `packs/some_other_pack`.
-              We noticed you ran `bin/packwerk update-deprecations`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
+              We noticed you ran `bin/packwerk update-todo`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
 
               - Could you add some context as a reply here about why we needed to add this violation?
 
@@ -1033,7 +1033,7 @@ def format_offenses(added_violations, repo_link, org_name)
                   - packs/some_pack/some_file.rb
               ==================== DANGER_START
               Hi again! It looks like `SomeNewClass` is private API of `packs/some_other_pack`.
-              We noticed you ran `bin/packwerk update-deprecations`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
+              We noticed you ran `bin/packwerk update-todo`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.
 
               - Could you add some context as a reply here about why we needed to add this violation?
 

spec/danger_packwerk/danger_packwerk_spec.rb

@@ -818,7 +818,7 @@ def format_offenses(offenses, repo_link, org_name)
 
               <details><summary>Quick suggestions :bulb:</summary>
 
-              Before you run `bin/packwerk update-deprecations`, check out these quick suggestions:
+              Before you run `bin/packwerk update-todo`, check out these quick suggestions:
               - Does the code you are writing live in the right pack?
                 - If not, try `bin/packs move packs/destination_pack packs/referencing_package/some_file.rb`
               - Does PrivateConstant live in the right pack?
@@ -859,7 +859,7 @@ def format_offenses(offenses, repo_link, org_name)
 
                 <details><summary>Quick suggestions :bulb:</summary>
 
-                Before you run `bin/packwerk update-deprecations`, check out these quick suggestions:
+                Before you run `bin/packwerk update-todo`, check out these quick suggestions:
                 - Does the code you are writing live in the right pack?
                   - If not, try `bin/packs move packs/destination_pack packs/referencing_package/some_file.rb`
                 - Does PrivateConstant live in the right pack?
@@ -902,7 +902,7 @@ def format_offenses(offenses, repo_link, org_name)
 
               <details><summary>Quick suggestions :bulb:</summary>
 
-              Before you run `bin/packwerk update-deprecations`, check out these quick suggestions:
+              Before you run `bin/packwerk update-todo`, check out these quick suggestions:
               - Does the code you are writing live in the right pack?
                 - If not, try `bin/packs move packs/destination_pack packs/referencing_package/some_file.rb`
               - Does PrivateConstant live in the right pack?
@@ -943,7 +943,7 @@ def format_offenses(offenses, repo_link, org_name)
 
               <details><summary>Quick suggestions :bulb:</summary>
 
-              Before you run `bin/packwerk update-deprecations`, check out these quick suggestions:
+              Before you run `bin/packwerk update-todo`, check out these quick suggestions:
               - Does the code you are writing live in the right pack?
                 - If not, try `bin/packs move packs/destination_pack packs/referencing_package/some_file.rb`
               - Does PrivateConstant live in the right pack?
@@ -1016,7 +1016,7 @@ def format_offenses(offenses, repo_link, org_name)
 
                 <details><summary>Quick suggestions :bulb:</summary>
 
-                Before you run `bin/packwerk update-deprecations`, check out these quick suggestions:
+                Before you run `bin/packwerk update-todo`, check out these quick suggestions:
                 - Does the code you are writing live in the right pack?
                   - If not, try `bin/packs move packs/destination_pack packs/referencing_package/some_file.rb`
                 - Does PrivateConstant live in the right pack?