Update bundler, update rubocop, get CI passing again (#55)

* bundle update --bundler

* bundle lock --normalize-platforms

* bundle binstubs sorbet

* bundle binstubs rspec-core

* Rubocop exclude binstubs

* Clean up development dependencies

Also adds rubocop-performance which is getting loaded in CI somehow.

* Update rubocop and run rubocop -A

Also include rspec rubocop fixes, but I removed the rubocop-rspec
gem to avoid having to do a lot of manual fixes.

* Remove rubocop.yml inherit_gem directive. When blank it does weird things

* Exclude vendor so we don't pick up gems and try to rubocop them

* Add the ruby platform back to the bundle

* Pull in shared_config to see if we can get it working

---------

Co-authored-by: Ivy Evans <[email protected]>

Author: martinemde

.github/workflows/ci.yml

@@ -7,6 +7,61 @@ on:
   pull_request:
 
 jobs:
-  call-workflow-from-shared-config:
-    uses: rubyatscale/shared-config/.github/workflows/ci.yml@main
-    secrets: inherit
+  run_tests:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby:
+          - 3.2
+          - 3.3
+          - 3.4
+    env:
+      BUNDLE_GEMFILE: Gemfile
+    name: "Run tests: Ruby ${{ matrix.ruby }}"
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Ruby ${{ matrix.ruby }}
+        uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: true
+          ruby-version: ${{ matrix.ruby }}
+      - name: Run tests
+        run: bundle exec rspec
+  static_type_check:
+    name: "Type Check"
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: true
+          ruby-version: 3.3
+      - name: Run static type checks
+        run: bundle exec srb tc
+  run_linter:
+    runs-on: ubuntu-latest
+    name: "Linter"
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: true
+          ruby-version: 3.3
+      - name: Run linter
+        run: bundle exec rubocop
+  notify_on_failure:
+    runs-on: ubuntu-latest
+    needs: [run_tests, static_type_check, run_linter]
+    if: ${{ failure() && github.ref == 'refs/heads/main' }}
+    env:
+      SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
+      SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
+    steps:
+      - uses: slackapi/[email protected]
+        with:
+          payload: |
+            {
+              "text": "${{ github.repository }}/${{ github.ref }}: FAILED\n${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
+            }

.rubocop.yml

@@ -1,10 +1,13 @@
-inherit_gem:
-require:
+plugins:
   - rubocop-sorbet
+  - rubocop-performance
 
 AllCops:
   TargetRubyVersion: 2.6
   NewCops: enable
+  Exclude:
+    - bin/**/*
+    - vendor/**/*
 
 Sorbet/StrictSigil:
   Enabled: true

Gemfile

@@ -5,5 +5,16 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in danger-packwerk.gemspec
 gemspec
 
+# Override the version of packwerk that is installed by the gemspec
 gem 'packwerk', github: 'Shopify/packwerk', branch: 'main'
+
+# Development dependencies
+gem 'pry'
 gem 'railties'
+gem 'rake'
+gem 'rspec', '~> 3.0'
+gem 'rubocop'
+gem 'rubocop-performance'
+gem 'rubocop-sorbet'
+gem 'sorbet'
+gem 'tapioca'