create a directory rather than a public/TODO.md file

Author: ashleywillard

lib/packs/private.rb

@@ -446,8 +446,8 @@ def self.add_public_directory(package)
 
       if public_directory.glob('**/**.rb').none?
         FileUtils.mkdir_p(public_directory)
-        todo_md = Packs.config.user_event_logger.on_create_public_directory_todo(package.name)
-        public_directory.join('TODO.md').write(todo_md)
+        package_name = package.directory.basename.to_s
+        FileUtils.mkdir_p(public_directory.join(package_name))
       end
     end
 

lib/packs/user_event_logger.rb

@@ -123,29 +123,6 @@ def after_move_to_folder(pack_name)
       MSG
     end
 
-    sig { params(pack_name: String).returns(String) }
-    def on_create_public_directory_todo(pack_name)
-      <<~MSG
-        This directory holds your public API!
-
-        Any classes, constants, or modules that you want other packs to use and you intend to support should go in here.
-        Anything that is considered private should go in other folders.
-
-        If another pack uses classes, constants, or modules that are not in your public folder, it will be considered a "privacy violation" by packwerk.
-        You can prevent other packs from using private API by using packwerk.
-
-        Want to find how your private API is being used today?
-        Try running: `bin/packs list_top_violations privacy #{pack_name}`
-
-        Want to move something into this folder?
-        Try running: `bin/packs make_public #{pack_name}/path/to/file.rb`
-
-        One more thing -- feel free to delete this file and replace it with a README.md describing your package in the main package directory.
-
-        See #{documentation_link} for more info!
-      MSG
-    end
-
     sig { params(pack_name: String).returns(String) }
     def on_create_readme(pack_name)
       <<~MSG

spec/packs_spec.rb

@@ -256,21 +256,22 @@ def write_codeownership_config
       end
 
       context 'app has no public dir' do
-        it 'adds a TODO.md file letting someone know what to do with it' do
+        it 'adds a public directory' do
           Packs.create_pack!(pack_name: 'packs/organisms')
-          actual_todo = Pathname.new('packs/organisms/app/public/TODO.md').read
-          expect(actual_todo).to eq expected_todo
+          public_directory = Pathname.new('packs/organisms/app/public')
+          expect(public_directory.exist?).to eq true
+          expect(public_directory.join('organisms').exist?).to eq true
         end
 
         context 'pack not enforcing privacy' do
-          it 'does not add a TODO.md file' do
+          it 'does not add a public directory' do
             Packs.create_pack!(pack_name: 'packs/organisms', enforce_privacy: false)
 
             ParsePackwerk.bust_cache!
             package = ParsePackwerk.find('packs/organisms')
             expect(package.enforce_privacy).to eq(false)
-            todo_file = Pathname.new('packs/organisms/app/public/TODO.md')
-            expect(todo_file.exist?).to eq false
+            public_directory = Pathname.new('packs/organisms/app/public')
+            expect(public_directory.exist?).to eq false
           end
         end
       end
@@ -789,16 +790,15 @@ def write_codeownership_config
       end
 
       context 'app has no public dir' do
-        it 'adds a TODO.md file letting someone know what to do with it' do
+        it 'adds a public directory' do
           write_file('app/services/foo.rb')
           write_package_yml('packs/organisms')
           Packs.move_to_pack!(
             pack_name: 'packs/organisms',
             paths_relative_to_root: ['app/services/foo.rb']
           )
 
-          actual_todo = Pathname.new('packs/organisms/app/public/TODO.md').read
-          expect(actual_todo).to eq expected_todo
+          expect(Pathname.new('packs/organisms/app/public/organisms').exist?).to eq true
         end
 
         context 'pack not enforcing privacy' do