11use assert_cmd:: prelude:: * ;
2+ use packs:: packs:: walk_directory:: build_gitignore_matcher;
23use predicates:: prelude:: * ;
34use serial_test:: serial;
5+ use std:: path:: PathBuf ;
46use std:: { error:: Error , process:: Command } ;
57
68mod common;
@@ -13,8 +15,6 @@ fn test_check_ignores_violations_in_gitignored_files(
1315 // The fixture has:
1416 // - packs/foo/app/services/foo.rb with violation (NOT ignored)
1517 // - ignored_folder/violating.rb with violation (IS ignored)
16- //
17- // Phase 2 ensures only violations in non-ignored files are detected.
1818
1919 let result = Command :: cargo_bin ( "pks" ) ?
2020 . arg ( "--project-root" )
@@ -51,8 +51,6 @@ fn test_check_ignores_violations_in_gitignored_files(
5151#[ test]
5252fn test_list_included_files_excludes_gitignored ( ) -> Result < ( ) , Box < dyn Error > >
5353{
54- // NOTE: This test will fail until Phase 2 is implemented
55-
5654 let output = Command :: cargo_bin ( "pks" ) ?
5755 . arg ( "--project-root" )
5856 . arg ( "tests/fixtures/app_with_gitignore" )
@@ -116,9 +114,6 @@ fn test_check_works_without_gitignore() -> Result<(), Box<dyn Error>> {
116114/// This is a sanity check that our helper functions work correctly.
117115#[ test]
118116fn test_gitignore_matcher_functions ( ) -> Result < ( ) , Box < dyn Error > > {
119- use packs:: packs:: walk_directory:: build_gitignore_matcher;
120- use std:: path:: PathBuf ;
121-
122117 let absolute_path = PathBuf :: from ( "tests/fixtures/app_with_gitignore" )
123118 . canonicalize ( )
124119 . expect ( "Could not canonicalize path" ) ;
@@ -188,7 +183,6 @@ fn test_gitignore_matcher_without_gitignore() -> Result<(), Box<dyn Error>> {
188183}
189184
190185/// CRITICAL: Test that respect_gitignore: false configuration disables gitignore support.
191- /// This is the primary configuration option added in Phase 2.
192186#[ test]
193187fn test_respect_gitignore_can_be_disabled ( ) -> Result < ( ) , Box < dyn Error > > {
194188 // The fixture has:
0 commit comments