Skip to content

Commit 3183ae2

Browse files
committed
Fix github actions to pass, run linting
1 parent 3aa1208 commit 3183ae2

File tree

2 files changed

+19
-6
lines changed

2 files changed

+19
-6
lines changed

.github/workflows/main.yml

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@ on:
88
pull_request:
99

1010
jobs:
11-
rspec:
12-
name: Ruby ${{ matrix.ruby }}
11+
tests:
12+
name: Tests Ruby ${{ matrix.ruby }}
1313
runs-on: ubuntu-latest
1414
strategy:
15+
fail-fast: false
1516
matrix:
1617
ruby:
1718
- '3.3'
1819
- '3.4'
19-
- 'head'
2020

2121
steps:
2222
- uses: actions/checkout@v4
@@ -28,7 +28,7 @@ jobs:
2828
- name: Run tests
2929
run: bundle exec rspec
3030

31-
static_type_check:
31+
type_check:
3232
name: "Type Check"
3333
runs-on: ubuntu-latest
3434
steps:
@@ -37,6 +37,19 @@ jobs:
3737
uses: ruby/setup-ruby@v1
3838
with:
3939
bundler-cache: true
40-
ruby-version: head
40+
ruby-version: '3.4'
4141
- name: Run static type checks
4242
run: bundle exec srb tc
43+
44+
lint:
45+
name: "Lint"
46+
runs-on: ubuntu-latest
47+
steps:
48+
- uses: actions/checkout@v4
49+
- name: Set up Ruby
50+
uses: ruby/setup-ruby@v1
51+
with:
52+
bundler-cache: true
53+
ruby-version: '3.4'
54+
- name: Run static type checks
55+
run: bundle exec rubocop

sorbet/rbi/todo.rbi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
module ::DateAndTime::Calculations; end
88
module ::DateAndTime::Zones; end
9-
module ActionView::ActionViewError; end
9+
class ActionView::ActionViewError < StandardError; end
1010
module ActionView::Helpers::SanitizeHelper::ClassMethods; end
1111
module ActionView::Helpers::TagHelper; end
1212
module ActionView::Helpers::UrlHelper::ClassMethods; end

0 commit comments

Comments
 (0)