Skip to content

Commit 91eb89f

Browse files
committed
Remove Node#obscured? parameters
Although `Capybara::Selenium::Node#obscured?` accepts `x` and `y` arguments, these parameters do not appear to part of the public Capybara API.
1 parent da3a8ae commit 91eb89f

File tree

3 files changed

+7
-16
lines changed

3 files changed

+7
-16
lines changed

lib/capybara/cuprite/browser.rb

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -210,12 +210,8 @@ def path(node)
210210
evaluate_on(node: node, expression: "_cuprite.path(this)")
211211
end
212212

213-
def obscured?(node, x = nil, y = nil)
214-
if x && y
215-
evaluate_on(node: node, expression: "_cuprite.isObscured(this, #{x}, #{y})")
216-
else
217-
evaluate_on(node: node, expression: "_cuprite.isObscured(this)")
218-
end
213+
def obscured?(node)
214+
evaluate_on(node: node, expression: "_cuprite.isObscured(this)")
219215
end
220216

221217
def all_text(node)

lib/capybara/cuprite/javascripts/index.js

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -119,18 +119,13 @@ class Cuprite {
119119
* Returns true if the node is obscured in the viewport.
120120
*
121121
* @param {Element} node
122-
* @param {number} [x] the center position
123-
* @param {number} [y] the center position
124122
* @return {boolean} true if the node is obscured, false otherwise
125123
*/
126-
isObscured(node, x, y) {
124+
isObscured(node) {
127125
let win = window;
128126
let rect = node.getBoundingClientRect();
129-
x = x ?? rect.width / 2;
130-
y = y ?? rect.height / 2;
131-
132-
let px = rect.left + x;
133-
let py = rect.top + y;
127+
let px = rect.left + rect.width / 2;
128+
let py = rect.top + rect.height / 2;
134129

135130
while (win) {
136131
let topNode = win.document.elementFromPoint(px, py);

lib/capybara/cuprite/node.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,8 +213,8 @@ def path
213213
command(:path)
214214
end
215215

216-
def obscured?(x: nil, y: nil)
217-
command(:obscured?, x, y)
216+
def obscured?
217+
command(:obscured?)
218218
end
219219

220220
def inspect

0 commit comments

Comments
 (0)