fix: linter (#345)

Author: route

lib/ferrum/network.rb

@@ -333,7 +333,8 @@ def emulate_network_conditions(offline: false, latency: 0,
     #
     # @example
     #   browser.network.offline_mode
-    #   browser.go_to("https://github.com/") # => Ferrum::StatusError (Request to https://github.com/ failed (net::ERR_INTERNET_DISCONNECTED))
+    #   browser.go_to("https://github.com/")
+    #     # => Request to https://github.com/ failed (net::ERR_INTERNET_DISCONNECTED) (Ferrum::StatusError)
     #
     def offline_mode
       emulate_network_conditions(offline: true, latency: 0, download_throughput: 0, upload_throughput: 0)

lib/ferrum/node.rb

@@ -228,7 +228,7 @@ def bounding_rect_coordinates
 
     def content_quads
       quads = page.command("DOM.getContentQuads", nodeId: node_id)["quads"]
-      raise CoordinatesNotFoundError, "Node is either not visible or not an HTMLElement" if quads.size.zero?
+      raise CoordinatesNotFoundError, "Node is either not visible or not an HTMLElement" if quads.empty?
 
       quads
     end

lib/ferrum/page.rb

@@ -114,7 +114,8 @@ def go_to(url = nil)
       options = { url: combine_url!(url) }
       options.merge!(referrer: referrer) if referrer
       response = command("Page.navigate", wait: GOTO_WAIT, **options)
-      raise StatusError.new(options[:url], "Request to #{options[:url]} failed (#{response['errorText']})") if response['errorText']
+      error_text = response["errorText"]
+      raise StatusError.new(options[:url], "Request to #{options[:url]} failed (#{error_text})") if error_text
 
       response["frameId"]
     rescue TimeoutError

spec/browser/xvfb_spec.rb

@@ -57,7 +57,7 @@
   def process_alive?(pid)
     return false unless pid
 
-    ::Process.kill(0, pid) == 1
+    Process.kill(0, pid) == 1
   rescue Errno::ESRCH
     false
   end

spec/unit/process_spec.rb

@@ -5,16 +5,16 @@
 
   unless Ferrum::Utils::Platform.windows?
     it "forcibly kills the child if it does not respond to SIGTERM" do
-      allow(::Process).to receive(:spawn).and_return(5678)
-      allow(::Process).to receive(:wait).and_return(nil)
+      allow(Process).to receive(:spawn).and_return(5678)
+      allow(Process).to receive(:wait).and_return(nil)
       allow(Ferrum::Browser::Client).to receive(:new).and_return(double.as_null_object)
 
       allow_any_instance_of(Ferrum::Browser::Process).to receive(:parse_ws_url)
 
       subject.send(:start)
 
-      expect(::Process).to receive(:kill).with("USR1", 5678).ordered
-      expect(::Process).to receive(:kill).with("KILL", 5678).ordered
+      expect(Process).to receive(:kill).with("USR1", 5678).ordered
+      expect(Process).to receive(:kill).with("KILL", 5678).ordered
 
       subject.quit
     end
@@ -24,10 +24,10 @@
     subject { Ferrum::Browser.new(env: { "LD_PRELOAD" => "some.so" }) }
 
     it "passes through env" do
-      allow(::Process).to receive(:wait).and_return(nil)
+      allow(Process).to receive(:wait).and_return(nil)
       allow(Ferrum::Browser::Client).to receive(:new).and_return(double.as_null_object)
 
-      allow(::Process).to receive(:spawn).with({ "LD_PRELOAD" => "some.so" }, any_args).and_return(123_456_789)
+      allow(Process).to receive(:spawn).with({ "LD_PRELOAD" => "some.so" }, any_args).and_return(123_456_789)
 
       allow_any_instance_of(Ferrum::Browser::Process).to receive(:parse_ws_url)