Add RBS types (#565)

Author: route

.github/workflows/linter.yml

@@ -11,7 +11,7 @@ jobs:
      strategy:
        fail-fast: false
        matrix:
-         ruby: [ "2.7", "3.0" ]
+         ruby: ["3.1", "4.0"]
      runs-on: ubuntu-latest
      steps:
        - name: Checkout code

.github/workflows/tests.yml

@@ -11,7 +11,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ["2.7", "3.0", "3.1", "3.2", "3.3", "3.4"]
+        ruby: ["3.1", "3.2", "3.3", "3.4", "4.0"]
     runs-on: ubuntu-latest
     env:
       FERRUM_PROCESS_TIMEOUT: 25

.gitignore

@@ -7,3 +7,4 @@ tmp
 .ruby-version
 .yardoc
 .tool-versions
+.gem_rbs_collection

.rubocop.yml

@@ -1,5 +1,5 @@
 AllCops:
-  TargetRubyVersion: 2.7
+  TargetRubyVersion: 3.1
   NewCops: enable
   SuggestExtensions: false
 

CHANGELOG.md

@@ -3,11 +3,13 @@
 ### Added
 - `Ferrum::Network::Response#body!` returns body or throws error if implicable
 - `Ferrum::Browser#new(dockerize: true)` whether to add CLI flags to run a browser in a container, `false` by default
+- Initial support for RBS types [#565]
 
 ### Changed
 - `Ferrum::Network::Response#body` returns body or nil in case of errors
 - Disable Chrome code sign clones [#555]
 - `Ferrum::Browser` option `:pending_connection_errors` is set to false by default
+- Ruby version required is >= 3.1 [#565]
 
 ### Fixed
 - Proper handle wss urls, and fix session_id loss for undetermined order of CDP events [#559]

Gemfile

@@ -2,13 +2,15 @@
 
 source "https://rubygems.org"
 
-gem "byebug", "~> 11.0", platforms: %i[mri mingw x64_mingw]
+gem "byebug", "~> 11.0", platforms: %i[mri windows]
 gem "chunky_png", "~> 1.3"
 gem "image_size", "~> 2.0"
 gem "kramdown", "~> 2.0", require: false
+gem "ostruct"
 gem "pdf-reader", "~> 2.12"
 gem "puma", ">= 5.6.7"
 gem "rake", "~> 13.0"
+gem "rbs", "~> 3.10"
 gem "redcarpet", require: false, platform: :mri
 gem "rspec", "~> 3.8"
 gem "rspec-wait"

ferrum.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |s|
     "rubygems_mfa_required" => "true"
   }
 
-  s.required_ruby_version = ">= 2.7.0"
+  s.required_ruby_version = ">= 3.1"
 
   s.add_dependency "addressable",      "~> 2.5"
   s.add_dependency "base64",           "~> 0.2"

lib/ferrum/browser/options/base.rb

@@ -26,11 +26,11 @@ def to_h
         end
 
         def except(*keys)
-          to_h.reject { |n, _| keys.include?(n) }
+          to_h.except(*keys)
         end
 
         def detect_path
-          Binary.find(self.class::PLATFORM_PATH[Utils::Platform.name])
+          Binary.find(self.class::PLATFORM_PATH[Utils::Platform.platform_name])
         end
 
         def merge_required(flags, options, user_data_dir)

lib/ferrum/client.rb

@@ -24,8 +24,8 @@ def command(method, async: false, **params)
       @client.send_message(message, async: async)
     end
 
-    def on(event, &block)
-      @client.on(event_name(event), &block)
+    def on(event, &)
+      @client.on(event_name(event), &)
     end
 
     def off(event, id)
@@ -40,8 +40,8 @@ def respond_to_missing?(name, include_private)
       @client.respond_to?(name, include_private)
     end
 
-    def method_missing(name, *args, **opts, &block)
-      @client.send(name, *args, **opts, &block)
+    def method_missing(name, ...)
+      @client.send(name, ...)
     end
 
     def close
@@ -102,8 +102,8 @@ def send_message(message, async:)
       end
     end
 
-    def on(event, &block)
-      @subscriber.on(event, &block)
+    def on(event, &)
+      @subscriber.on(event, &)
     end
 
     def off(event, id)

lib/ferrum/contexts.rb

@@ -22,10 +22,10 @@ def default_context
       @default_context ||= create
     end
 
-    def each(&block)
+    def each(&)
       return enum_for(__method__) unless block_given?
 
-      @contexts.each(&block)
+      @contexts.each(&)
     end
 
     def [](id)