Merge pull request #139 from Mifrill/fullscreen-viewport-broken-test

route · web-flow · commit 142f10c6114e · 2021-01-20T17:13:11.000+03:00
Fix test: resize viewport by fullscreen
diff --git a/spec/browser_spec.rb b/spec/browser_spec.rb
@@ -87,11 +87,25 @@ module Ferrum
       expect(browser.viewport_size).to eq([200, 400])
     end
 
-    it "allows the viewport to be resized by fullscreen" do
-      browser.go_to("/ferrum/custom_html_size")
-      expect(browser.viewport_size).to eq([1024, 768])
-      browser.resize(fullscreen: true)
-      expect(browser.viewport_size).to eq([1280, 1024])
+    context 'fullscreen' do
+      shared_examples 'resize viewport by fullscreen' do
+        it "allows the viewport to be resized by fullscreen" do
+          expect(browser.viewport_size).to eq([1024, 768])
+          browser.go_to(path)
+          browser.resize(fullscreen: true)
+          expect(browser.viewport_size).to eq(viewport_size)
+        end
+      end
+
+      include_examples 'resize viewport by fullscreen' do
+        let(:path) { "/ferrum/custom_html_size" }
+        let(:viewport_size) { [1280, 1024] }
+      end
+
+      include_examples 'resize viewport by fullscreen' do
+        let(:path) { "/ferrum/custom_html_size_100%" }
+        let(:viewport_size) { [1272, 1008] }
+      end
     end
 
     it "allows the page to be scrolled" do
diff --git a/spec/support/views/custom_html_size.erb b/spec/support/views/custom_html_size.erb
@@ -3,17 +3,11 @@
     <title>custom_size</title>
     <style>
       html {
-        width: 100%;
-        height: 100%;
-      }
-
-      .spacer {
-        width:  1272px; /* using scrollWidth  adds 8px */
-        height: 1008px; /* using scrollHeight adds 16px */
+        width: 1280px;
+        height: 1024px;
       }
     </style>
   </head>
   <body>
-    <div class="spacer"></div>
   </body>
 </html>
diff --git a/spec/support/views/custom_html_size_100%.erb b/spec/support/views/custom_html_size_100%.erb
@@ -0,0 +1,27 @@
+<html>
+  <head>
+    <title>custom_size</title>
+    <style>
+      html {
+        width: 100%;
+        height: 100%;
+      }
+
+      body {
+        /*
+          deal with the default Chrome margins
+          https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/html/resources/html.css;
+        */
+        margin: 0;
+      }
+
+      .spacer {
+        width:  1272px;
+        height: 1008px;
+      }
+    </style>
+  </head>
+  <body>
+    <div class="spacer"></div>
+  </body>
+</html>
