fix: flaky test

Author: route

Gemfile

@@ -11,6 +11,7 @@ gem "puma", ">= 5.6.7"
 gem "rake", "~> 13.0"
 gem "redcarpet", require: false, platform: :mri
 gem "rspec", "~> 3.8"
+gem "rspec-wait", "~> 1.0"
 gem "rubocop", "~> 1.22"
 gem "rubocop-rake", require: false
 gem "sinatra", "~> 3.2"

spec/page_spec.rb

@@ -216,7 +216,7 @@
       message_a = nil
       message_b = nil
 
-      a = page.on("Runtime.consoleAPICalled") do |params|
+      handler = page.on("Runtime.consoleAPICalled") do |params|
         message_a = params.dig("args", 0, "value")
       end
 
@@ -225,14 +225,14 @@
       end
 
       page.evaluate("console.log('hello')")
-      expect(message_a).to eq("hello")
-      expect(message_b).to eq("hello")
+      wait_for { message_a }.to eq("hello")
+      wait_for { message_b }.to eq("hello")
 
-      page.off("Runtime.consoleAPICalled", a)
+      page.off("Runtime.consoleAPICalled", handler)
       page.evaluate("console.log('goodbye')")
 
       expect(message_a).to eq("hello")
-      expect(message_b).to eq("goodbye")
+      wait_for { message_b }.to eq("goodbye")
     end
   end
 end

spec/spec_helper.rb

@@ -2,6 +2,7 @@
 
 require "bundler/setup"
 require "rspec"
+require "rspec/wait"
 require "pathname"
 
 PROJECT_ROOT = File.expand_path("..", __dir__)
@@ -23,6 +24,10 @@
 puts ""
 
 RSpec.configure do |config|
+  config.wait_timeout = 1
+  config.wait_delay = 0.2
+  config.clone_wait_matcher = true
+
   ferrum_logger = nil
   config.include_context "Global helpers"