Skip to content

Commit 25712d1

Browse files
committed
Add browserContextId for Browser.setDownloadBehavior
1 parent 6594c82 commit 25712d1

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

lib/ferrum/page.rb

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -263,15 +263,13 @@ def prepare_page
263263

264264
if @browser.options[:save_path]
265265
unless Pathname.new(@browser.options[:save_path]).absolute?
266-
raise Error, "supply absolute path as `:save_path` option"
266+
raise Error, "supply absolute path for `:save_path` option"
267267
end
268268

269269
@browser.command("Browser.setDownloadBehavior",
270+
browserContextId: context.id,
270271
downloadPath: browser.options[:save_path],
271272
behavior: "allow", eventsEnabled: true)
272-
command("Page.setDownloadBehavior",
273-
downloadPath: browser.options[:save_path],
274-
behavior: "allow")
275273
end
276274

277275
@browser.extensions.each do |extension|

spec/download_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ module Ferrum
2929
it "raises an error" do
3030
expect do
3131
browser.go_to("/#{filename}")
32-
end.to raise_error(Ferrum::Error, "supply absolute path as `:save_path` option")
32+
end.to raise_error(Ferrum::Error, "supply absolute path for `:save_path` option")
3333
end
3434
end
3535
end

0 commit comments

Comments
 (0)