Merge pull request #266 from rubycdp/ruby-2.6

Supported Ruby 2.6

Author: route

.github/workflows/tests.yml

@@ -12,7 +12,7 @@ jobs:
       fail-fast: false
       matrix:
         gemfile: [websocket-driver-0.6.x, websocket-driver-0.7.x]
-        ruby: [2.7, 3.0, 3.1]
+        ruby: [2.6, 2.7, 3.0, 3.1]
     runs-on: ubuntu-latest
     env:
       FERRUM_PROCESS_TIMEOUT: 20

.rubocop.yml

@@ -1,5 +1,5 @@
 AllCops:
-  TargetRubyVersion: 2.7
+  TargetRubyVersion: 2.6
   NewCops: enable
 
 Layout/FirstArrayElementIndentation:

CHANGELOG.md

@@ -28,7 +28,7 @@ a block with this page, after which the page is closed.
 ### Changed
 
 - Use `Concurrent::MVar` as `execution_id` in `Ferrum::Frame`
-- Min Ruby version >= 2.7
+- Min Ruby version is 2.6 and 3.0 is supported
 - `Ferrum::Page#bypass_csp` accepts hash as argument `enabled: true` by default
 - `Ferrum::Context#has_target?` -> `Ferrum::Context#target?`
 - We now start looking for Chrome first instead of Chromium, the order for checking binaries has changed

ferrum.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |s|
     "rubygems_mfa_required" => "true"
   }
 
-  s.required_ruby_version = ">= 2.7.0"
+  s.required_ruby_version = ">= 2.6.0"
 
   s.add_runtime_dependency "addressable",      "~> 2.5"
   s.add_runtime_dependency "concurrent-ruby",  "~> 1.1"

lib/ferrum/browser/binary.rb

@@ -27,16 +27,20 @@ def prepare_paths
         [paths, exts]
       end
 
+      # rubocop:disable Style/CollectionCompact
       def lazy_find(cmds)
-        cmds.lazy.filter_map do |cmd, path, ext|
-          cmd = File.expand_path("#{cmd}#{ext}", path) unless File.absolute_path?(cmd)
+        cmds.lazy.map do |cmd, path, ext|
+          absolute_path = File.absolute_path(cmd)
+          is_absolute_path = absolute_path == cmd
+          cmd = File.expand_path("#{cmd}#{ext}", path) unless is_absolute_path
 
           next unless File.executable?(cmd)
           next if File.directory?(cmd)
 
           cmd
-        end
+        end.reject(&:nil?) # .compact isn't defined on Enumerator::Lazy
       end
+      # rubocop:enable Style/CollectionCompact
     end
   end
 end

spec/browser/binary_spec.rb

@@ -45,6 +45,10 @@ class Browser
           expect(Binary.find(%w[bin4])).to eq(bin4_exe)
         end
 
+        it "finds binary with absolute path" do
+          expect(Binary.find(bin4_exe)).to eq(bin4_exe)
+        end
+
         it "finds binary without ext" do
           ENV["PATHEXT"] = ".com;.exe"