Merge pull request #92 from odlp/timeout-error-output

Include process output in ProcessTimeoutError

Author: route

lib/ferrum.rb

@@ -37,7 +37,10 @@ def message
   end
 
   class ProcessTimeoutError < Error
-    def initialize(timeout)
+    attr_reader :output
+
+    def initialize(timeout, output)
+      @output = output
       super("Browser did not produce websocket url within #{timeout} seconds")
     end
   end

lib/ferrum/browser/process.rb

@@ -145,7 +145,7 @@ def parse_ws_url(read_io, timeout)
 
         unless ws_url
           @logger.puts(output) if @logger
-          raise ProcessTimeoutError.new(timeout)
+          raise ProcessTimeoutError.new(timeout, output)
         end
       end
 

spec/browser_spec.rb

@@ -64,6 +64,16 @@ module Ferrum
       )
     end
 
+    it "includes the process output in the error" do
+      path = "#{PROJECT_ROOT}/spec/support/broken_chrome"
+
+      expect {
+        Browser.new(browser_path: path)
+      }.to raise_error(Ferrum::ProcessTimeoutError) do |ex|
+        expect(ex.output).to include "Broken Chrome error message"
+      end
+    end
+
     it "raises an error and restarts the client if the client dies while executing a command" do
       expect { browser.crash }.to raise_error(Ferrum::DeadBrowserError)
       browser.go_to

spec/support/broken_chrome

@@ -0,0 +1,5 @@
+#!/bin/bash
+
+echo "Broken Chrome error message"
+echo "$0"
+exit 1