Fix authorize method that now accepts block

Author: route

README.md

@@ -346,7 +346,7 @@ browser.screenshot(path: "google.jpg") # => 30902
 # Save to Base64 the whole page not only viewport and reduce quality
 browser.screenshot(full: true, quality: 60) # "iVBORw0KGgoAAAANSUhEUgAABAAAAAMACAYAAAC6uhUNAAAAAXNSR0IArs4c6Q...
 # Save with specific background color
-browser.screenshot(background_color: Ferrum::RGBA.new(0, 0, 0, 0.0)) 
+browser.screenshot(background_color: Ferrum::RGBA.new(0, 0, 0, 0.0))
 ```
 
 #### pdf(\*\*options) : `String` | `Boolean`
@@ -484,22 +484,30 @@ end
 browser.go_to("https://google.com")
 ```
 
-#### authorize(\*\*options)
+#### authorize(\*\*options, &block)
 
 If site uses authorization you can provide credentials using this method.
 
 * options `Hash`
   * :type `Symbol` `:server` | `:proxy` site or proxy authorization
   * :user `String`
   * :password `String`
+* &block passes authenticated request, which you must subsequently allow or deny, if you don't
+care about unwanted requests call `continue`.
 
 ```ruby
-browser.network.authorize(user: "login", password: "pass")
+browser.network.authorize(user: "login", password: "pass") do |request|
+  request.continue
+end
 browser.go_to("http://example.com/authenticated")
 puts browser.network.status # => 200
 puts browser.body # => Welcome, authenticated client
 ```
 
+You used to call `authorize` method without block, but since it's implemented using request interception there could be
+a collision with another part of your code that also uses request interception, so that authorize allows the request
+while your code denies but it's too late. The block is mandatory now.
+
 
 ### Mouse
 

lib/ferrum/network.rb

@@ -83,7 +83,7 @@ def intercept(pattern: "*", resource_type: nil)
       @page.command("Fetch.enable", handleAuthRequests: true, patterns: [pattern])
     end
 
-    def authorize(user:, password:, type: :server)
+    def authorize(user:, password:, type: :server, &block)
       unless AUTHORIZE_TYPE.include?(type)
         raise ArgumentError, ":type should be in #{AUTHORIZE_TYPE}"
       end
@@ -93,8 +93,14 @@ def authorize(user:, password:, type: :server)
 
       intercept
 
-      @page.on(:request) do |request|
-        request.continue
+      if block_given?
+        @page.on(:request, &block)
+      else
+        warn "[DEPRECATION] `authorize` without `&block` is deprecated. Please see details https://github.com/rubycdp/ferrum#authorizeoptions"
+
+        @page.on(:request) do |request|
+          request.continue
+        end
       end
 
       @page.on(:auth) do |request, index, total|

spec/network_spec.rb

@@ -209,7 +209,9 @@ module Ferrum
       end
 
       it "allows with given credentials" do
-        browser.network.authorize(user: "login", password: "pass")
+        browser.network.authorize(user: "login", password: "pass") do |request|
+          request.continue
+        end
 
         browser.go_to("/ferrum/basic_auth")
 
@@ -218,7 +220,9 @@ module Ferrum
       end
 
       it "allows even overwriting headers" do
-        browser.network.authorize(user: "login", password: "pass")
+        browser.network.authorize(user: "login", password: "pass") do |request|
+          request.continue
+        end
         browser.headers.set("Cuprite" => "true")
 
         browser.go_to("/ferrum/basic_auth")
@@ -228,7 +232,9 @@ module Ferrum
       end
 
       it "denies with wrong credentials" do
-        browser.network.authorize(user: "user", password: "pass!")
+        browser.network.authorize(user: "user", password: "pass!") do |request|
+          request.continue
+        end
 
         browser.go_to("/ferrum/basic_auth")
 
@@ -237,7 +243,9 @@ module Ferrum
       end
 
       it "allows on POST request" do
-        browser.network.authorize(user: "login", password: "pass")
+        browser.network.authorize(user: "login", password: "pass") do |request|
+          request.continue
+        end
 
         browser.go_to("/ferrum/basic_auth")
         browser.at_css(%([type="submit"])).click