Merge pull request #153 from rubycdp/enable_pending_specs

Mifrill · web-flow · commit 561b9b15f5b4 · 2021-02-16T18:41:37.000+05:00
diff --git a/spec/unit/browser_spec.rb b/spec/unit/browser_spec.rb
@@ -1,25 +1,25 @@
-# # frozen_string_literal: true
-#
-# require "stringio"
-#
-# module Ferrum
-#   describe Browser do
-#     it "logs requests and responses" do
-#       logger = StringIO.new
-#       browser = Browser.new(logger: logger)
-#
-#       browser.body
-#
-#       expect(logger.string).to include("return document.documentElement.outerHTML")
-#       expect(logger.string).to include("<html><head></head><body></body></html>")
-#     end
-#
-#     it "shows command line options passed" do
-#       browser = Browser.new(browser_options: { "blink-settings" => "imagesEnabled=false" })
-#
-#       arguments = browser.command("Browser.getBrowserCommandLine")["arguments"]
-#
-#       expect(arguments).to include("--blink-settings=imagesEnabled=false")
-#     end
-#   end
-# end
+# frozen_string_literal: true
+
+require "stringio"
+
+module Ferrum
+  describe Browser do
+    it "logs requests and responses" do
+      logger = StringIO.new
+      browser = Browser.new(logger: logger)
+
+      browser.body
+
+      expect(logger.string).to include("return document.documentElement.outerHTML")
+      expect(logger.string).to include("<html><head></head><body></body></html>")
+    end
+
+    it "shows command line options passed" do
+      browser = Browser.new(browser_options: { "blink-settings" => "imagesEnabled=false" })
+
+      arguments = browser.command("Browser.getBrowserCommandLine")["arguments"]
+
+      expect(arguments).to include("--blink-settings=imagesEnabled=false")
+    end
+  end
+end
diff --git a/spec/unit/process_spec.rb b/spec/unit/process_spec.rb
@@ -1,26 +1,26 @@
-# # frozen_string_literal: true
-#
-# module Ferrum
-#   class Browser
-#     describe Process do
-#       subject { Browser.new(port: 6000, host: "127.0.0.1") }
-#
-#       unless Ferrum.windows?
-#         it "forcibly kills the child if it does not respond to SIGTERM" do
-#           allow(::Process).to receive_messages(spawn: 5678)
-#           allow(::Process).to receive(:wait).and_return(nil)
-#           allow(Client).to receive(:new).and_return(double.as_null_object)
-#
-#           allow_any_instance_of(Process).to receive(:parse_ws_url)
-#
-#           subject.send(:start)
-#
-#           expect(::Process).to receive(:kill).with("USR1", 5678).ordered
-#           expect(::Process).to receive(:kill).with("KILL", 5678).ordered
-#
-#           subject.quit
-#         end
-#       end
-#     end
-#   end
-# end
+# frozen_string_literal: true
+
+module Ferrum
+  class Browser
+    describe Process do
+      subject { Browser.new(port: 6000, host: "127.0.0.1") }
+
+      unless Ferrum.windows?
+        it "forcibly kills the child if it does not respond to SIGTERM" do
+          allow(::Process).to receive_messages(spawn: 5678)
+          allow(::Process).to receive(:wait).and_return(nil)
+          allow(Client).to receive(:new).and_return(double.as_null_object)
+
+          allow_any_instance_of(Process).to receive(:parse_ws_url)
+
+          subject.send(:start)
+
+          expect(::Process).to receive(:kill).with("USR1", 5678).ordered
+          expect(::Process).to receive(:kill).with("KILL", 5678).ordered
+
+          subject.quit
+        end
+      end
+    end
+  end
+end
