Merge pull request #259 from rubycdp/download-file

Send real file and check for absolute path

Author: route

lib/ferrum/page.rb

@@ -262,7 +262,16 @@ def prepare_page
       end
 
       if @browser.options[:save_path]
-        command("Browser.setDownloadBehavior", behavior: "allow", downloadPath: @browser.options[:save_path], eventsEnabled: true)
+        unless Pathname.new(@browser.options[:save_path]).absolute?
+          raise Error, "supply absolute path as `:save_path` option"
+        end
+
+        @browser.command("Browser.setDownloadBehavior",
+                         downloadPath: browser.options[:save_path],
+                         behavior: "allow", eventsEnabled: true)
+        command("Page.setDownloadBehavior",
+                downloadPath: browser.options[:save_path],
+                behavior: "allow")
       end
 
       @browser.extensions.each do |extension|

spec/download_spec.rb

@@ -3,17 +3,34 @@
 module Ferrum
   describe Browser do
     context "download support" do
+      let(:filename) { "attachment.pdf" }
       let(:browser) do
         Ferrum::Browser.new(
           base_url: Ferrum::Server.server.base_url,
-          save_path: "/tmp/ferrum"
+          save_path: save_path
         )
       end
 
-      it "saves an attachment" do
-        browser.go_to("/attachment.pdf")
+      context "absolute path" do
+        let(:save_path) { "/tmp/ferrum" }
 
-        expect(File.exist?("/tmp/ferrum/attachment.pdf")).to be true
+        it "saves an attachment" do
+          browser.go_to("/#{filename}")
+
+          expect(File.exist?("#{save_path}/#{filename}")).to be true
+        ensure
+          FileUtils.rm_rf(save_path)
+        end
+      end
+
+      context "local path" do
+        let(:save_path) { "spec/tmp" }
+
+        it "raises an error" do
+          expect do
+            browser.go_to("/#{filename}")
+          end.to raise_error(Ferrum::Error, "supply absolute path as `:save_path` option")
+        end
       end
     end
   end

spec/support/application.rb

@@ -183,9 +183,8 @@ def initialize(something, message)
     end
 
     get "/attachment.pdf" do
-      path = "/tmp/ferrum/attachment.pdf"
-      FileUtils.touch(path)
-      attachment(path, :attachment)
+      attachment("attachment.pdf")
+      send_file("attachment.pdf")
     end
 
     get "/:view" do |view|