issue#229 Node#selected - returns nodes instead texts

Author: Mifrill

README.md

@@ -1098,7 +1098,7 @@ frame.at_css("//a[text() = 'Log in']") # => Node
 #### property
 #### attribute
 #### evaluate
-#### selected : `Array`
+#### selected : `Array<Node>`
 #### select
 
 

lib/ferrum/node.rb

@@ -136,7 +136,7 @@ def selected
           if (element.nodeName.toLowerCase() !== 'select') {
             throw new Error('Element is not a <select> element.');
           }
-          return Array.from(element).filter(option => option.selected).map((option) => option.text);
+          return Array.from(element).filter(option => option.selected);
         }
       JS
       page.evaluate_func(function, self)

spec/node_spec.rb

@@ -89,24 +89,24 @@ module Ferrum
       end
 
       it "returns texts of selected options" do
-        expect(browser.at_xpath("//*[@id='form_region']").selected).to eq(["Norway"])
+        expect(browser.at_xpath("//*[@id='form_region']").selected.map(&:text)).to eq(["Norway"])
       end
 
       context "when options exists but no selected option" do
         it "returns first option text as default value" do
-          expect(browser.at_xpath("//*[@id='form_title']").selected).to eq(["Mrs"])
+          expect(browser.at_xpath("//*[@id='form_title']").selected.map(&:text)).to eq(["Mrs"])
         end
       end
 
       context "when no selected options" do
         it "returns empty array" do
-          expect(browser.at_xpath("//*[@id='form_tendency']").selected).to eq([])
+          expect(browser.at_xpath("//*[@id='form_tendency']").selected.map(&:text)).to eq([])
         end
       end
 
       context "when selector is not <select>" do
         it "raises JavaScriptError with proper message" do
-          expect { browser.at_xpath("//*[@id='customer_name']").selected }
+          expect { browser.at_xpath("//*[@id='customer_name']").selected.map(&:text) }
             .to raise_exception(Ferrum::JavaScriptError, /Element is not a <select> element/)
         end
       end
@@ -118,13 +118,13 @@ module Ferrum
       end
 
       it "picks option in select by match string argument" do
-        expect(browser.at_xpath("//*[@id='form_title']").select("Miss").selected).to eq(["Miss"])
+        expect(browser.at_xpath("//*[@id='form_title']").select("Miss").selected.map(&:text)).to eq(["Miss"])
       end
 
       shared_examples "clears selected options with no exception" do |options|
         it "clears selected options with no exception" do
-          expect(browser.at_xpath("//*[@id='form_title']").selected).to eq(["Mrs"])
-          expect(browser.at_xpath("//*[@id='form_title']").select(options).selected).to eq([])
+          expect(browser.at_xpath("//*[@id='form_title']").selected.map(&:text)).to eq(["Mrs"])
+          expect(browser.at_xpath("//*[@id='form_title']").select(options).selected.map(&:text)).to eq([])
         end
       end
 
@@ -142,18 +142,20 @@ module Ferrum
 
       context "when one of option with provided texts does not exist" do
         it "picks only existed options with no exception" do
-          expect(browser.at_xpath("//*[@id='form_title']").selected).to eq(["Mrs"])
-          expect(browser.at_xpath("//*[@id='form_title']").select(%w[Mrs SQL]).selected).to eq(["Mrs"])
+          expect(browser.at_xpath("//*[@id='form_title']").selected.map(&:text)).to eq(["Mrs"])
+          expect(browser.at_xpath("//*[@id='form_title']").select(%w[Mrs SQL]).selected.map(&:text)).to eq(["Mrs"])
         end
       end
 
       context "when select has multiple property" do
         it "picks options in select by match arguments as array" do
-          expect(browser.at_xpath("//*[@id='form_languages']").select(%w[SQL Ruby]).selected).to eq(%w[Ruby SQL])
+          expect(browser.at_xpath("//*[@id='form_languages']").select(%w[SQL Ruby]).selected.map(&:text))
+            .to eq(%w[Ruby SQL])
         end
 
         it "picks options in select by match arguments as string" do
-          expect(browser.at_xpath("//*[@id='form_languages']").select("SQL, Ruby").selected).to eq(%w[Ruby SQL])
+          expect(browser.at_xpath("//*[@id='form_languages']").select("SQL, Ruby").selected.map(&:text))
+            .to eq(%w[Ruby SQL])
         end
       end
 
@@ -166,7 +168,7 @@ module Ferrum
 
       context "when provided texts of disabled option" do
         it "picks disabled option with no exception" do
-          expect(browser.at_xpath("//*[@id='form_title']").select(["Other"]).selected).to eq(["Other"])
+          expect(browser.at_xpath("//*[@id='form_title']").select(["Other"]).selected.map(&:text)).to eq(["Other"])
         end
       end
     end