feat(break): add Ferrum::Network::Response#body! and body. Changle default behavior of body, it returns nil instead of throwing error.

Author: route

CHANGELOG.md

@@ -1,8 +1,11 @@
 ## [Unreleased](https://github.com/rubycdp/ferrum/compare/v0.17.1...main) ##
 
 ### Added
+- `Ferrum::Network::Response#body!` returns body or throws error if implicable
 
 ### Changed
+- `Ferrum::Network::Response#body` returns body or nil in case of errors
+- Disable Chrome code sign clones [#555]
 
 ### Fixed
 

lib/ferrum/network/response.rb

@@ -124,14 +124,27 @@ def body_size=(size)
       #
       # @return [String]
       #
-      def body
+      # @raise [Ferrum::BrowserError]
+      #
+      def body!
         @body ||= begin
           body, encoded = @page.command("Network.getResponseBody", requestId: id)
                                .values_at("body", "base64Encoded")
           encoded ? Base64.decode64(body) : body
         end
       end
 
+      #
+      # The response body.
+      #
+      # @return [String, nil]
+      #
+      def body
+        body!
+      rescue Ferrum::BrowserError
+        # nop
+      end
+
       #
       # @return [Boolean]
       #

spec/network/response_spec.rb

@@ -42,24 +42,54 @@
     end
   end
 
-  describe "#body" do
+  describe "#body!" do
     it "gets response body" do
       page.go_to("/with_js")
       responses = traffic.map(&:response)
 
       expect(responses.size).to eq(4)
 
       expect(responses[0].url).to end_with("/with_js")
-      expect(responses[0].body).to include("ferrum with_js")
+      expect(responses[0].body!).to include("ferrum with_js")
 
       expect(responses[1].url).to end_with("/jquery.min.js")
-      expect(responses[1].body).to include("jQuery v3.7.1")
+      expect(responses[1].body!).to include("jQuery v3.7.1")
 
       expect(responses[2].url).to end_with("/jquery-ui.min.js")
-      expect(responses[2].body).to include("jQuery UI - v1.13.2")
+      expect(responses[2].body!).to include("jQuery UI - v1.13.2")
 
       expect(responses[3].url).to end_with("/test.js")
-      expect(responses[3].body).to include("This is test.js file content")
+      expect(responses[3].body!).to include("This is test.js file content")
+    end
+
+    it "throws error" do
+      page.go_to("/with_js")
+      responses = traffic.map(&:response)
+      page.go_to("/with_different_resources")
+
+      expect(responses[0].url).to end_with("/with_js")
+      expect { responses[0].body! }.to raise_error(Ferrum::BrowserError, "No resource with given identifier found")
+    end
+  end
+
+  describe "#body" do
+    it "gets response body" do
+      page.go_to("/with_js")
+      responses = traffic.map(&:response)
+
+      expect(responses.size).to eq(4)
+
+      expect(responses[0].url).to end_with("/with_js")
+      expect(responses[0].body).to include("ferrum with_js")
+    end
+
+    it "throws error" do
+      page.go_to("/with_js")
+      responses = traffic.map(&:response)
+      page.go_to("/with_different_resources")
+
+      expect(responses[0].url).to end_with("/with_js")
+      expect(responses[0].body).to be_nil
     end
   end