Fix rubocop

route · route · commit d98fc13d306b · 2022-05-08T13:54:00.000+02:00
diff --git a/lib/ferrum/browser.rb b/lib/ferrum/browser.rb
@@ -67,7 +67,7 @@ def initialize(options = nil)
 
       self.base_url = @options[:base_url] if @options.key?(:base_url)
 
-      if ENV["FERRUM_DEBUG"] && !@logger
+      if ENV.fetch("FERRUM_DEBUG", nil) && !@logger
         $stdout.sync = true
         @logger = $stdout
         @options[:logger] = @logger
diff --git a/lib/ferrum/browser/command.rb b/lib/ferrum/browser/command.rb
@@ -29,7 +29,7 @@ def initialize(defaults, options, user_data_dir)
         @defaults = defaults
         @options = options
         @user_data_dir = user_data_dir
-        @path = options[:browser_path] || ENV["BROWSER_PATH"] || defaults.detect_path
+        @path = options[:browser_path] || ENV.fetch("BROWSER_PATH", nil) || defaults.detect_path
         raise Cliver::Dependency::NotFound, NOT_FOUND unless @path
 
         merge_options
diff --git a/lib/ferrum/network.rb b/lib/ferrum/network.rb
@@ -151,16 +151,16 @@ def build_exchange(id)
       Network::Exchange.new(@page, id).tap { |e| @traffic << e }
     end
 
-    def emulate_network_conditions(offline: false, latency: 0, download_throughput: -1, upload_throughput: -1, connection_type: nil)
+    def emulate_network_conditions(offline: false, latency: 0,
+                                   download_throughput: -1, upload_throughput: -1,
+                                   connection_type: nil)
       params = {
         offline: offline, latency: latency,
         downloadThroughput: download_throughput,
         uploadThroughput: upload_throughput
       }
 
-      if connection_type && ALLOWED_CONNECTION_TYPE.include?(connection_type)
-        params[:connectionType] = connection_type
-      end
+      params[:connectionType] = connection_type if connection_type && ALLOWED_CONNECTION_TYPE.include?(connection_type)
 
       @page.command("Network.emulateNetworkConditions", params)
       true
diff --git a/spec/browser_spec.rb b/spec/browser_spec.rb
@@ -369,11 +369,11 @@ module Ferrum
     it "allows the driver to have a custom host", skip: ENV["BROWSER_TEST_HOST"].nil? do
       # Use custom host "pointing" to localhost in /etc/hosts or iptables for this.
       # https://superuser.com/questions/516208/how-to-change-ip-address-to-point-to-localhost
-      browser = Browser.new(host: ENV["BROWSER_TEST_HOST"], port: 12_345)
+      browser = Browser.new(host: ENV.fetch("BROWSER_TEST_HOST"), port: 12_345)
       browser.go_to(base_url)
 
       expect do
-        TCPServer.new(ENV["BROWSER_TEST_HOST"], 12_345)
+        TCPServer.new(ENV.fetch("BROWSER_TEST_HOST"), 12_345)
       end.to raise_error(Errno::EADDRINUSE)
     ensure
       browser&.quit
diff --git a/spec/network_spec.rb b/spec/network_spec.rb
@@ -407,9 +407,9 @@ module Ferrum
       page.network.offline_mode
 
       expect { page.go_to("/ferrum/with_js") }.to raise_error(
-                                                    Ferrum::StatusError,
-                                                    %r{Request to http://.*/ferrum/with_js failed to reach server, check DNS and server status}
-                                                  )
+        Ferrum::StatusError,
+        %r{Request to http://.*/ferrum/with_js failed to reach server, check DNS and server status}
+      )
 
       expect(page.body).to eq("<html><head></head><body></body></html>")
     end
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -54,7 +54,7 @@
   end
 
   config.after(:each) do |example|
-    save_exception_artifacts(browser, example.metadata, ferrum_logger) if ENV["CI"] && example.exception
+    save_exception_artifacts(browser, example.metadata, ferrum_logger) if ENV.fetch("CI", nil) && example.exception
 
     reset
   end
