issue#229 fix cases when option with empty text/value

Author: Mifrill

lib/ferrum/node.rb

@@ -152,14 +152,14 @@ def select(*values, by: :value)
             const options = Array.from(element.options);
             element.value = undefined;
             for (const option of options) {
-              option.selected = values.includes(option[by]);
+              option.selected = values.some((value) => option[by] === value);
               if (option.selected && !element.multiple) break;
             }
             element.dispatchEvent(new Event('input', { bubbles: true }));
             element.dispatchEvent(new Event('change', { bubbles: true }));
           }
         JS
-        page.evaluate_func(function, self, values.join(","), by)
+        page.evaluate_func(function, self, values.flatten, by)
       end
     end
 

spec/node_spec.rb

@@ -153,8 +153,8 @@ module Ferrum
             .to eq(%w[Ruby SQL])
         end
 
-        it "picks options in select by match arguments as string" do
-          expect(browser.at_xpath("//*[@id='form_languages']").select("SQL, Ruby").selected.map(&:text))
+        it "picks options in select by match arguments as strings" do
+          expect(browser.at_xpath("//*[@id='form_languages']").select("SQL", "Ruby").selected.map(&:text))
             .to eq(%w[Ruby SQL])
         end
       end
@@ -174,8 +174,23 @@ module Ferrum
 
       context "when option with text and value" do
         it "picks option in select by matched text" do
-          expect(browser.at_xpath("//select[@id='form_locale']").select("Swedish", by: :text).selected.map(&:value)).
-            to eq(["sv"])
+          expect(browser.at_xpath("//select[@id='form_locale']").select("Swedish", by: :text).selected.map(&:value))
+            .to eq(["sv"])
+        end
+      end
+
+      context "when option with empty text/value" do
+        it "picks option in select by match string argument" do
+          expect(browser.at_xpath("//select[@id='empty_option']").select("AU").selected.map(&:value)).to eq(["AU"])
+        end
+
+        it "picks empty option by match empty value argument" do
+          expect(browser.at_xpath("//select[@id='empty_option']").select("").selected.map(&:value)).to eq([""])
+        end
+
+        it "picks empty option by match empty text argument" do
+          expect(browser.at_xpath("//select[@id='empty_option']").select("", by: :text).selected.map(&:text))
+            .to eq([""])
         end
       end
     end

spec/support/views/form.erb

@@ -672,3 +672,8 @@ New line after and before textarea tag
 <p>
   <input id="hidden_input" style="display: none"/>
 </p>
+
+<select id="empty_option">
+  <option value=""></option>
+  <option value="AU">Australia</option>
+</select>