Merge pull request #190 from hmdne/capture-stacktrace

Capture error stacktraces

Author: route

lib/ferrum.rb

@@ -103,10 +103,11 @@ def initialize(response = nil)
   end
 
   class JavaScriptError < BrowserError
-    attr_reader :class_name, :message
+    attr_reader :class_name, :message, :stack_trace
 
-    def initialize(response)
+    def initialize(response, stack_trace = nil)
       @class_name, @message = response.values_at("className", "description")
+      @stack_trace = stack_trace
       super(response.merge("message" => @message))
     end
   end

lib/ferrum/frame/runtime.rb

@@ -154,7 +154,7 @@ def handle_error(response)
         when /\AError: timed out promise/
           raise ScriptTimeoutError
         else
-          raise JavaScriptError.new(result)
+          raise JavaScriptError.new(result, response.dig("exceptionDetails", "stackTrace"))
         end
       end
 

lib/ferrum/page.rb

@@ -221,7 +221,10 @@ def subscribe
       if @browser.js_errors
         on("Runtime.exceptionThrown") do |params|
           # FIXME https://jvns.ca/blog/2015/11/27/why-rubys-timeout-is-dangerous-and-thread-dot-raise-is-terrifying/
-          Thread.main.raise JavaScriptError.new(params.dig("exceptionDetails", "exception"))
+          Thread.main.raise JavaScriptError.new(
+            params.dig("exceptionDetails", "exception"),
+            params.dig("exceptionDetails", "stackTrace")
+          )
         end
       end