Option to Raise Error for Missing extra_sources Files

[nna774]

Thank you for implementing config.extra_sources in PR #366 ! I personally had a monkey patch in place to achieve similar functionality, and this new feature allowed me to remove it entirely, which is fantastic.

Currently, if a file specified in config.extra_sources does not exist, it is silently skipped. For example, the following code:

Config.setup do |config|
  config.extra_sources = ['does_not_exists.yml']
end

will not raise an error. This behavior appears to stem from the implementation around

config/lib/config/sources/yaml_source.rb

Line 17 in 5e192a5

if @path and File.exist?(@path)

Expected Behavior / Feature Request:
I propose adding an option to make Config raise an error (e.g., FileNotFoundError or a custom Config::Error) when a file listed in config.extra_sources does not exist.

The current silent failure can make it difficult to identify misconfigurations or typos in file paths. Explicitly raising an error would provide immediate feedback, aiding in debugging and ensuring that all intended configuration sources are loaded.

Thanks!

[Fryguy]

I'm not sure on this one. I can see use cases where you just want to specify a bunch of optional yml files. Also the caller could always check existence if they wanted...something like:

Config.setup do |config|
  raise "does_not_exists.yml should exist" unless File.exist?("does_not_exists.yml")
  config.extra_sources = ['does_not_exists.yml']
end

[Nuzair46]

I agree with @Fryguy
Adding this error could also cause issues when normal sources load.
Users might not want to have some files like secrets.local.yml which the gem looks for but it is optional.

Making it raise error will require significant breaking change to the gem.
One other choice will be to raise a warning instead when files defined in the setup are not found and this should have another option to suppress this warning.

Another non breaking approach would be to only throw errors for files explicitly defined in the setup like extra_sources not being present. I would prefer this approach than making it throw error for all non available files.

[nna774]

I agree. For cases like secrets.local.yml, where a file should be loaded if it exists, the current behavior is definitely better.

The original reason for my suggestion was that I had mistyped a filename I wanted to add to extra_sources, and it was very difficult to notice the error.
I agree that simply raising an error isn't a good idea due to the breaking changes it would cause.

Another non breaking approach would be to only throw errors for files explicitly defined in the setup like extra_sources not being present. I would prefer this approach than making it throw error for all non available files.

This sounds good!

[Nuzair46]

@Fryguy @pkuczynski wdyt about this?