Update facilitator and user specs to correctly cross-reference

Author: maebeale

spec/factories/users.rb

@@ -46,6 +46,10 @@
       super_user { true }
     end
 
+    trait :with_facilitator do
+      facilitator { association :facilitator, user: instance }
+    end
+
     trait :orphaned_reports do
       email { "orphaned_reports@awbw.org" }
       super_user { true }

spec/models/facilitator_spec.rb

@@ -11,8 +11,7 @@
   end
 
   describe "#name" do
-    let(:user) { build(:user, first_name: "Jane", last_name: "Doe") }
-    let(:facilitator) { build(:facilitator, user: user) }
+    let(:facilitator) { build(:facilitator, first_name: "Jane", last_name: "Doe") }
 
     context "when display_name_preference is full_name" do
       it "returns the full name" do

spec/views/facilitators/index.html.erb_spec.rb

@@ -1,20 +1,19 @@
 require 'rails_helper'
 
 RSpec.describe "facilitators/index", type: :view do
-    let(:user) { create(:user) }
   let(:admin) { create(:user, :admin) }
 
   let(:facilitator) { create(:facilitator)}
   let(:facilitator_2) { create(:facilitator)}
 
   before(:each) do
     assign(:facilitators, paginated([facilitator, facilitator_2]))
-    allow(view).to receive(:current_user).and_return(user)
+    allow(view).to receive(:current_user).and_return(admin)
   end
 
   it "renders a list of facilitators" do
     render
-    expect(rendered).to match(facilitator.user.first_name)
-    expect(rendered).to match(facilitator_2.user.first_name)
+    expect(rendered).to match(facilitator.first_name)
+    expect(rendered).to match(facilitator_2.first_name)
   end
 end

spec/views/facilitators/show.html.erb_spec.rb

@@ -1,20 +1,19 @@
 require 'rails_helper'
 
 RSpec.describe "facilitators/show", type: :view do
-  let(:user) { create(:user) }
   let(:admin) { create(:user, :admin) }
 
   let(:facilitator) { create(:facilitator)}
 
   before do
     assign(:facilitator, facilitator.decorate)
-    allow(view).to receive(:current_user).and_return(user)
+    allow(view).to receive(:current_user).and_return(admin)
     render
   end
 
   it "renders attributes" do
-    expect(rendered).to match(facilitator.user.first_name)
-    expect(rendered).to match(facilitator.user.last_name)
+    expect(rendered).to match(facilitator.first_name)
+    expect(rendered).to match(facilitator.last_name)
     expect(rendered).to match(facilitator.user.email)
   end
 end

spec/views/users/index.html.erb_spec.rb

@@ -1,21 +1,83 @@
-require 'rails_helper'
+require "rails_helper"
 
 RSpec.describe "users/index", type: :view do
-  let(:admin_user) { create(:user, :admin) } # or super_user trait
+  let(:admin_user) { create(:user, :admin) }
 
-  before(:each) do
-    allow(view).to receive(:current_user).and_return(admin_user) # Stub current_user for Devise
-    users = create_list(:user, 3, first_name: "Alice")
-    paginated_users = WillPaginate::Collection.create(1, 10, users.size) do |pager|
-      pager.replace(users)
+  before do
+    allow(view).to receive(:current_user).and_return(admin_user)
+  end
+
+  context "when users have facilitators" do
+    before do
+      @users = create_list(:user, 2, :with_facilitator) # Factory should build facilitator + avatar if needed
+
+      paginated = WillPaginate::Collection.create(1, 10, @users.size) do |pager|
+        pager.replace(@users)
+      end
+
+      assign(:users, paginated)
+      assign(:users_count, @users.size)
+    end
+
+    it "renders facilitator profile buttons instead of 'Create facilitator'" do
+      render
+
+      # Two rows
+      expect(rendered).to have_selector("table tbody tr", count: 2)
+
+      @users.each do |user|
+        facilitator = user.facilitator
+
+        # The helper output (button) must appear
+        expect(rendered).to include(facilitator.name)
+
+        # Should NOT show "Create facilitator"
+        expect(rendered).not_to include("Create facilitator")
+      end
     end
-    assign(:users, paginated_users)
   end
 
-  it "renders a list of users" do
-    render
+  context "when a user has NO facilitator" do
+    let!(:user_without_facilitator) { create(:user) }
+
+    before do
+      paginated = WillPaginate::Collection.create(1, 10, 1) do |pager|
+        pager.replace([user_without_facilitator])
+      end
 
-    assert_select "table tbody tr", count: 3
-    assert_select "table tbody tr td", text: /Alice/
+      assign(:users, paginated)
+      assign(:users_count, 1)
+    end
+
+    it "shows 'Create facilitator' button" do
+      render
+
+      expect(rendered).to include("Create facilitator")
+      expect(rendered).to have_link(
+                            "Create facilitator",
+                            href: new_facilitator_path(user_id: user_without_facilitator.id)
+                          )
+    end
+  end
+
+  context "general index behavior" do
+    before do
+      users = create_list(:user, 3)
+
+      paginated = WillPaginate::Collection.create(1, 10, users.size) do |pager|
+        pager.replace(users)
+      end
+
+      assign(:users, paginated)
+      assign(:users_count, users.size)
+    end
+
+    it "renders correct table structure" do
+      render
+
+      expect(rendered).to have_selector("table thead tr th", text: "Name")
+      expect(rendered).to have_selector("table thead tr th", text: "Email")
+      expect(rendered).to have_selector("table tbody tr", count: 3)
+    end
   end
 end