Notification refresh (#626)

* Generate Notifications/mailers and run a job via a service every time StoryIdea, WorkshopIdea, WorkshopVariation, EventRegistration is created

* Add some includes to bookmark endpoints to try and remove n+1's

* Update action_mailer and mail-related settings (and delete mail.rb initializer)

* Add class for SectorImpact bc it's needed for rake tasks

* Rubocop and test fixes

* Prune workshop_log_decorator

Author: maebeale

app/controllers/bookmarks_controller.rb

@@ -3,7 +3,7 @@ class BookmarksController < ApplicationController
 
   def index
     per_page = params[:number_of_items_per_page] || 25
-    unfiltered = Bookmark.all
+    unfiltered = Bookmark.includes(:primary_asset, :gallery_assets, :windows_type)
     filtered = unfiltered.search(params)
     filtered = filtered.sorted(params[:sort])
 
@@ -24,7 +24,8 @@ def personal
     @user_name = user.full_name if user
     @viewing_self = user == current_user
 
-    bookmarks = Bookmark.search(params, user: user)
+    bookmarks = Bookmark.includes(bookmarkable: [ :primary_asset, :gallery_assets, :windows_type ])
+    bookmarks = bookmarks.search(params, user: user)
     bookmarks = bookmarks.sorted(params[:sort])
 
     @bookmarks_count = bookmarks.length

app/controllers/event_registrations_controller.rb

@@ -24,6 +24,13 @@ def create
     @event_registration = EventRegistration.new(event_registration_params)
 
     if @event_registration.save
+      NotificationServices::CreateNotification.call(
+        noticeable: @event_registration,
+        kind: :record_created,
+        recipient_role: (current_user.super_user? ? :admin : :facilitator),
+        recipient_email: current_user.email,
+        notification_type: 0)
+
       respond_to do |format|
         format.html {
           redirect_to event_registrations_path,

app/controllers/notifications_controller.rb

@@ -0,0 +1,27 @@
+class NotificationsController < ApplicationController
+  before_action :set_notification, only: [ :show ]
+
+  def index
+    per_page = params[:number_of_items_per_page].presence || 25
+    @notifications =
+      if current_user.super_user?
+        Notification.all
+      else
+        Notification.where(recipient_email: current_user.email)
+      end
+
+    @notifications = @notifications
+                       .includes(:noticeable)
+                       .order(created_at: :desc)
+                       .paginate(page: params[:page], per_page: per_page)
+  end
+
+  def show
+  end
+
+  private
+
+  def set_notification
+    @notification = Notification.find(params[:id])
+  end
+end

app/controllers/story_ideas_controller.rb

@@ -28,6 +28,12 @@ def create
     @story_idea = StoryIdea.new(story_idea_params)
 
     if @story_idea.save
+      NotificationServices::CreateNotification.call(
+        noticeable: @story_idea,
+        kind: :record_created,
+        recipient_role: (current_user.super_user? ? :admin : :facilitator),
+        recipient_email: current_user.email,
+        notification_type: 0)
       redirect_to story_ideas_path, notice: "StoryIdea was successfully created."
     else
       set_form_variables

app/controllers/workshop_ideas_controller.rb

@@ -24,6 +24,12 @@ def create
     @workshop_idea = WorkshopIdea.new(workshop_idea_params)
 
     if @workshop_idea.save
+      NotificationServices::CreateNotification.call(
+        noticeable: @story_idea,
+        kind: :record_created,
+        recipient_role: (current_user.super_user? ? :admin : :facilitator),
+        recipient_email: current_user.email,
+        notification_type: 0)
       redirect_to workshop_ideas_path, notice: "Workshop idea was successfully created."
     else
       set_form_variables

app/controllers/workshop_logs_controller.rb

@@ -61,6 +61,13 @@ def create
     @workshop_log = WorkshopLog.new(workshop_log_params)
 
     if @workshop_log.save
+      NotificationServices::CreateNotification.call(
+        noticeable: @workshop_log,
+        kind: :record_created,
+        recipient_role: (current_user.super_user? ? :admin : :facilitator),
+        recipient_email: current_user.email,
+        notification_type: 0)
+
       flash[:notice] = "Thank you for submitting a workshop log. To see all of your completed logs, please view your Profile."
       redirect_to authenticated_root_path
     else
@@ -139,12 +146,11 @@ def set_form_variables
       @workshop = Workshop.new
     end
 
-    workshops = if current_user.super_user?
-                  Workshop.all
-    else
-                  Workshop.published
+    workshops = Workshop.includes(:windows_type)
+    unless current_user.super_user?
+      workshops = workshops.published
     end
-    @workshops = workshops.or(Workshop.where(id: @workshop_log.workshop_id))
+    @workshops = workshops.or(Workshop.where(id: @workshop_log.workshop_id).includes(:windows_type))
                           .distinct
                           .order(title: :asc)
 
@@ -165,7 +171,7 @@ def set_form_variables
     # @files = MediaFile.where(["workshop_log_id = ?", @workshop_log.id])
 
     @windows_type_id = params[:windows_type_id].presence || @workshop.windows_type_id ||
-      WindowsType.where(short_name: "COMBINED")
+      WindowsType.where(short_name: "COMBINED").last.id
     form = FormBuilder.where(windows_type_id: @windows_type_id)
                       .first&.forms.first # because there's only one form per form_builder
     if form

app/controllers/workshop_variations_controller.rb

@@ -27,6 +27,13 @@ def new
   def create
     @workshop_variation = WorkshopVariation.new(workshop_variation_params)
     if @workshop_variation.save
+      NotificationServices::CreateNotification.call(
+        noticeable: @workshop_variation,
+        kind: :record_created,
+        recipient_role: (current_user.super_user? ? :admin : :facilitator),
+        recipient_email: current_user.email,
+        notification_type: 0)
+
       flash[:notice] = "Workshop Variation has been created."
       if params[:from] == "workshop_show"
         redirect_to workshop_path(@workshop_variation.workshop, anchor: "workshop-variations")

app/decorators/workshop_log_decorator.rb

@@ -1,5 +1,71 @@
 class WorkshopLogDecorator < ApplicationDecorator
   def detail(length: nil)
-    length ? description&.truncate(length) : description
+    description = length ? object.description&.truncate(length) : object.description
+    "#{description}<br>#{participants_table}".html_safe
+  end
+
+  private
+
+  def participants_table
+    children_first = object.children_first_time.to_i
+    children_ongoing = object.children_ongoing.to_i
+
+    teens_first = object.teens_first_time.to_i
+    teens_ongoing = object.teens_ongoing.to_i
+
+    adults_first = object.adults_first_time.to_i
+    adults_ongoing = object.adults_ongoing.to_i
+
+    totals_first = children_first + teens_first + adults_first
+    totals_ongoing = children_ongoing + teens_ongoing + adults_ongoing
+
+    <<~HTML.html_safe
+      <table width="100%" cellpadding="0" cellspacing="0"
+             style="border-collapse:collapse; margin-top:12px;">
+        #{header_row}
+        #{data_row("Children", children_first, children_ongoing)}
+        #{data_row("Teens", teens_first, teens_ongoing)}
+        #{data_row("Adults", adults_first, adults_ongoing)}
+        #{total_row(totals_first, totals_ongoing)}
+      </table>
+    HTML
+  end
+
+  def header_row
+    %w[Group First\ Time Ongoing Total].map do |label|
+      "<td style=\"#{cell_style('font-weight:bold;background:#f5f5f5')}\">#{label}</td>"
+    end.then { |cells| "<tr>#{cells.join}</tr>" }
+  end
+
+  def data_row(label, first, ongoing)
+    total = first + ongoing
+
+    "<tr>" \
+      "<td style=\"#{cell_style}\">#{label}</td>" \
+      "<td style=\"#{cell_style}\">#{first}</td>" \
+      "<td style=\"#{cell_style}\">#{ongoing}</td>" \
+      "<td style=\"#{cell_style}\">#{total}</td>" \
+      "</tr>"
+  end
+
+  def total_row(first, ongoing)
+    total = first + ongoing
+
+    "<tr>" \
+      "<td style=\"#{cell_style('font-weight:bold')}\">Total</td>" \
+      "<td style=\"#{cell_style('font-weight:bold')}\">#{first}</td>" \
+      "<td style=\"#{cell_style('font-weight:bold')}\">#{ongoing}</td>" \
+      "<td style=\"#{cell_style('font-weight:bold')}\">#{total}</td>" \
+      "</tr>"
+  end
+
+  def cell_style(extra = "")
+    [
+      "border:1px solid #ddd",
+      "padding:6px",
+      "display:table-cell",
+      "vertical-align:top",
+      extra
+    ].reject(&:blank?).join("; ")
   end
 end

app/jobs/application_job.rb

@@ -0,0 +1,2 @@
+class ApplicationJob < ActiveJob::Base
+end

app/jobs/notification_mailer_job.rb

@@ -0,0 +1,31 @@
+class NotificationMailerJob < ApplicationJob
+  queue_as :default
+
+  def perform(notification_id)
+    notification = Notification.find(notification_id)
+
+    case notification.kind
+    when "record_created"
+      mailer = NotificationMailer.created_notification(notification)
+    when "record_submitted"
+      mailer = NotificationMailer.submitted_notification(notification)
+    end
+
+    return if notification.delivered_at.present? # Idempotency guard
+
+    mailer.deliver_now
+
+    persist_email(notification, mailer)
+  end
+end
+
+private
+
+def persist_email(notification, mail)
+  notification.update!(
+    email_subject: mail.subject,
+    email_body_html: mail.html_part&.body&.decoded,
+    email_body_text: mail.text_part&.body&.decoded,
+    delivered_at: Time.current
+  )
+end