Fix flaky capy tests that weren't waiting for an action to finish

Author: h-m-m

spec/system/banners/new_spec.rb

@@ -15,18 +15,16 @@
     check "Active?"
     fill_in_rich_text_area "banner_content", with: "Please fill out this survey."
     click_on "Submit"
-
-    visit banners_path
+    expect(page).to have_current_path(banners_path)
     expect(page).to have_text("Volunteer Survey Announcement")
 
-    visit banners_path
     within "#banners" do
       click_on "Edit", match: :first
     end
     fill_in "Name", with: "Better Volunteer Survey Announcement"
     click_on "Submit"
 
-    visit banners_path
+    expect(page).to have_current_path(banners_path)
     expect(page).to have_text("Better Volunteer Survey Announcement")
 
     visit root_path
@@ -44,17 +42,14 @@
     fill_in_rich_text_area "banner_content", with: "Please fill out this survey."
     click_on "Submit"
 
-    visit banners_path
+    expect(page).to have_current_path(banners_path)
     expect(page).to have_text("Expiring Announcement")
-
-    visit banners_path
     within "#banners" do
       click_on "Edit", match: :first
     end
     fill_in "banner_expires_at", with: 2.days.from_now.strftime("%m%d%Y\t%I%M%P")
     click_on "Submit"
-
-    visit banners_path
+    expect(page).to have_current_path(banners_path)
     expect(page).to have_text("Expiring Announcement")
 
     visit root_path
@@ -71,7 +66,7 @@
     fill_in_rich_text_area "banner_content", with: "Please fill out this survey."
     click_on "Submit"
 
-    visit banners_path
+    expect(page).to have_current_path(new_banner_path)
     expect(page).not_to have_text("Announcement not created")
   end
 
@@ -93,8 +88,8 @@
         check "Active?"
         fill_in_rich_text_area "banner_content", with: "New active banner content."
         click_on "Submit"
+        expect(page).to have_current_path(banners_path)
 
-        visit banners_path
         within("table#banners") do
           already_existing_banner_row = find("tr", text: active_banner.name)
 
@@ -118,7 +113,7 @@
         fill_in_rich_text_area "banner_content", with: "New active banner content."
         click_on "Submit"
 
-        visit banners_path
+        expect(page).to have_current_path(banners_path)
 
         within("table#banners") do
           already_existing_banner_row = find("tr", text: active_banner.name)

spec/system/bulk_court_dates/new_spec.rb

@@ -36,6 +36,7 @@
     within ".top-page-actions" do
       click_on "Create"
     end
+    expect(page).to have_current_path(new_bulk_court_date_path)
 
     visit casa_case_path(casa_case)
     expect(page).to have_content(hearing_type.name)

spec/system/case_contacts/additional_expenses_spec.rb

@@ -49,17 +49,19 @@
     fill_expense_fields 5.34, "Lunch"
     uncheck "Request travel or other reimbursement"
 
-    expect { click_on "Submit" }
-      .to change(CaseContact.active, :count).by(1)
+    expect do
+      click_on "Submit"
+
+      expect(page).to have_text("Case contact successfully created.")
+    end.to change(CaseContact.active, :count).by(1)
 
     case_contact = CaseContact.active.last
     expect(case_contact.additional_expenses).to be_empty
     expect(case_contact.miles_driven).to be_zero
     expect(case_contact.want_driving_reimbursement).to be false
   end
 
-  # TODO: Fix this test
-  xit "can remove an expense" do
+  it "can remove an expense" do
     subject
     fill_in_contact_details
     check "Request travel or other reimbursement"
@@ -81,6 +83,7 @@
       expect(page).to have_field(class: "expense-amount-input", count: 2)
 
       click_on "Submit"
+      expect(page).to have_text('Case contact successfully created.')
     }
       .to change(CaseContact.active, :count).by(1)
       .and change(AdditionalExpense, :count).by(2)