Merge pull request #6096 from thejonroberts/rspec-rails-setup-re-install

RSpec-Rails Configuration

Author: compwron

.gitignore

@@ -48,9 +48,6 @@ vendor/bundle/
 # produced by tests (?)
 .rakeTasks
 
-# produced by tests (?)
-*.csv
-
 .*.swp
 
 # Used for local developmen on Nix systems

.rspec

@@ -1 +1 @@
---require spec_helper --order random
+--require spec_helper

Gemfile

@@ -96,6 +96,6 @@ group :test do
   gem "rails-controller-testing"
   gem "rake"
   gem "selenium-webdriver"
-  gem "simplecov"
+  gem "simplecov", require: false
   gem "webmock" # HTTP request stubber
 end

Gemfile.lock

@@ -672,4 +672,4 @@ RUBY VERSION
    ruby 3.2.4p170
 
 BUNDLED WITH
-   2.5.22
+   2.5.23

app/services/volunteer_birthday_reminder_service.rb

@@ -7,7 +7,7 @@ def send_reminders
           .deliver(volunteer.supervisor)
       end
     else
-      puts "Volunteer Birthday Reminder Rake task skipped. Today is not the 15th of the month."
+      Rails.logger.info { "Volunteer Birthday Reminder Rake task skipped. Today is not the 15th of the month." }
     end
   end
 end

spec/datatables/reimbursement_datatable_spec.rb

@@ -21,7 +21,7 @@
 
   # Requires the following to be defined:
   # - `sorted_case_contacts` = array of reimbursement records ordered in the expected way
-  shared_examples_for "a sorted results set" do
+  RSpec.shared_examples_for "a sorted results set" do
     it "should order ascending by default" do
       expect(first_result[:id]).to eq(sorted_case_contacts.first.id.to_s)
     end

spec/factories/casa_orgs.rb

@@ -10,7 +10,7 @@
     twilio_phone_number { "+15555555555" }
 
     trait :with_logo do
-      logo { Rack::Test::UploadedFile.new(Rails.root.join("spec", "fixtures", "org_logo.jpeg")) }
+      logo { Rack::Test::UploadedFile.new(Rails.root.join("spec", "fixtures", "files", "org_logo.jpeg")) }
     end
 
     trait :all_reimbursements_enabled do

spec/fixtures/casa_cases.csv spec/fixtures/files/casa_cases.csvspec/fixtures/casa_cases.csv renamed to spec/fixtures/files/casa_cases.csv

@@ -1,4 +1,4 @@
-case_number,case_assignment,birth_month_year_youth,next_court_date
-CINA-01-4347,[email protected], March 2011,Sept 16 2022
-CINA-01-4348,"[email protected], [email protected]",February 2000,Jan 1 2023
-CINA-01-4349,,December 2016,
+case_number,case_assignment,birth_month_year_youth,next_court_date
+CINA-01-4347,[email protected], March 2011,Sept 16 2022
+CINA-01-4348,"[email protected], [email protected]",February 2000,Jan 1 2023
+CINA-01-4349,,December 2016,