Merge pull request #6529 from AudTheCodeWitch/acook/6527/fix-broken-change-password-button

Fix All CASA Admin "Change Password" button

Author: compwron

app/views/all_casa_admins/edit.html.erb

@@ -19,13 +19,13 @@
 
       <div class="actions">
         <%= form.button "Update Profile", type: "submit", class: "main-btn primary-btn btn-hover" %>
-        <button class="main-btn primary-btn btn-hover" id="accordionExample" type="button" data-toggle="collapse" data-target="#collapseOne" aria-expanded="true" aria-controls="collapseOne">
+        <button class="main-btn primary-btn btn-hover" type="button" data-bs-toggle="collapse" data-bs-target="#collapseOne" aria-expanded="false" aria-controls="collapseOne">
           Change Password
         </button>
       </div>
     <% end %>
     <br>
-    <div id="collapseOne" class="collapse" aria-labelledby="headingOne" data-parent="#accordionExample">
+    <div id="collapseOne" class="collapse" aria-labelledby="headingOne">
       <%= form_with(model: @user, scope: :all_casa_admin, url: {action: "update_password"}, method: :patch) do |f| %>
         <div class="input-style-1">
           <%= f.label :password, "Password" %><br>

spec/system/all_casa_admins/edit_spec.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+RSpec.describe "AllCasaAdmin edit page", type: :system do
+  let(:admin) { create(:all_casa_admin) }
+
+  before do
+    sign_in admin
+    visit edit_all_casa_admins_path
+  end
+
+  it "shows the password section only after clicking 'Change Password'", :aggregate_failures, :js do
+    expect_password_section_hidden
+
+    # Click the Change Password button
+    click_button "Change Password"
+
+    # Password section should now be visible
+    expect_password_section_visible
+  end
+
+  private
+
+  def expect_password_section_hidden
+    expect(page).to have_selector("#collapseOne.collapse:not(.show)", visible: :all)
+  end
+
+  def expect_password_section_visible
+    expect(page).to have_selector("#collapseOne.collapse.show")
+    expect(page).to have_field("all_casa_admin[password]")
+    expect(page).to have_field("all_casa_admin[password_confirmation]")
+    expect(page).to have_button("Update Password")
+  end
+end

spec/system/all_casa_admins/password_change_spec.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+RSpec.describe "AllCasaAdmin password change", type: :system do
+  let(:admin) { create(:all_casa_admin, email: "[email protected]", password: "12345678") }
+
+  before do
+    sign_in admin
+    visit edit_all_casa_admins_path
+    click_button "Change Password"
+  end
+
+  it "shows error when password fields are blank", :aggregate_failures, :js do
+    click_button "Update Password"
+    expect(page).to have_selector("#error_explanation.alert")
+    expect(page).to have_text("Password can't be blank")
+  end
+
+  it "shows error when password confirmation doesn't match", :aggregate_failures, :js do
+    fill_in "all_casa_admin[password]", with: "newpassword"
+    fill_in "all_casa_admin[password_confirmation]", with: "wrongconfirmation"
+    click_button "Update Password"
+    expect(page).to have_selector("#error_explanation.alert")
+    expect(page).to have_text("Password confirmation doesn't match Password")
+  end
+
+  it "shows success flash when password is updated", :aggregate_failures, :js do
+    fill_in "all_casa_admin[password]", with: "newpassword"
+    fill_in "all_casa_admin[password_confirmation]", with: "newpassword"
+    click_button "Update Password"
+    expect(page).to have_selector(".header-flash")
+    expect(page).to have_text("Password was successfully updated.")
+  end
+end

spec/views/all_casa_admins/edit.html.erb_spec.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+RSpec.describe "all_casa_admins/edit", type: :view do
+  let(:user) { build_stubbed(:all_casa_admin) }
+
+  before do
+    assign(:user, user)
+    render
+  end
+
+  it "renders the edit profile form", :aggregate_failures do
+    expect(rendered).to have_selector("form[action='#{all_casa_admins_path}'][method='post']")
+    expect(rendered).to have_field("all_casa_admin[email]")
+    expect(rendered).to have_button("Update Profile")
+  end
+
+  it "renders the change password collapse section, hidden by default", :aggregate_failures do
+    expect(rendered).to have_selector("#collapseOne.collapse")
+    expect(rendered).not_to include('class="collapse show"')
+    expect(rendered).to have_field("all_casa_admin[password]")
+    expect(rendered).to have_field("all_casa_admin[password_confirmation]")
+    expect(rendered).to have_button("Update Password")
+  end
+
+  context "when there are error and flash messages" do
+    before do
+      user.errors.add(:email, "can't be blank")
+      flash[:notice] = "Profile updated"
+      render
+    end
+
+    it "renders error and flash messages partials", :aggregate_failures do
+      expect(rendered).to have_selector("#error_explanation.alert")
+      expect(rendered).to have_text("can't be blank")
+      expect(rendered).to have_selector(".header-flash")
+      expect(rendered).to have_text("Profile updated")
+    end
+  end
+
+  context "when submitting the password change form" do
+    before do
+      sign_in user
+      assign(:user, user)
+      render
+    end
+
+    it "shows error when password fields are blank", :aggregate_failures do
+      user.errors.add(:password, "can't be blank")
+      render
+      expect(rendered).to have_selector("#error_explanation.alert")
+      expect(rendered).to have_text("can't be blank")
+    end
+
+    it "shows error when password confirmation does not match", :aggregate_failures do
+      user.errors.add(:password_confirmation, "doesn't match Password")
+      render
+      expect(rendered).to have_selector("#error_explanation.alert")
+      expect(rendered).to have_text("doesn't match Password")
+    end
+  end
+end