Skip to content

Commit 4f68eb6

Browse files
authored
[5894] Fix VolunteersController#edit N+1 issues (#6068)
fix n+1 queries
1 parent 52cdb80 commit 4f68eb6

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

app/helpers/ui_helper.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@ def grouped_options_for_assigning_case(volunteer)
55
[
66
[
77
"Not Assigned",
8-
CasaCase
8+
CasaCase.eager_load([:assigned_volunteers])
99
.not_assigned(@volunteer.casa_org).active
1010
.uniq { |casa_case| casa_case.case_number }
1111
.map { |casa_case| ["#{casa_case.case_number} - #{volunteer_badge(casa_case, current_user)}".html_safe, casa_case.id] }
1212
],
1313
[
1414
"Assigned",
15-
CasaCase
15+
CasaCase.eager_load([:assigned_volunteers])
1616
.actively_assigned_excluding_volunteer(@volunteer)
1717
.uniq { |casa_case| casa_case.case_number }
1818
.map { |casa_case| ["#{casa_case.case_number} - #{volunteer_badge(casa_case, current_user)}".html_safe, casa_case.id] }

app/models/volunteer.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ def deactivate
9797
end
9898

9999
def case_assignments_with_cases
100-
case_assignments.includes(:casa_case)
100+
case_assignments.includes(casa_case: :assigned_volunteers)
101101
end
102102

103103
def has_supervisor?

0 commit comments

Comments
 (0)