Skip to content

Commit 5adf236

Browse files
authored
Merge pull request #6104 from FireLemons/upgrade_node_version
Add comment about why install is different from the others
2 parents 2e31998 + fbdd577 commit 5adf236

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ RUN apk update && apk upgrade && apk add --update --no-cache \
2525
postgresql-client \
2626
tzdata \
2727
vim && rm -rf /var/cache/apk/*
28+
# The ruby alpine image's apk doesn't have the current version of node
2829
RUN apk add --no-cache --repository http://dl-cdn.alpinelinux.org/alpine/edge/main/ nodejs=22.11.0-r0 npm
2930

3031
WORKDIR $RAILS_ROOT

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ The complete [role description of a CASA volunteer](https://pgcasa.org/volunteer
107107

108108
**node.js**
109109
1. (Recommended) Install [nvm](https://github.com/nvm-sh/nvm#installing-and-updating), which is a **n**ode **v**ersion **m**anager.
110-
- If you use asdf, the node version from `.tool-versions` will be used, but may be out of sync with the codename version (lts/iron) in `.nvmrc`. To use the version from `.nvmrc`, see one of these options: [legacy file codename support](https://github.com/asdf-vm/asdf-nodejs?tab=readme-ov-file#partial-and-codename-versions) or [installing via custom script](https://github.com/asdf-vm/asdf-nodejs/issues/382#issuecomment-2258647554).
110+
- If you use asdf, the node version from `.tool-versions` will be used, but may be out of sync with the codename version in `.nvmrc`. To use the version from `.nvmrc`, see one of these options: [legacy file codename support](https://github.com/asdf-vm/asdf-nodejs?tab=readme-ov-file#partial-and-codename-versions) or [installing via custom script](https://github.com/asdf-vm/asdf-nodejs/issues/382#issuecomment-2258647554).
111111
1. Install a current LTS version of Node. Running `nvm install` from this directory will read the `.nvmrc` file to install the correct version.
112112
1. Install [yarn](https://classic.yarnpkg.com/en/docs/install). On Ubuntu, [make sure you install it from the official Yarn repo instead of cmdtest](https://classic.yarnpkg.com/en/docs/install/#debian-stable).
113113

0 commit comments

Comments
 (0)