Check for page assertions before DB checks

Also, check for what the user sees in the page.

Author: stefannibrasil

spec/system/volunteers/invite_spec.rb

@@ -16,9 +16,9 @@
       fill_in "Display name", with: "Jane Doe"
       fill_in "Date of birth", with: Date.new(1995, 5, 15)
 
-      expect {
-        click_on "Create Volunteer"
-      }.to change(Volunteer, :count).by(1)
+      click_on "Create Volunteer"
+
+      expect(page).to have_selector(".notice", text: "New volunteer created successfully")
 
       volunteer = Volunteer.find_by(email: "new_volunteer@example.com")
       expect(volunteer).to be_present
@@ -41,6 +41,8 @@
 
       click_on "Create Volunteer"
 
+      expect(page).to have_selector(".notice", text: "New volunteer created successfully")
+
       volunteer = Volunteer.find_by(email: "volunteer_with_token@example.com")
       expect(volunteer.invitation_created_at).to be_present
       expect(volunteer.invitation_accepted_at).to be_nil
@@ -77,11 +79,11 @@
 
       click_on "Set my password"
 
+      expect(page).to have_selector(".notice", text: "Your password was set successfully. You are now signed in")
+      expect(page).to have_text("My Cases")
+
       volunteer.reload
       expect(volunteer.invitation_accepted_at).not_to be_nil
-
-      # Should be redirected to dashboard after accepting invitation
-      expect(page).to have_text("My Cases")
     end
 
     it "shows error when passwords don't match" do
@@ -137,9 +139,7 @@
     it "allows admin to resend invitation to volunteer who hasn't accepted" do
       visit edit_volunteer_path(volunteer)
 
-      expect {
-        click_on "Resend Invitation"
-      }.to change { ActionMailer::Base.deliveries.count }.by(1)
+      click_on "Resend Invitation"
 
       expect(page).to have_text "Invitation sent"
 
@@ -172,9 +172,9 @@
       fill_in "Display name", with: "Supervisor's Volunteer"
       fill_in "Date of birth", with: Date.new(1992, 3, 20)
 
-      expect {
-        click_on "Create Volunteer"
-      }.to change(Volunteer, :count).by(1)
+      click_on "Create Volunteer"
+
+      expect(page).to have_selector(".notice", text: "New volunteer created successfully")
 
       volunteer = Volunteer.find_by(email: "supervisor_volunteer@example.com")
       expect(volunteer).to be_present