Merge pull request #6614 from rubyforgood/fix-bugsnag

fix: Prevent uniqueness validation error when updating case contact t…

Author: compwron

app/controllers/case_contacts/form_controller.rb

@@ -165,7 +165,7 @@ def case_contact_params
   # Deletes the current associations (from the join table) only if the submitted form body has the parameters for
   # the contact_type ids.
   def remove_unwanted_contact_types
-    @case_contact.contact_types.clear if params.dig(:case_contact, :contact_type_ids)
+    @case_contact.case_contact_contact_types.destroy_all if params.dig(:case_contact, :contact_type_ids)
   end
 
   def remove_nil_draft_ids

spec/requests/case_contacts/form_spec.rb

@@ -234,6 +234,19 @@
         case_contact.reload
         expect(case_contact.contact_type_ids).to contain_exactly(contact_types.first.id)
       end
+
+      it "allows re-assigning the same contact type without uniqueness validation error" do
+        # This test prevents regression of Bugsnag error:
+        # "Validation failed: Case contact has already been taken"
+        case_contact.update!(contact_type_ids: [contact_types.first.id])
+        expect(case_contact.contact_type_ids).to contain_exactly(contact_types.first.id)
+
+        # Re-submit form with same contact type (simulates user editing and saving)
+        request
+
+        case_contact.reload
+        expect(case_contact.contact_type_ids).to contain_exactly(contact_types.first.id)
+      end
     end
 
     context "when contact topic answers in params" do