Merge pull request #6284 from piyush828-design/6821_no_validation_for_email

BUG: no validation for email in new fund request form

Author: compwron

app/models/fund_request.rb

@@ -1,4 +1,5 @@
 class FundRequest < ApplicationRecord
+  validates :submitter_email, presence: true
 end
 
 # == Schema Information

app/views/fund_requests/new.html.erb

@@ -11,9 +11,16 @@
 <!-- ========== card start ========== -->
 <div class="card-style mb-50">
   <%= form_with(model: @fund_request, local: true, url: casa_case_fund_request_path(@casa_case), method: :post) do |form| %>
+
+    <% if @fund_request.errors.any? %>
+      <% @fund_request.errors.full_messages.each do |msg| %>
+        <p><%= msg %></p>
+      <% end %>
+    <% end %>
+
     <div class="input-style-1">
-      <%= form.label :submitter_email, "Your email" %>
-      <%= form.text_field :submitter_email, class: "form-control", required: true, value: current_user.email %>
+    <%= form.label :submitter_email, "Your email" %>
+      <%= form.email_field :submitter_email, class: "form-control", required: false, value: current_user.email %>
     </div>
 
     <div class="input-style-1">

spec/models/fund_request_spec.rb

@@ -0,0 +1,5 @@
+require "rails_helper"
+
+RSpec.describe FundRequest, type: :model do
+  it { is_expected.to validate_presence_of(:submitter_email) }
+end

spec/system/casa_cases/fund_requests/new_spec.rb

@@ -1,14 +1,16 @@
 require "rails_helper"
 
-RSpec.describe "casa_cases/fund_requests/new", type: :system do
-  it "creates a fund request for the casa case" do
-    org = create(:casa_org)
-    volunteer = create(:volunteer, :with_casa_cases, casa_org: org)
-    casa_case = volunteer.casa_cases.first
+RSpec.describe "fund_requests/new", type: :system do
+  let(:org) { create(:casa_org) }
+  let(:volunteer) { create(:volunteer, :with_casa_cases, casa_org: org) }
+  let(:casa_case) { volunteer.casa_cases.first }
 
+  before do
     sign_in volunteer
     visit new_casa_case_fund_request_path(casa_case)
+  end
 
+  it "creates a fund request for the casa case" do
     aggregate_failures do
       expect(page).to have_field "Your email", with: volunteer.email
       expect(page).to have_field "Name or case number of youth", with: casa_case.case_number
@@ -43,4 +45,18 @@
       expect(fr.youth_name).to eq casa_case.case_number
     end
   end
+
+  it "shows error when submitter email is blank" do
+    fill_in "Your email", with: ""
+    fill_in "Amount of payment", with: "100"
+    fill_in "Deadline", with: "2022-12-31"
+    fill_in "Request is for", with: "Fun outing"
+    fill_in "Name of payee", with: "Minnie Mouse"
+
+    expect {
+      click_on "Submit Fund Request"
+    }.not_to change(FundRequest, :count)
+
+    expect(page).to have_content("Submitter email can't be blank")
+  end
 end