refactor:linter issue fix

Author: aakashnepal77

app/controllers/application_controller.rb

@@ -70,7 +70,7 @@ def handle_short_url(url_list)
   # volunteer/supervisor/casa_admin controller uses to send SMS
   # returns appropriate flash notice for SMS
   def deliver_sms_to(resource, body_msg)
-    return 'blank' if resource.phone_number.blank? || !resource.casa_org.twilio_enabled?
+    return "blank" if resource.phone_number.blank? || !resource.casa_org.twilio_enabled?
 
     body = body_msg
     to = resource.phone_number
@@ -85,30 +85,30 @@ def deliver_sms_to(resource, body_msg)
 
     begin
       twilio_res = @twilio.send_sms(req_params)
-      twilio_res.error_code.nil? ? 'sent' : 'error'
+      twilio_res.error_code.nil? ? "sent" : "error"
     rescue Twilio::REST::RestError => e
       @error = e
-      'error'
-    rescue StandardError # unverfied error isnt picked up by Twilio::Rest::RestError
+      "error"
+    rescue # unverfied error isnt picked up by Twilio::Rest::RestError
       # https://www.twilio.com/docs/errors/21608
-      @error = 'Phone number is unverifiied'
-      'error'
+      @error = "Phone number is unverifiied"
+      "error"
     end
   end
 
   def sms_acct_creation_notice(resource_name, sms_status)
     case sms_status
-    when 'blank'
+    when "blank"
       "New #{resource_name} created successfully."
-    when 'error'
+    when "error"
       "New #{resource_name} created successfully. SMS not sent. Error: #{@error}."
-    when 'sent'
+    when "sent"
       "New #{resource_name} created successfully. SMS has been sent!"
     end
   end
 
   def store_referring_location
-    return unless request.referer && !request.referer.end_with?('users/sign_in') && params[:ignore_referer].blank?
+    return unless request.referer && !request.referer.end_with?("users/sign_in") && params[:ignore_referer].blank?
 
     session[:return_to] = request.referer
   end
@@ -149,10 +149,10 @@ def set_current_organization
   end
 
   def not_authorized
-    message = 'Sorry, you are not authorized to perform this action.'
+    message = "Sorry, you are not authorized to perform this action."
     respond_to do |format|
       format.json do
-        render json: { error: message }, status: :unauthorized
+        render json: {error: message}, status: :unauthorized
       end
       format.any do
         session[:user_return_to] = nil
@@ -165,10 +165,10 @@ def not_authorized
   def unsupported_media_type
     respond_to do |format|
       format.json do
-        render json: { error: 'json unsupported' }, status: :unsupported_media_type
+        render json: {error: "json unsupported"}, status: :unsupported_media_type
       end
       format.any do
-        flash[:alert] = 'Page not found'
+        flash[:alert] = "Page not found"
         redirect_back_or_to root_url
       end
     end
@@ -181,7 +181,7 @@ def log_and_reraise(error)
 
   def check_unconfirmed_email_notice(user)
     notice = "#{user.role} was successfully updated."
-    notice += ' Confirmation Email Sent.' if user.saved_changes.include?('unconfirmed_email')
+    notice += " Confirmation Email Sent." if user.saved_changes.include?("unconfirmed_email")
     notice
   end
 end

spec/policies/custom_link_policy.rb

@@ -1,4 +1,4 @@
-require 'rails_helper'
+require "rails_helper"
 
 RSpec.describe CustomLinkPolicy do
   subject { described_class }
@@ -11,24 +11,24 @@
   let(:casa_admin) { create :casa_admin, casa_org: organization }
   let(:all_casa_admin) { create :all_casa_admin }
   let(:custom_link) { create(:custom_link, casa_org: organization) }
-  let(:valid_attributes) { { text: 'Link Text', url: 'http://example.com', active: true, casa_org: organization } }
-  let(:invalid_attributes) { { text: '', url: 'invalid', active: nil } }
+  let(:valid_attributes) { {text: "Link Text", url: "http://example.com", active: true, casa_org: organization} }
+  let(:invalid_attributes) { {text: "", url: "invalid", active: nil} }
   let(:other_org_admin) { create(:casa_admin) }
 
   permissions :create?, :edit?, :new?, :show?, :update? do
-    it 'allows same org casa_admins' do
+    it "allows same org casa_admins" do
       expect(subject).to permit(casa_admin, custom_link)
     end
 
-    it 'does not allow different org casa_admins' do
+    it "does not allow different org casa_admins" do
       expect(subject).not_to permit(other_org_admin, custom_link)
     end
 
-    it 'does not permit supervisor' do
+    it "does not permit supervisor" do
       expect(subject).not_to permit(supervisor, custom_link)
     end
 
-    it 'does not permit volunteer' do
+    it "does not permit volunteer" do
       expect(subject).not_to permit(volunteer, custom_link)
     end
   end

spec/requests/custom_links_spec.rb

@@ -1,11 +1,11 @@
-require 'rails_helper'
+require "rails_helper"
 
 RSpec.describe CustomLinksController, type: :request do
   let(:user) { create(:user) }
   let(:admin) { create(:casa_admin, casa_org: user.casa_org) }
   let(:custom_link) { create(:custom_link, casa_org_id: user.casa_org_id) }
-  let(:valid_attributes) { { text: 'Link Text', url: 'http://example.com', active: true, casa_org_id: user.casa_org_id } }
-  let(:invalid_attributes) { { text: '', url: 'invalid', active: nil } }
+  let(:valid_attributes) { {text: "Link Text", url: "http://example.com", active: true, casa_org_id: user.casa_org_id} }
+  let(:invalid_attributes) { {text: "", url: "invalid", active: nil} }
 
   before do
     sign_in user
@@ -16,134 +16,134 @@
     allow_any_instance_of(CustomLinkPolicy).to receive(:destroy?).and_return(true)
   end
 
-  describe 'GET #new' do
-    it 'authorizes the action' do
-      expect_any_instance_of(CustomLinkPolicy).to receive(:new?).and_return(true)
+  describe "GET #new" do
+    it "authorizes the action" do
+      allow_any_instance_of(CustomLinkPolicy).to receive(:new?).and_return(true)
       get new_custom_link_path
     end
 
-    it 'assigns a new CustomLink with the current user\'s casa_org_id to @custom_link' do
+    it "assigns a new CustomLink with the current user's casa_org_id to @custom_link" do
       get new_custom_link_path
       expect(assigns(:custom_link)).to be_a_new(CustomLink)
       expect(assigns(:custom_link).casa_org_id).to eq(user.casa_org_id)
     end
 
-    it 'renders the new template' do
+    it "renders the new template" do
       get new_custom_link_path
       expect(response).to render_template(:new)
     end
   end
 
-  describe 'GET #edit' do
-    it 'assigns the requested custom_link as @custom_link' do
+  describe "GET #edit" do
+    it "assigns the requested custom_link as @custom_link" do
       get edit_custom_link_path(custom_link)
       expect(assigns(:custom_link)).to eq(custom_link)
     end
 
-    it 'authorizes the action' do
-      expect_any_instance_of(CustomLinkPolicy).to receive(:edit?).and_return(true)
+    it "authorizes the action" do
+      allow_any_instance_of(CustomLinkPolicy).to receive(:edit?).and_return(true)
       get edit_custom_link_path(custom_link)
     end
   end
 
-  describe 'POST #create' do
-    context 'with valid parameters' do
-      it 'creates a new CustomLink' do
+  describe "POST #create" do
+    context "with valid parameters" do
+      it "creates a new CustomLink" do
         expect do
-          post custom_links_path, params: { custom_link: valid_attributes }
+          post custom_links_path, params: {custom_link: valid_attributes}
         end.to change(CustomLink, :count).by(1)
       end
 
-      it 'redirects to the edit_casa_org_path' do
-        post custom_links_path, params: { custom_link: valid_attributes }
+      it "redirects to the edit_casa_org_path" do
+        post custom_links_path, params: {custom_link: valid_attributes}
         expect(response).to redirect_to(edit_casa_org_path(user.casa_org))
       end
 
-      it 'sets a success notice' do
-        post custom_links_path, params: { custom_link: valid_attributes }
-        expect(flash[:notice]).to eq('Custom link was successfully created.')
+      it "sets a success notice" do
+        post custom_links_path, params: {custom_link: valid_attributes}
+        expect(flash[:notice]).to eq("Custom link was successfully created.")
       end
 
-      it 'authorizes the action' do
-        expect_any_instance_of(CustomLinkPolicy).to receive(:create?).and_return(true)
-        post custom_links_path, params: { custom_link: valid_attributes }
+      it "authorizes the action" do
+        allow_any_instance_of(CustomLinkPolicy).to receive(:create?).and_return(true)
+        post custom_links_path, params: {custom_link: valid_attributes}
       end
     end
 
-    context 'with invalid parameters' do
-      it 'does not create a new CustomLink' do
+    context "with invalid parameters" do
+      it "does not create a new CustomLink" do
         expect do
-          post custom_links_path, params: { custom_link: invalid_attributes }
-        end.to change(CustomLink, :count).by(0)
+          post custom_links_path, params: {custom_link: invalid_attributes}
+        end.not_to change(CustomLink, :count)
       end
 
-      it 'renders the new template' do
-        post custom_links_path, params: { custom_link: invalid_attributes }
+      it "renders the new template" do
+        post custom_links_path, params: {custom_link: invalid_attributes}
         expect(response).to render_template(:new)
       end
     end
   end
 
-  describe 'PATCH/PUT #update' do
-    context 'with valid parameters' do
-      let(:new_attributes) { { text: 'Updated Text', url: 'http://updated.com' } }
+  describe "PATCH/PUT #update" do
+    context "with valid parameters" do
+      let(:new_attributes) { {text: "Updated Text", url: "http://updated.com"} }
 
-      it 'updates the requested custom_link' do
-        patch custom_link_path(custom_link), params: { custom_link: new_attributes }
+      it "updates the requested custom_link" do
+        patch custom_link_path(custom_link), params: {custom_link: new_attributes}
         custom_link.reload
-        expect(custom_link.text).to eq('Updated Text')
+        expect(custom_link.text).to eq("Updated Text")
       end
 
-      it 'redirects to the edit_casa_org_path' do
-        patch custom_link_path(custom_link), params: { custom_link: new_attributes }
+      it "redirects to the edit_casa_org_path" do
+        patch custom_link_path(custom_link), params: {custom_link: new_attributes}
         expect(response).to redirect_to(edit_casa_org_path(user.casa_org))
       end
 
-      it 'sets a success notice' do
-        patch custom_link_path(custom_link), params: { custom_link: new_attributes }
-        expect(flash[:notice]).to eq('Custom link was successfully updated.')
+      it "sets a success notice" do
+        patch custom_link_path(custom_link), params: {custom_link: new_attributes}
+        expect(flash[:notice]).to eq("Custom link was successfully updated.")
       end
 
-      it 'authorizes the action' do
-        expect_any_instance_of(CustomLinkPolicy).to receive(:update?).and_return(true)
-        patch custom_link_path(custom_link), params: { custom_link: new_attributes }
+      it "authorizes the action" do
+        allow_any_instance_of(CustomLinkPolicy).to receive(:update?).and_return(true)
+        patch custom_link_path(custom_link), params: {custom_link: new_attributes}
       end
     end
 
-    context 'with invalid parameters' do
-      it 'does not update the requested custom_link' do
-        patch custom_link_path(custom_link), params: { custom_link: invalid_attributes }
+    context "with invalid parameters" do
+      it "does not update the requested custom_link" do
+        patch custom_link_path(custom_link), params: {custom_link: invalid_attributes}
         custom_link.reload
         expect(custom_link.text).not_to be_empty
       end
 
-      it 'renders the edit template' do
-        patch custom_link_path(custom_link), params: { custom_link: invalid_attributes }
+      it "renders the edit template" do
+        patch custom_link_path(custom_link), params: {custom_link: invalid_attributes}
         expect(response).to render_template(:edit)
       end
     end
   end
 
-  describe 'DELETE #destroy' do
-    it 'destroys the requested custom_link' do
+  describe "DELETE #destroy" do
+    it "destroys the requested custom_link" do
       custom_link
       expect do
         delete custom_link_path(custom_link)
       end.to change(CustomLink, :count).by(-1)
     end
 
-    it 'redirects to the edit_casa_org_path' do
+    it "redirects to the edit_casa_org_path" do
       delete custom_link_path(custom_link)
       expect(response).to redirect_to(edit_casa_org_path(user.casa_org))
     end
 
-    it 'sets a success notice' do
+    it "sets a success notice" do
       delete custom_link_path(custom_link)
-      expect(flash[:notice]).to eq('Custom link was successfully removed.')
+      expect(flash[:notice]).to eq("Custom link was successfully removed.")
     end
 
-    it 'authorizes the action' do
-      expect_any_instance_of(CustomLinkPolicy).to receive(:destroy?).and_return(true)
+    it "authorizes the action" do
+      allow_any_instance_of(CustomLinkPolicy).to receive(:destroy?).and_return(true)
       delete custom_link_path(custom_link)
     end
   end