Merge pull request #6526 from tacoda/add-new-case-contact-table-feature-flag

Add new_case_contact_table feature flag

Author: compwron

app/controllers/case_contacts/case_contacts_new_design_controller.rb

@@ -1,5 +1,6 @@
 class CaseContacts::CaseContactsNewDesignController < ApplicationController
   include LoadsCaseContacts
+  before_action :check_feature_flag
 
   def index
     load_case_contacts
@@ -12,4 +13,12 @@ def datatable
 
     render json: datatable
   end
+
+  private
+
+  def check_feature_flag
+    unless Flipper.enabled?(:new_case_contact_table)
+      redirect_to case_contacts_path, alert: "This feature is not available."
+    end
+  end
 end

config/routes.rb

@@ -92,6 +92,8 @@
 
   get "case_contacts/leave", to: "case_contacts#leave", as: "leave_case_contacts_form"
   get "case_contacts/drafts", to: "case_contacts#drafts"
+
+  # Feature flag for new case contact table design
   get "case_contacts/new_design", to: "case_contacts/case_contacts_new_design#index"
   resources :case_contacts, except: %i[create update show], concerns: %i[with_datatable] do
     member do

spec/controllers/concerns/loads_case_contacts_spec.rb

@@ -12,4 +12,37 @@
     expect(host.private_instance_methods)
       .to include(:load_case_contacts, :current_organization_groups, :all_case_contacts)
   end
+
+  describe "integration with Flipper flags", type: :request do
+    let(:organization) { create(:casa_org) }
+    let(:admin) { create(:casa_admin, casa_org: organization) }
+    let!(:casa_case) { create(:casa_case, casa_org: organization) }
+    let!(:case_contact) { create(:case_contact, :active, casa_case: casa_case) }
+
+    before { sign_in admin }
+
+    context "when new_case_contact_table flag is enabled" do
+      before do
+        allow(Flipper).to receive(:enabled?).with(:new_case_contact_table).and_return(true)
+      end
+
+      it "loads case contacts successfully through the new design controller" do
+        get case_contacts_new_design_path
+        expect(response).to have_http_status(:success)
+        expect(assigns(:filtered_case_contacts)).to be_present
+      end
+    end
+
+    context "when new_case_contact_table flag is disabled" do
+      before do
+        allow(Flipper).to receive(:enabled?).with(:new_case_contact_table).and_return(false)
+      end
+
+      it "does not load case contacts and redirects instead" do
+        get case_contacts_new_design_path
+        expect(response).to redirect_to(case_contacts_path)
+        expect(assigns(:filtered_case_contacts)).to be_nil
+      end
+    end
+  end
 end

spec/requests/case_contacts/case_contacts_new_design_spec.rb

@@ -6,38 +6,62 @@
 
   before { sign_in admin }
 
-  describe "GET /index" do
-    subject(:request) do
-      get case_contacts_new_design_path
-
-      response
+  context "when new_case_contact_table flag is disabled" do
+    before do
+      allow(Flipper).to receive(:enabled?).with(:new_case_contact_table).and_return(false)
     end
 
-    let!(:casa_case) { create(:casa_case, casa_org: organization) }
-    let!(:past_contact) { create(:case_contact, :active, casa_case: casa_case, occurred_at: 3.weeks.ago) }
-    let!(:recent_contact) { create(:case_contact, :active, casa_case: casa_case, occurred_at: 3.days.ago) }
-    let!(:draft_contact) { create(:case_contact, casa_case: casa_case, occurred_at: 5.days.ago, status: "started") }
-
-    it { is_expected.to have_http_status(:success) }
+    describe "GET /index" do
+      it "redirects to case_contacts_path" do
+        get case_contacts_new_design_path
+        expect(response).to redirect_to(case_contacts_path)
+      end
 
-    it "lists exactly two active contacts and one draft" do
-      doc = Nokogiri::HTML(request.body)
-      case_contact_rows = doc.css('[data-testid="case_contact-row"]')
-      expect(case_contact_rows.size).to eq(3)
+      it "sets an alert message" do
+        get case_contacts_new_design_path
+        expect(flash[:alert]).to eq("This feature is not available.")
+      end
     end
+  end
 
-    it "shows the draft badge exactly once" do
-      doc = Nokogiri::HTML(request.body)
-      expect(doc.css('[data-testid="draft-badge"]').count).to eq(1)
+  context "when new_case_contact_table flag is enabled" do
+    before do
+      allow(Flipper).to receive(:enabled?).with(:new_case_contact_table).and_return(true)
     end
 
-    it "orders contacts by occurred_at desc" do
-      body = request.body
+    describe "GET /index" do
+      subject(:request) do
+        get case_contacts_new_design_path
+
+        response
+      end
+
+      let!(:casa_case) { create(:casa_case, casa_org: organization) }
+      let!(:past_contact) { create(:case_contact, :active, casa_case: casa_case, occurred_at: 3.weeks.ago) }
+      let!(:recent_contact) { create(:case_contact, :active, casa_case: casa_case, occurred_at: 3.days.ago) }
+      let!(:draft_contact) { create(:case_contact, casa_case: casa_case, occurred_at: 5.days.ago, status: "started") }
+
+      it { is_expected.to have_http_status(:success) }
+
+      it "lists exactly two active contacts and one draft" do
+        doc = Nokogiri::HTML(request.body)
+        case_contact_rows = doc.css('[data-testid="case_contact-row"]')
+        expect(case_contact_rows.size).to eq(3)
+      end
+
+      it "shows the draft badge exactly once" do
+        doc = Nokogiri::HTML(request.body)
+        expect(doc.css('[data-testid="draft-badge"]').count).to eq(1)
+      end
+
+      it "orders contacts by occurred_at desc" do
+        body = request.body
 
-      recent_index = body.index(I18n.l(recent_contact.occurred_at, format: :full))
-      past_index = body.index(I18n.l(past_contact.occurred_at, format: :full))
+        recent_index = body.index(I18n.l(recent_contact.occurred_at, format: :full))
+        past_index = body.index(I18n.l(past_contact.occurred_at, format: :full))
 
-      expect(recent_index).to be < past_index
+        expect(recent_index).to be < past_index
+      end
     end
   end
 end