feature(user): improved email already taken message for more clarity message

Author: Raushan Kumar Raman

app/validators/user_validator.rb

@@ -8,6 +8,7 @@ def validate(record)
     valid_phone_number_if_receive_sms_notifications(record)
     validate_date_of_birth_in_past(record.date_of_birth, record)
     validate_date_of_birth_not_before_1920(record.date_of_birth, record)
+    validate_unique_email(record)
   end
 
   private
@@ -50,4 +51,10 @@ def validate_date_of_birth_not_before_1920(date_of_birth, record)
 
     record.errors.add(:base, " Date of birth must be on or after 1/1/1920.") unless date_of_birth >= "1920-01-01".to_date
   end
+
+  def validate_unique_email(record)
+    if User.exists?(email: record.email)
+      record.errors.add(:base, I18n.t('activerecord.errors.messages.email_uniqueness'))
+    end
+  end
 end

config/locales/en.yml

@@ -60,6 +60,7 @@ en:
         cant_be_future: can't be in the future
         must_be_selected: must be selected
         must_be_true_or_false: must be true or false
+        email_uniqueness: This email is already in use. If it does not appear on your roster, it may be associated with another CASA organization. Please use a different email address.
   time:
     formats:
       day_and_date: "%A, %b %d, %Y"

spec/models/user_spec.rb

@@ -55,6 +55,13 @@
       expect(user.errors[:base]).to eq([" Date of birth must be on or after 1/1/1920."])
     end
 
+    it 'shows custom email uniqueness error message' do
+      create(:user, email: "[email protected]")
+      user = build(:user, email: '[email protected]')
+      expect(user.valid?).to be false
+      expect(user.errors[:base]).to eq ([I18n.t('activerecord.errors.messages.email_uniqueness')])
+    end
+
     it "has an empty old_emails array when initialized" do
       user = build(:user)
       expect(user.old_emails).to eq([])