disable NamedSubject, LeadingSubject, NotToNot

Author: thejonroberts

.rubocop.yml

@@ -118,6 +118,10 @@ RSpec/ExampleLength:
   Exclude:
     - 'spec/system/**/*'
 
+RSpec/LeadingSubject:
+  # Too many existing examples, style preference only
+  Enabled: false
+
 RSpec/LetSetup:
   # Only here for the extra details as let! use is extremely common... counter-examples? not so common!
   Details: |-
@@ -149,5 +153,13 @@ RSpec/MultipleExpectations:
 RSpec/MultipleMemoizedHelpers:
   Max: 20
 
+RSpec/NamedSubject:
+  # Too many existing examples for a slight gain in readability
+  Enabled: false
+
 RSpec/NestedGroups:
   Max: 5
+
+RSpec/NotToNot:
+  # consistency only, no difference between to_not/not_to
+  Enabled: false

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude --no-exclude-limit`
-# on 2024-10-26 02:55:00 UTC using RuboCop version 1.65.1.
+# on 2024-11-04 17:07:58 UTC using RuboCop version 1.65.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -869,43 +869,6 @@ RSpec/ItBehavesLike:
     - 'spec/system/casa_admins/edit_spec.rb'
     - 'spec/system/supervisors/edit_spec.rb'
 
-# Offense count: 59
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/LeadingSubject:
-  Exclude:
-    - 'spec/decorators/contact_type_decorator_spec.rb'
-    - 'spec/models/casa_case_spec.rb'
-    - 'spec/models/case_contact_report_spec.rb'
-    - 'spec/models/case_contact_spec.rb'
-    - 'spec/models/followup_spec.rb'
-    - 'spec/models/supervisor_spec.rb'
-    - 'spec/models/volunteer_spec.rb'
-    - 'spec/policies/additional_expense_policy_spec.rb'
-    - 'spec/policies/bulk_court_date_policy_spec.rb'
-    - 'spec/policies/case_group_policy_spec.rb'
-    - 'spec/policies/contact_topic_answer_policy_spec.rb'
-    - 'spec/policies/patch_note_policy_spec.rb'
-    - 'spec/requests/additional_expenses_spec.rb'
-    - 'spec/requests/all_casa_admins/casa_orgs_spec.rb'
-    - 'spec/requests/all_casa_admins/dashboard_spec.rb'
-    - 'spec/requests/all_casa_admins/sessions_spec.rb'
-    - 'spec/requests/bulk_court_dates_spec.rb'
-    - 'spec/requests/casa_org_spec.rb'
-    - 'spec/requests/case_assignments_spec.rb'
-    - 'spec/requests/case_contacts/followups_spec.rb'
-    - 'spec/requests/case_contacts/form_spec.rb'
-    - 'spec/requests/case_contacts_spec.rb'
-    - 'spec/requests/case_court_reports_spec.rb'
-    - 'spec/requests/case_groups_spec.rb'
-    - 'spec/requests/contact_topic_answers_spec.rb'
-    - 'spec/requests/emancipations_request_spec.rb'
-    - 'spec/requests/mileage_rates_spec.rb'
-    - 'spec/requests/supervisor_volunteers_spec.rb'
-    - 'spec/system/case_contacts/additional_expenses_spec.rb'
-    - 'spec/system/case_contacts/contact_topic_answers_spec.rb'
-    - 'spec/system/case_contacts/index_spec.rb'
-    - 'spec/system/case_contacts/new_spec.rb'
-
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AutoCorrect.
@@ -1093,59 +1056,6 @@ RSpec/MultipleMemoizedHelpers:
     - 'spec/requests/case_contacts/form_spec.rb'
     - 'spec/system/supervisors/index_spec.rb'
 
-# Offense count: 321
-# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
-# SupportedStyles: always, named_only
-RSpec/NamedSubject:
-  Exclude:
-    - 'spec/datatables/supervisor_datatable_spec.rb'
-    - 'spec/datatables/volunteer_datatable_spec.rb'
-    - 'spec/decorators/contact_type_decorator_spec.rb'
-    - 'spec/helpers/court_dates_helper_spec.rb'
-    - 'spec/lib/tasks/supervisor_weekly_digest_spec.rb'
-    - 'spec/models/all_casa_admins/casa_org_metrics_spec.rb'
-    - 'spec/models/casa_admin_spec.rb'
-    - 'spec/models/case_contact_report_spec.rb'
-    - 'spec/models/case_contact_spec.rb'
-    - 'spec/models/case_court_report_spec.rb'
-    - 'spec/models/contact_type_group_spec.rb'
-    - 'spec/models/contact_type_spec.rb'
-    - 'spec/models/court_date_spec.rb'
-    - 'spec/models/followup_spec.rb'
-    - 'spec/models/supervisor_spec.rb'
-    - 'spec/models/volunteer_spec.rb'
-    - 'spec/policies/application_policy_spec.rb'
-    - 'spec/policies/casa_case_policy_spec.rb'
-    - 'spec/policies/court_date_policy_spec.rb'
-    - 'spec/policies/placement_policy_spec.rb'
-    - 'spec/requests/additional_expenses_spec.rb'
-    - 'spec/requests/all_casa_admins/casa_admins_spec.rb'
-    - 'spec/requests/all_casa_admins_spec.rb'
-    - 'spec/requests/banners_spec.rb'
-    - 'spec/requests/bulk_court_dates_spec.rb'
-    - 'spec/requests/case_groups_spec.rb'
-    - 'spec/requests/contact_topic_answers_spec.rb'
-    - 'spec/requests/preference_sets_spec.rb'
-    - 'spec/requests/supervisor_volunteers_spec.rb'
-    - 'spec/requests/users_spec.rb'
-    - 'spec/requests/volunteers_spec.rb'
-    - 'spec/services/additional_expense_params_service_spec.rb'
-    - 'spec/services/casa_case_change_service_spec.rb'
-    - 'spec/services/case_contacts_contact_dates_spec.rb'
-    - 'spec/services/followup_export_csv_service_spec.rb'
-    - 'spec/services/inactive_messages_service_spec.rb'
-    - 'spec/services/mileage_export_csv_service_spec.rb'
-    - 'spec/services/preference_set_table_state_service_spec.rb'
-    - 'spec/system/case_contacts/additional_expenses_spec.rb'
-    - 'spec/system/case_contacts/contact_topic_answers_spec.rb'
-    - 'spec/system/case_contacts/index_spec.rb'
-    - 'spec/system/case_contacts/new_spec.rb'
-    - 'spec/values/banner_parameters_spec.rb'
-    - 'spec/values/case_contact_parameters_spec.rb'
-    - 'spec/values/volunteer_parameters_spec.rb'
-    - 'spec/views/layouts/application.html.erb_spec.rb'
-    - 'spec/views/volunteers/index.html.erb_spec.rb'
-
 # Offense count: 10
 # Configuration parameters: Max, AllowedGroups.
 RSpec/NestedGroups:
@@ -1162,100 +1072,6 @@ RSpec/NoExpectationExample:
     - 'spec/system/casa_org/edit_spec.rb'
     - 'spec/system/supervisors/edit_spec.rb'
 
-# Offense count: 254
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: not_to, to_not
-RSpec/NotToNot:
-  Exclude:
-    - 'spec/components/modal/header_component_spec.rb'
-    - 'spec/components/modal/open_button_component_spec.rb'
-    - 'spec/components/modal/open_link_component_spec.rb'
-    - 'spec/components/truncated_text_component_spec.rb'
-    - 'spec/config/initializers/rack_attack_spec.rb'
-    - 'spec/helpers/notifications_helper_spec.rb'
-    - 'spec/lib/importers/case_importer_spec.rb'
-    - 'spec/lib/importers/supervisor_importer_spec.rb'
-    - 'spec/lib/importers/volunteer_importer_spec.rb'
-    - 'spec/mailers/casa_admin_mailer_spec.rb'
-    - 'spec/mailers/supervisor_mailer_spec.rb'
-    - 'spec/mailers/volunteer_mailer_spec.rb'
-    - 'spec/models/banner_spec.rb'
-    - 'spec/models/casa_org_spec.rb'
-    - 'spec/models/case_contact_spec.rb'
-    - 'spec/models/case_court_report_spec.rb'
-    - 'spec/models/case_group_spec.rb'
-    - 'spec/models/emancipation_option_spec.rb'
-    - 'spec/models/followup_spec.rb'
-    - 'spec/models/learning_hour_spec.rb'
-    - 'spec/models/learning_hour_topic_spec.rb'
-    - 'spec/models/learning_hour_type_spec.rb'
-    - 'spec/models/mileage_rate_spec.rb'
-    - 'spec/models/other_duty_spec.rb'
-    - 'spec/models/placement_spec.rb'
-    - 'spec/models/volunteer_spec.rb'
-    - 'spec/policies/application_policy_spec.rb'
-    - 'spec/policies/bulk_court_date_policy_spec.rb'
-    - 'spec/policies/casa_admin_policy_spec.rb'
-    - 'spec/policies/casa_case_policy_spec.rb'
-    - 'spec/policies/casa_org_policy_spec.rb'
-    - 'spec/policies/case_assignment_policy_spec.rb'
-    - 'spec/policies/checklist_item_policy_spec.rb'
-    - 'spec/policies/contact_topic_policy_spec.rb'
-    - 'spec/policies/contact_type_group_policy_spec.rb'
-    - 'spec/policies/contact_type_policy_spec.rb'
-    - 'spec/policies/hearing_type_policy_spec.rb'
-    - 'spec/policies/import_policy_spec.rb'
-    - 'spec/policies/judge_policy_spec.rb'
-    - 'spec/policies/notification_policy_spec.rb'
-    - 'spec/policies/reimbursement_policy_spec.rb'
-    - 'spec/policies/supervisor_policy_spec.rb'
-    - 'spec/policies/supervisor_volunteer_policy_spec.rb'
-    - 'spec/requests/all_casa_admins/patch_notes_spec.rb'
-    - 'spec/requests/all_casa_admins_spec.rb'
-    - 'spec/requests/casa_admins_spec.rb'
-    - 'spec/requests/case_court_reports_spec.rb'
-    - 'spec/requests/contact_topics_spec.rb'
-    - 'spec/requests/fund_requests_spec.rb'
-    - 'spec/requests/imports_spec.rb'
-    - 'spec/requests/mileage_rates_spec.rb'
-    - 'spec/requests/notes_spec.rb'
-    - 'spec/requests/notifications_spec.rb'
-    - 'spec/requests/other_duties_spec.rb'
-    - 'spec/requests/supervisors_spec.rb'
-    - 'spec/requests/users_spec.rb'
-    - 'spec/requests/volunteers_spec.rb'
-    - 'spec/services/backfill_followupable_service_spec.rb'
-    - 'spec/services/emancipation_checklist_reminder_service_spec.rb'
-    - 'spec/system/all_casa_admins/sessions/new_spec.rb'
-    - 'spec/system/banners/new_spec.rb'
-    - 'spec/system/casa_cases/additional_index_spec.rb'
-    - 'spec/system/casa_cases/edit_spec.rb'
-    - 'spec/system/casa_cases/show_spec.rb'
-    - 'spec/system/casa_org/edit_spec.rb'
-    - 'spec/system/case_contacts/drafts_spec.rb'
-    - 'spec/system/case_court_reports/index_spec.rb'
-    - 'spec/system/case_groups/case_groups_spec.rb'
-    - 'spec/system/devise/passwords/new_spec.rb'
-    - 'spec/system/emancipations/show_spec.rb'
-    - 'spec/system/other_duties/new_spec.rb'
-    - 'spec/system/reports/index_spec.rb'
-    - 'spec/system/sessions/new_spec.rb'
-    - 'spec/system/supervisors/edit_spec.rb'
-    - 'spec/system/volunteers/edit_spec.rb'
-    - 'spec/system/volunteers/new_spec.rb'
-    - 'spec/values/case_contact_parameters_spec.rb'
-    - 'spec/views/casa_cases/edit.html.erb_spec.rb'
-    - 'spec/views/casa_cases/index.html.erb_spec.rb'
-    - 'spec/views/casa_orgs/edit.html.erb_spec.rb'
-    - 'spec/views/case_contacts/case_contact.html.erb_spec.rb'
-    - 'spec/views/layouts/header.html.erb_spec.rb'
-    - 'spec/views/layouts/sidebar.html.erb_spec.rb'
-    - 'spec/views/supervisor_mailer/weekly_digest.html.erb_spec.rb'
-    - 'spec/views/supervisors/edit.html.erb_spec.rb'
-    - 'spec/views/supervisors/index.html.erb_spec.rb'
-    - 'spec/views/volunteers/edit.html.erb_spec.rb'
-
 # Offense count: 24
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Strict, EnforcedStyle, AllowedExplicitMatchers.