feat: Allow to cancel request when partner is deactivated

- modify RequestDestroyService to not return false on validation for deactivated partners
- add condition to not send email when partner is deactivated

Author: zanetagebka

app/services/request_destroy_service.rb

@@ -14,7 +14,9 @@ def call
     request.status = :discarded
     request.save!
 
-    RequestMailer.request_cancel_partner_notification(request_id: request.id).deliver_later
+    unless request.partner.deactivated?
+      RequestMailer.request_cancel_partner_notification(request_id: request.id).deliver_later
+    end
 
     self
   end
@@ -28,8 +30,6 @@ def valid?
       errors.add(:base, 'request_id is invalid')
     elsif request.discarded_at.present?
       errors.add(:base, 'request already discarded')
-    elsif request.partner.deactivated?
-      errors.add(:base, 'partner is deactivated')
     end
 
     errors.none?

spec/services/request_destroy_service_spec.rb

@@ -50,8 +50,13 @@
       let!(:partner) { create(:partner, status: 'deactivated') }
       let(:request) { create(:request, partner: partner) }
 
-      it 'should have errors' do
-        expect(subject.errors.full_messages).to eq(['partner is deactivated'])
+      it 'should update the status column on the request' do
+        expect { subject }.to change { request.reload.status_discarded? }.from(false).to(true)
+      end
+
+      it 'should not send a email notification to the partner' do
+        expect(RequestMailer).not_to receive(:request_cancel_partner_notification)
+        subject
       end
     end
   end