Merge pull request #5396 from brodyf42/5383_clean_up_partner_status_column_on_profile

[5383] Remove partner_status field from parnter_profiles table

Author: awwaiid

app/models/partners/profile.rb

@@ -37,7 +37,6 @@
 #  new_client_times               :string
 #  no_social_media_presence       :boolean
 #  other_agency_type              :string
-#  partner_status                 :string           default("pending")
 #  pick_up_email                  :string
 #  pick_up_name                   :string
 #  pick_up_phone                  :string

db/migrate/20250913173217_remove_partner_status_from_partner_profiles.rb

@@ -0,0 +1,5 @@
+class RemovePartnerStatusFromPartnerProfiles < ActiveRecord::Migration[8.0]
+  def change
+    safety_assured { remove_column :partner_profiles, :partner_status, :string }
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[8.0].define(version: 2025_08_11_094943) do
+ActiveRecord::Schema[8.0].define(version: 2025_09_13_173217) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "pg_catalog.plpgsql"
 
@@ -524,7 +524,6 @@
     t.bigint "essentials_bank_id"
     t.text "application_data"
     t.integer "partner_id"
-    t.string "partner_status", default: "pending"
     t.string "name"
     t.string "distributor_type"
     t.string "agency_type"

spec/factories/partners/profiles.rb

@@ -37,7 +37,6 @@
 #  new_client_times               :string
 #  no_social_media_presence       :boolean
 #  other_agency_type              :string
-#  partner_status                 :string           default("pending")
 #  pick_up_email                  :string
 #  pick_up_name                   :string
 #  pick_up_phone                  :string

spec/models/partners/profile_spec.rb

@@ -37,7 +37,6 @@
 #  new_client_times               :string
 #  no_social_media_presence       :boolean
 #  other_agency_type              :string
-#  partner_status                 :string           default("pending")
 #  pick_up_email                  :string
 #  pick_up_name                   :string
 #  pick_up_phone                  :string

spec/system/partners/approval_process_spec.rb

@@ -73,7 +73,7 @@
     let(:partner) { FactoryBot.create(:partner) }
 
     before do
-      partner.profile.update(website: '', facebook: '', twitter: '', instagram: '', no_social_media_presence: false, partner_status: 'pending')
+      partner.profile.update(website: '', facebook: '', twitter: '', instagram: '', no_social_media_presence: false)
       login_as(partner_user)
       visit partner_user_root_path
       click_on 'My Profile'