Skip to content

Commit 0ee1fc3

Browse files
authored
Expose the devcontainer database port (#5447)
* Expose the devcontainer database port This lets us use the docker compose file for local development even without the restu of the devcontainer stuff * Keep separate artifacts from parallel failing system specs
1 parent 8b487c2 commit 0ee1fc3

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

.devcontainer/docker-compose.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,7 @@ services:
2828
POSTGRES_USER: postgres
2929
POSTGRES_DB: postgres
3030
POSTGRES_PASSWORD: postgres
31-
# Note that these ports are ignored by the devcontainer.
32-
# Instead, the ports are specified in .devcontainer/devcontainer.json.
33-
# ports:
34-
# - "5432:5432"
31+
ports:
32+
- "5432:5432" # For non-devcontainer local usage
3533
volumes:
3634
postgres-data:

.github/workflows/rspec-system.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ jobs:
8686
if: ${{ failure() }}
8787
uses: actions/upload-artifact@v4
8888
with:
89-
name: failed-browser-tests
89+
name: failed-browser-tests-${{ matrix.ci_node_index }}
9090
path: |
9191
tmp/screenshots
9292
tmp/capybara

0 commit comments

Comments
 (0)