[5302] Conditionally Display Inactive Donation Sites on Edit (#5305)

* Conditionally display inactive donation sites in dropdown

* Preserve alphabetization of donation site list

* Move donations_controller_spec tests to donations_requests_spec

Author: juliannatetreault

app/controllers/donations_controller.rb

@@ -127,11 +127,12 @@ def destroy
 
   def load_form_collections
     @storage_locations = current_organization.storage_locations.active.alphabetized
-    @donation_sites = current_organization.donation_sites.active.alphabetized
     @product_drives = current_organization.product_drives.alphabetized
     @product_drive_participants = current_organization.product_drive_participants.alphabetized
     @manufacturers = current_organization.manufacturers.alphabetized
     @items = current_organization.items.active.alphabetized
+    # Return all active donation sites, or the donation site that was selected for the donation if it's inactive
+    @donation_sites = current_organization.donation_sites.active.or(DonationSite.where(id: @donation.donation_site_id)).alphabetized
   end
 
   def clean_donation_money_raised

spec/requests/donations_requests_spec.rb

@@ -100,6 +100,15 @@
       it "should include the storage location name" do
         expect(subject.body).to include("Pawane Location")
       end
+
+      context "when creating a new donation" do
+        let!(:inactive_donation_site) { create(:donation_site, organization: organization, active: false) }
+
+        it "does not include inactive donation sites" do
+          subject
+          expect(response.body).not_to include(inactive_donation_site.name)
+        end
+      end
     end
 
     describe "POST #create" do
@@ -265,6 +274,29 @@
           expect(response.body).to include("you’ll need to make an adjustment to the inventory as well.")
         end
       end
+
+      context "when editing a donation with an inactive donation site" do
+        let!(:active_donation_site) { create(:donation_site, organization: organization, name: "Active Donation Site") }
+        let!(:inactive_donation_site) { create(:donation_site, organization: organization, active: false, name: "Inactive Donation Site") }
+        let!(:donation_with_inactive_site) { create(:donation, organization: organization, donation_site: inactive_donation_site) }
+
+        it "includes the inactive donation site in the dropdown" do
+          get edit_donation_path(donation_with_inactive_site)
+          expect(response.body).to include(inactive_donation_site.name)
+        end
+
+        it "displays the donation site names alphabetically" do
+          get edit_donation_path(donation_with_inactive_site)
+
+          # Get all donation site names that should be in the dropdown and sort them
+          donation_sites = [active_donation_site, inactive_donation_site]
+          sorted_names = donation_sites.map(&:name).sort
+
+          # Verify that the donation sites are alphabetized
+          expect(sorted_names[0]).to eq(active_donation_site.name)
+          expect(sorted_names[1]).to eq(inactive_donation_site.name)
+        end
+      end
     end
 
     context "when an non-finalized audit has been performed on the donated items" do