Updated tests to look for buttons inside of forms instead of anchor elements

Benjamin-Couey · Benjamin-Couey · commit 1d25a825ea2a · 2025-08-31T08:08:26.000-07:00
diff --git a/spec/requests/admin/ndbn_members_spec.rb b/spec/requests/admin/ndbn_members_spec.rb
@@ -20,8 +20,10 @@
       html = Nokogiri::HTML(response.body)
 
       expect(html.css("h1").text).to eq("NDBN Member Upload")
-      expect(html.css("input[type=file]").count).to eq(1)
-      expect(html.css("button[type=submit]").count).to eq(1)
+
+      expect(html.css("form[action='/admin/ndbn_members/upload_csv']").count).to eq(1)
+      expect(html.css("form[action='/admin/ndbn_members/upload_csv'] input[type=file]").count).to eq(1)
+      expect(html.css("form[action='/admin/ndbn_members/upload_csv'] button[type=submit]").count).to eq(1)
 
       expect(html.css("th").map(&:text)).to match_array(["NDBN Member Number", "Member Name"])
       expect(html.css("tbody tr td").map(&:text)).to match_array(["123", "A Baby Center"])
diff --git a/spec/requests/distributions_requests_spec.rb b/spec/requests/distributions_requests_spec.rb
@@ -87,7 +87,7 @@
         get distributions_path
         page = Nokogiri::HTML(response.body)
         edit = page.at_css("a[href='#{edit_distribution_path(id: distribution.id)}']")
-        reclaim = page.at_css("a.btn-danger[href='#{distribution_path(id: distribution.id)}']")
+        reclaim = page.at_css("form[action='#{distribution_path(id: distribution.id)}'] .btn-danger")
         expect(edit.attr("class")).not_to match(/disabled/)
         expect(reclaim.attr("class")).not_to match(/disabled/)
         expect(response.body).not_to match(/Has Inactive Items/)
@@ -102,7 +102,7 @@
           get distributions_path
           page = Nokogiri::HTML(response.body)
           edit = page.at_css("a[href='#{edit_distribution_path(id: distribution.id)}']")
-          reclaim = page.at_css("a.btn-danger[href='#{distribution_path(id: distribution.id)}']")
+          reclaim = page.at_css("form[action='#{distribution_path(id: distribution.id)}'] .btn-danger")
           expect(edit.attr("class")).to match(/disabled/)
           expect(reclaim.attr("class")).to match(/disabled/)
           expect(response.body).to match(/Has Inactive Items/)
diff --git a/spec/requests/donation_sites_requests_spec.rb b/spec/requests/donation_sites_requests_spec.rb
@@ -24,7 +24,7 @@
         page = Nokogiri::HTML(response.body)
         expect(response.body).to include("An Active Site")
         expect(response.body).not_to include("An Inactive Site")
-        button1 = page.css(".btn[href='/donation_sites/#{active_donation_site.id}/deactivate']")
+        button1 = page.css("form[action='/donation_sites/#{active_donation_site.id}/deactivate'] .btn")
         expect(button1.text.strip).to eq("Deactivate")
         expect(button1.attr('class')).not_to match(/disabled/)
       end
@@ -39,12 +39,12 @@
           expect(response.body).to include("An Inactive Site")
 
           # Active donation site should have deactivate button
-          button1 = page.css(".btn[href='/donation_sites/#{active_donation_site.id}/deactivate']")
+          button1 = page.css("form[action='/donation_sites/#{active_donation_site.id}/deactivate'] .btn")
           expect(button1.text.strip).to eq("Deactivate")
           expect(button1.attr('class')).not_to match(/disabled/)
 
           # Inactive donation site should have reactivate button
-          button2 = page.css(".btn[href='/donation_sites/#{inactive_donation_site.id}/reactivate']")
+          button2 = page.css("form[action='/donation_sites/#{inactive_donation_site.id}/reactivate'] .btn")
           expect(button2.text.strip).to eq("Restore")
           expect(button2.attr('class')).not_to match(/disabled/)
         end
diff --git a/spec/requests/donations_requests_spec.rb b/spec/requests/donations_requests_spec.rb
@@ -251,7 +251,7 @@
           get donation_path(donation.id)
           page = Nokogiri::HTML(response.body)
           edit = page.at_css("a[href='#{edit_donation_path(donation.id)}']")
-          delete = page.at_css("a.btn-danger[href='#{donation_path(donation.id)}']")
+          delete = page.at_css("form[action='#{donation_path(donation.id)}'] .btn-danger")
           expect(edit.attr("class")).to match(/disabled/)
           expect(delete.attr("class")).to match(/disabled/)
           expect(response.body).to match(/please make the following items active: #{item.name}/)
diff --git a/spec/requests/items_requests_spec.rb b/spec/requests/items_requests_spec.rb
@@ -243,12 +243,12 @@
         expect(response.body).to include("NODEACTIVATE")
         expect(response.body).to include("NODELETE")
         expect(response.body).not_to include("NOSIR")
-        button1 = page.css(".btn.btn-danger[href='/items/#{item.id}']")
+        button1 = page.css("form[action='/items/#{item.id}'] .btn.btn-danger")
         expect(button1.text.strip).to eq("Delete")
-        button2 = page.css(".btn[href='/items/#{non_delete_item.id}/deactivate']")
+        button2 = page.css("form[action='/items/#{non_delete_item.id}/deactivate'] .btn")
         expect(button2.text.strip).to eq("Deactivate")
         expect(button2.attr('class')).not_to match(/disabled/)
-        button3 = page.css(".btn[href='/items/#{non_deactivate_item.id}/deactivate']")
+        button3 = page.css("form[action='/items/#{non_deactivate_item.id}/deactivate'] .btn")
         expect(button3.text.strip).to eq("Deactivate")
         expect(button3.attr('class')).to match(/disabled/)
       end
diff --git a/spec/requests/purchases_requests_spec.rb b/spec/requests/purchases_requests_spec.rb
@@ -375,7 +375,7 @@
           get purchase_path(purchase.id)
           page = Nokogiri::HTML(response.body)
           edit = page.at_css("a[href='#{edit_purchase_path(purchase.id)}']")
-          delete = page.at_css("a.btn-danger[href='#{purchase_path(purchase.id)}']")
+          delete = page.at_css("form[action='#{purchase_path(purchase.id)}'] .btn-danger")
           expect(edit.attr("class")).to match(/disabled/)
           expect(delete.attr("class")).to match(/disabled/)
           expect(response.body).to match(/please make the following items active: #{item.name}/)
diff --git a/spec/requests/storage_locations_requests_spec.rb b/spec/requests/storage_locations_requests_spec.rb
@@ -71,7 +71,7 @@
           it "shows a deactivate button" do
             get storage_locations_path(format: response_format)
             page = Nokogiri::HTML(response.body)
-            deactivate_link = page.at_css("a[href='#{storage_location_deactivate_path(storage_location)}']")
+            deactivate_link = page.at_css("form[action='#{storage_location_deactivate_path(storage_location)}'] button")
             expect(deactivate_link.attr("class")).not_to match(/disabled/)
           end
         end
@@ -85,7 +85,7 @@
           it "shows a disabled deactivate button" do
             get storage_locations_path(format: response_format)
             page = Nokogiri::HTML(response.body)
-            deactivate_link = page.at_css("a[href='#{storage_location_deactivate_path(storage_location)}']")
+            deactivate_link = page.at_css("form[action='#{storage_location_deactivate_path(storage_location)}'] button")
             expect(deactivate_link.attr("class")).to match(/disabled/)
           end
         end
diff --git a/spec/system/audit_system_spec.rb b/spec/system/audit_system_spec.rb
@@ -87,7 +87,7 @@
           expect(page).to have_content(audit_quantity)
 
           accept_confirm do
-            click_link "Finalize Audit"
+            click_button "Finalize Audit"
           end
           expect(page.find(".alert-info")).to have_content "Audit is Finalized"
 
@@ -209,7 +209,7 @@
         expect(page).to have_content("Delete Audit")
         expect do
           accept_confirm do
-            click_link "Delete Audit"
+            click_button "Delete Audit"
           end
           expect(page).to have_content("Audit is successfully deleted.")
         end.to change { Audit.count }.by(-1)
@@ -257,7 +257,7 @@
         expect(page).to have_content("Delete Audit")
         expect do
           accept_confirm do
-            click_link "Delete Audit"
+            click_button "Delete Audit"
           end
           expect(page).to have_content("Audit is successfully deleted.")
         end.to change { Audit.count }.by(-1)
@@ -269,7 +269,7 @@
         expect(page).to have_content("Finalize Audit")
         expect do
           accept_confirm do
-            click_link "Finalize Audit"
+            click_button "Finalize Audit"
           end
           expect(page).to have_content("Audit is Finalized.")
         end.to change { Audit.finalized.count }.by(1)
@@ -284,7 +284,7 @@
           expect(page).to have_content("Finalize Audit")
           expect do
             accept_confirm do
-              click_link "Finalize Audit"
+              click_button "Finalize Audit"
             end
             expect(page).to have_content("Audit is Finalized.")
           end.to change { storage_location.size }.by(quantity - item_quantity)
@@ -295,7 +295,7 @@
           visit subject
           expect(page).to have_content("Finalize Audit")
           accept_confirm do
-            click_link "Finalize Audit"
+            click_button "Finalize Audit"
           end
           expect(page).not_to have_content("Resume Audit")
           expect(page).not_to have_content("Delete Audit")
@@ -309,7 +309,7 @@
           visit subject
           expect(page).to have_content("Finalize Audit")
           accept_confirm do
-            click_link "Finalize Audit"
+            click_button "Finalize Audit"
           end
           expect(page).not_to have_content("Delete Audit")
           # Actual Deletion(`delete :destroy`) Check is done in audits_controller_spec
@@ -332,7 +332,7 @@
             visit subject
             expect do
               accept_confirm do
-                click_link "Finalize Audit"
+                click_button "Finalize Audit"
               end
               expect(page).to have_content("Audit is Finalized.")
             end.to change { storage_location.size }.by(quantity - item_quantity)
diff --git a/spec/system/authorization_system_spec.rb b/spec/system/authorization_system_spec.rb
@@ -46,7 +46,7 @@
         visit new_distribution_path
         select "Test Partner", from: "Partner"
         select "Test Storage Location", from: "From storage location"
-        first('input[name="authenticity_token"]', visible: false).set("NOTAVALIDCSRFTOKEN")
+        first('form[action="/distributions"] input[name="authenticity_token"]', visible: false).set("NOTAVALIDCSRFTOKEN")
         page.execute_script("$(\"meta[name='csrf-token']\").attr('content', 'NOTAVALIDCSRFTOKEN');")
         click_button "Save"
         expect(current_path).to eql new_distribution_path
diff --git a/spec/system/barcode_item_system_spec.rb b/spec/system/barcode_item_system_spec.rb
@@ -76,7 +76,7 @@
 
       visit subject
       expect(page).to have_content("barcode_to_delete")
-      click_link "Delete"
+      click_button "Delete"
       expect(page).to have_content("Barcode deleted!")
       expect(page).not_to have_content("barcode_to_delete")
     end
@@ -87,7 +87,7 @@
 
       visit subject
       expect(page).to have_content(b_item.value)
-      ferrum_double_click('a.btn.btn-danger.btn-xs[href*="/barcode_items/"]')
+      ferrum_double_click('form[action*="/barcode_items/"] .btn.btn-danger.btn-xs')
       expect(page).to have_content("Barcode deleted!")
       expect(page).not_to have_content("barcode_to_delete")
       expect(page).not_to have_content("Sorry, you don't have permission to delete this barcode.")
diff --git a/spec/system/distribution_system_spec.rb b/spec/system/distribution_system_spec.rb
@@ -877,12 +877,12 @@
     # therefore the confirmation modal does not appear here.
 
     expect(page).to have_content("Distribution Complete")
-    expect(page).to have_link("Distribution Complete")
+    expect(page).to have_button("Distribution Complete")
 
     expect(View::Inventory.new(organization.id)
       .quantity_for(item_id: item.id, storage_location: storage_location.id)).to eq(0)
 
-    click_link "Distribution Complete"
+    click_button "Distribution Complete"
     expect(page).to have_content('Distribution')
 
     expect(page).to have_content("This distribution has been marked as being completed!")
@@ -909,10 +909,10 @@
     end
 
     # Make sure the button is there before trying to double click it
-    expect(page.find('a.btn.btn-success.btn-md[href*="/picked_up"]')).to have_content("Distribution Complete")
+    expect(page.find('form[action*="/picked_up"] .btn.btn-success.btn-md')).to have_content("Distribution Complete")
 
     # Double click on the Distribution complete button
-    ferrum_double_click('a.btn.btn-success.btn-md[href*="/picked_up"]')
+    ferrum_double_click('form[action*="/picked_up"] .btn.btn-success.btn-md')
 
     # Capybara will be quick to determine that a screen doesn't have content.
     # Make some positive assertions that only appears on the new screen to make
diff --git a/spec/system/donation_system_spec.rb b/spec/system/donation_system_spec.rb
@@ -733,7 +733,7 @@
       end
 
       it "allows deletion of a donation" do
-        expect(page).to have_link("Delete")
+        expect(page).to have_button("Delete")
 
         accept_confirm do
           click_on "Delete", match: :first
diff --git a/spec/system/organization_system_spec.rb b/spec/system/organization_system_spec.rb
@@ -13,7 +13,7 @@
       visit organization_path
       accept_confirm do
         click_button dom_id(managed_user, "dropdownMenu")
-        click_link "Remove User"
+        click_button "Remove User"
       end
 
       expect(page).to have_content("User has been removed!")
@@ -24,7 +24,7 @@
       visit organization_path
       accept_confirm do
         click_button dom_id(managed_user, "dropdownMenu")
-        click_link "Promote to Admin"
+        click_button "Promote to Admin"
       end
 
       expect(page).to have_content("User has been promoted!")
@@ -35,7 +35,7 @@
       managed_user.add_role(Role::ORG_ADMIN, organization)
       visit organization_path
       accept_confirm do
-        click_link "Demote to User"
+        click_button "Demote to User"
       end
 
       expect(page).to have_content("User has been demoted!")
diff --git a/spec/system/partner_system_spec.rb b/spec/system/partner_system_spec.rb
@@ -51,7 +51,6 @@
           # If it tries to mark the partner as approved twice, the second time
           # will fail (the partner is already approved) and show this error
           expect(page).not_to have_content('Failed to approve partner because: ["partner is not waiting for approval"]')
-          # TODO: Verify multiple emails aren't sent?
         end
       end
 
@@ -102,7 +101,7 @@
           assert page.has_content? "Partner #{partner_attributes[:name]} added!"
 
           accept_confirm do
-            find('tr', text: partner_attributes[:name]).find_link('Invite').click
+            find('tr', text: partner_attributes[:name]).find_button('Invite').click
           end
 
           assert page.has_content? "Partner #{partner_attributes[:name]} invited!"
diff --git a/spec/system/purchase_system_spec.rb b/spec/system/purchase_system_spec.rb
@@ -302,7 +302,7 @@
       it "does not allow deletion of a purchase" do
         purchase = create(:purchase, organization: organization)
         visit "#{subject}/#{purchase.id}"
-        expect(page).to_not have_link("Delete")
+        expect(page).to_not have_button("Delete")
       end
     end
   end
@@ -318,7 +318,7 @@
     context "When the purchase remains in storage location" do
       it "allows deletion of a purchase" do
         visit "#{subject}/#{purchase.id}"
-        expect(page).to have_link("Delete")
+        expect(page).to have_button("Delete")
         accept_confirm do
           click_on "Delete"
         end
@@ -332,7 +332,7 @@
         allow(PurchaseDestroyService).to receive(:call).with(purchase).and_raise(InventoryError)
 
         visit "#{subject}/#{purchase.id}"
-        expect(page).to have_link("Delete")
+        expect(page).to have_button("Delete")
         accept_confirm do
           click_on "Delete"
         end
diff --git a/spec/system/storage_location_system_spec.rb b/spec/system/storage_location_system_spec.rb
@@ -134,7 +134,9 @@
       location1 = create(:storage_location, :with_items)
       visit subject
 
-      expect(page).to have_link('Deactivate', class: "disabled", href: "/storage_locations/#{location1.id}/deactivate")
+      within "form[action='/storage_locations/#{location1.id}/deactivate']" do
+        expect(page).to have_button('Deactivate', class: "disabled")
+      end
     end
 
     it "Allows user to deactivate and reactivate storage locations" do
diff --git a/spec/system/transfer_system_spec.rb b/spec/system/transfer_system_spec.rb
@@ -80,7 +80,7 @@ def create_transfer(amount, from_name, to_name, click_save: true, click_confirm:
     expect(inventory.quantity_for(storage_location: to_storage_location.id, item_id: item.id)).to eq(transfer_amount)
 
     accept_confirm do
-      click_link 'Delete'
+      click_button 'Delete'
     end
 
     expect(page).to have_content(/Successfully deleted Transfer/)
@@ -109,7 +109,7 @@ def create_transfer(amount, from_name, to_name, click_save: true, click_confirm:
     allow(TransferDestroyEvent).to receive(:publish).and_raise('OH NOES')
 
     accept_confirm do
-      click_link 'Delete'
+      click_button 'Delete'
     end
 
     expect(page).to have_content(/OH NOES/)
diff --git a/spec/system/vendor_system_spec.rb b/spec/system/vendor_system_spec.rb
@@ -28,20 +28,20 @@
     end
 
     it "should deactivate a vendor when the deactivate button is clicked" do
-      expect { click_link "Deactivate", match: :first }.to change { @first.reload.active }.to(false)
+      expect { click_button "Deactivate", match: :first }.to change { @first.reload.active }.to(false)
     end
 
     it "should reactivate a vendor when the reactivate button is clicked" do
-      expect { click_link "Deactivate", match: :first }.to change { @first.reload.active }.to(false)
+      expect { click_button "Deactivate", match: :first }.to change { @first.reload.active }.to(false)
 
       check "include_inactive_vendors"
       click_button "Filter"
 
-      expect { click_link "Reactivate", match: :first }.to change { @first.reload.active }.to(true)
+      expect { click_button "Reactivate", match: :first }.to change { @first.reload.active }.to(true)
     end
 
     it "should delete when vendor does not have purchases items" do
-      expect { click_link "Delete" }.to change(Vendor, :count).by(-1)
+      expect { click_button "Delete" }.to change(Vendor, :count).by(-1)
       expect(page).to have_content("#{@last.business_name} has been removed.")
     end
 
