Merge pull request #5092 from mateusmsf94/5065-validation-negative-numbers

Add validation for money_raised in Donation model to ensure it is non…

Author: awwaiid

app/models/donation.rb

@@ -61,6 +61,7 @@ class Donation < ApplicationRecord
   validates :manufacturer, presence:
     { message: "must be specified since you chose '#{SOURCES[:manufacturer]}'" }, if: :from_manufacturer?
   validates :source, presence: true, inclusion: { in: SOURCES.values, message: "Must be a valid source." }
+  validates :money_raised, numericality: { greater_than_or_equal_to: 0 }, allow_nil: true
   validate :line_items_quantity_is_positive
 
   # TODO: move this to Organization.donations as an extension

spec/models/donation_spec.rb

@@ -63,6 +63,12 @@
       d.line_items << build(:line_item, quantity: -1)
       expect(d).not_to be_valid
     end
+    it "ensures that money_raised cannot be negative" do
+      expect(build(:donation, money_raised: -1)).not_to be_valid
+      expect(build(:donation, money_raised: 0)).to be_valid
+      expect(build(:donation, money_raised: 100)).to be_valid
+      expect(build(:donation, money_raised: nil)).to be_valid
+    end
   end
 
   context "Callbacks >" do

spec/requests/donations_requests_spec.rb

@@ -108,6 +108,7 @@
       let(:manufacturer) { create(:manufacturer, organization:) }
       let(:source) { Donation::SOURCES[:manufacturer] }
       let(:issued_at) { Date.yesterday }
+      let(:money_raised) { 5 }
 
       let(:params) do
         {
@@ -116,7 +117,7 @@
             manufacturer_id: manufacturer.id,
             product_drive_id: product_drive.id,
             storage_location_id: storage_location.id,
-            money_raised_in_dollars: 5,
+            money_raised_in_dollars: money_raised,
             product_drive_participant_id: nil,
             comment: "",
             issued_at: issued_at,
@@ -146,6 +147,15 @@
           expect(flash[:error]).to include("Issue date can't be blank")
         end
       end
+
+      context "with negative money raised" do
+        let(:money_raised) { -5 }
+
+        it "flashes the correct validation error" do
+          post donations_path(params)
+          expect(flash[:error]).to include("Money raised must be greater than or equal to 0")
+        end
+      end
     end
 
     describe "PATCH #update" do
@@ -168,6 +178,15 @@
           expect(flash[:alert]).to include("Issue date can't be blank")
         end
       end
+
+      context "with negative money raised" do
+        it "flashes the correct validation error" do
+          donation_params[:money_raised_in_dollars] = -5
+          put donation_path(params)
+
+          expect(flash[:alert]).to include("Money raised must be greater than or equal to 0")
+        end
+      end
     end
 
     describe "GET #print" do