Perf: Refactor dashboard index page (#4874)

Author: coalest

app/controllers/dashboard_controller.rb

@@ -4,9 +4,13 @@ class DashboardController < ApplicationController
 
   def index
     @org_stats = OrganizationStats.new(current_organization)
-    @total_inventory = current_organization.total_inventory
     @partners_awaiting_review = current_organization.partners.awaiting_review
-    @outstanding_requests = current_organization.ordered_requests.where(status: %i[pending started]).order(:created_at)
+    @outstanding_requests = current_organization
+      .ordered_requests
+      .includes(:partner_user, :partner)
+      .where(status: %i[pending started])
+      .order(:created_at)
+      .limit(25)
 
     @low_inventory_report = LowInventoryQuery.call(current_organization)
 

app/views/dashboard/_outstanding_requests.html.erb

@@ -8,7 +8,7 @@
     footer_options: { class: "text-center" },
   ) do
 %>
-  <% if @outstanding_requests.empty? %>
+  <% if @outstanding_requests.length.zero? %>
     No outstanding requests!
   <% else %>
     <table class="table table-hover striped">
@@ -21,12 +21,12 @@
         </tr>
       </thead>
       <tbody>
-        <% @outstanding_requests.take(25).each do |item| %>
+        <% @outstanding_requests.each do |request| %>
           <tr>
-            <td class="date"><%= link_to item.created_at.strftime("%m/%d/%Y"), item %></td>
-            <td><%= item.partner.name %></td>
-            <td><%= item.partner_user&.formatted_email %></td>
-            <td><%= item.comments %></td>
+            <td class="date"><%= link_to request.created_at.strftime("%m/%d/%Y"), request %></td>
+            <td><%= request.partner.name %></td>
+            <td><%= request.partner_user&.formatted_email %></td>
+            <td><%= request.comments %></td>
           </tr>
         <% end %>
       </tbody>